-
-
Notifications
You must be signed in to change notification settings - Fork 53
Feature/GitHub copilot action environment #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…erver installation steps
…ion on push and pull request events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces a GitHub Actions workflow that automates Unity development environment setup for GitHub Copilot. The workflow validates setup steps when modified and can be manually triggered, ensuring a reproducible Unity development environment with the MCP server.
Key changes:
- New GitHub Actions workflow for automated Copilot setup validation
- Docker-based Unity Editor and Unity-MCP-Server environment initialization
- Unity Editor initialization monitoring with licensing issue handling
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.gitignore |
Added .secrets to prevent accidental commit of sensitive data |
.github/workflows/copilot-setup-steps.yml |
New workflow that sets up Unity Editor and MCP Server containers for Copilot development environment, includes initialization monitoring and error handling |
|
@IvanMurzak I've opened a new pull request, #309, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: IvanMurzak <9135028+IvanMurzak@users.noreply.github.com>
|
@IvanMurzak I've opened a new pull request, #310, to work on those changes. Once the pull request is ready, I'll request review from you. |
Add explicit Docker network for container-to-container communication
…ithub.com/IvanMurzak/Unity-MCP into feature/github-copilot-action-environment
Co-authored-by: IvanMurzak <9135028+IvanMurzak@users.noreply.github.com>
[WIP] WIP address feedback from review on copilot action
- Remove tail fallback to ensure Unity launch failures are properly reported - Add proper error handling when Unity fails to start with detailed logs - Fix Unity process detection to check for both "Unity" and "unity-editor" process names - Add container status monitoring to detect if Unity crashes - Ensure docker run -d keeps the job non-blocking while running in background - Add detailed error messages with full Unity logs on failure
- Start Unity Editor container without launching Unity immediately - Create Unity license directory structure at /root/.local/share/unity3d/Unity/ - Write UNITY_LICENSE secret content to Unity_lic.ulf file - Start Unity Editor process after license is in place - This fixes the "No valid Unity Editor license found" error
…nd license handling
This pull request adds a new GitHub Actions workflow for Copilot setup steps. The workflow automates environment preparation for Unity development and ensures that setup steps are validated automatically when changed, while also allowing manual execution from the Actions tab.
New Copilot setup workflow for Unity environment:
.github/workflows/copilot-setup-steps.ymlto define a new workflow that runs on changes and manual dispatch, specifically for Copilot setup steps.Unity environment initialization steps: