Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #43 mac libs should be linked against @rpath #145

Merged
merged 6 commits into from
Aug 25, 2018

Conversation

koskokos2
Copy link
Contributor

This is fix for #43 mac. The best way how to deal with a problem of absolute paths embedded into binary is to replace the with @rpath, it requires list of paths where to look for libraries. Also I stopped linking against all libs libcurl depends on and link only against libcurl as this binary only depends on libcurl and libcurl itself handling its own dependencies just fine.

@simiansim
Copy link

simiansim commented Aug 20, 2018

@koskokos2 or @JCMais I think this line might need a semi colon:
CURL_PREFIX=/usr/local;
https://github.com/koskokos2/node-libcurl/blob/linking-improvement-mac/.travis.yml#L88

When run by travis...

if [[ $TRAVIS_OS_NAME == "osx" ]]; then
   CURL_PREFIX=/usr/local
fi

it look like this gets rewritten into

if [[ $TRAVIS_OS_NAME == "osx" ]]; then CURL_PREFIX=/usr/local fi

And so the bash "fi" is lost within the "then"

@koskokos2
Copy link
Contributor Author

yeah right thanks, used to regular bash scripting and here that is just single line, so needs that semicolon

@simiansim
Copy link

Awesome then, Cheers. This issue has bugged me for a while. You seem to have the insight required. Happy to help.

@JCMais
Copy link
Owner

JCMais commented Aug 21, 2018

I will merge this on this weekend and create a pre-release for it so it can be tested.

Thanks for all the work you have done on this

@JCMais JCMais merged commit 56c2be4 into JCMais:develop Aug 25, 2018
binding.gyp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants