Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Discord event link hanging issue #111

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Commits on Apr 25, 2024

  1. Fix Discord event link hanging issue

    When a sync has been performed, the old implementation causes a release of the database PoolClient, causing any future database operation to fail.
    This is due to the event sync code being triggered from the context of GraphQL queries instead of a separate context when an incoming event from Discord is processed.
    
    The code has now been rewritten to take the context.pgClient database client which is the current GraphQL pgClient.
    This client is used in all database operations and not released so it can be used in the future.
    This will stop the hanging of the server when a Discord event link sync is done.
    
    This issue was only reliable reproducible with quite some members interested in an event. I tested this with 13 people interested.
    
    In the future we should rewrite this code to always take a pgClient in the database code and create a new pgClient at a higher level when not available and otherwise always use the context.pgClient.
    At lower levels we should not be caring about releasing or not because this can only cause issues.
    JJ-8 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1e19acf View commit details
    Browse the repository at this point in the history