|
14 | 14 | message: > |
15 | 15 | JUnit tests of `jablib` are failing. |
16 | 16 | You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. |
17 | | - To see the test output, locate "Tests / Unit tests (pull_request)" and click on it. |
| 17 | + To see the test output, locate "Source Code Tests / Unit tests (pull_request)" and click on it. |
18 | 18 |
|
19 | 19 |
|
20 | 20 | You can then run these tests in IntelliJ to reproduce the failing tests locally. |
|
24 | 24 | message: > |
25 | 25 | JUnit tests of `jabkit` are failing. |
26 | 26 | You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. |
27 | | - To see the test output, locate "Tests / Unit tests (pull_request)" and click on it. |
| 27 | + To see the test output, locate "Source Code Tests / Unit tests (pull_request)" and click on it. |
28 | 28 |
|
29 | 29 |
|
30 | 30 | You can then run these tests in IntelliJ to reproduce the failing tests locally. |
|
34 | 34 | message: > |
35 | 35 | JUnit tests of `jabsrv` are failing. |
36 | 36 | You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. |
37 | | - To see the test output, locate "Tests / Unit tests (pull_request)" and click on it. |
| 37 | + To see the test output, locate "Source Code Tests / Unit tests (pull_request)" and click on it. |
38 | 38 |
|
39 | 39 |
|
40 | 40 | You can then run these tests in IntelliJ to reproduce the failing tests locally. |
|
45 | 45 | Your code currently does not meet [JabRef's code guidelines](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-13-code-style.html). |
46 | 46 | We use [Checkstyle](https://checkstyle.sourceforge.io/) to identify issues. |
47 | 47 | You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. |
48 | | - To see the test output, locate "Tests / Checkstyle (pull_request)" and click on it. |
| 48 | + To see the test output, locate "Source Code Tests / Checkstyle (pull_request)" and click on it. |
49 | 49 |
|
50 | 50 |
|
51 | 51 | In case of issues with the import order, double check that you [activated Auto Import](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-13-code-style.html#enable-proper-import-cleanup). |
|
60 | 60 | Your code currently does not meet JabRef's code guidelines. |
61 | 61 | We use [OpenRewrite](https://docs.openrewrite.org/) to ensure "modern" Java coding practices. |
62 | 62 | You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. |
63 | | - To see the test output, locate "Tests / OpenRewrite (pull_request)" and click on it. |
| 63 | + To see the test output, locate "Source Code Tests / OpenRewrite (pull_request)" and click on it. |
64 | 64 |
|
65 | 65 |
|
66 | 66 | The issues found can be **automatically fixed**. |
|
71 | 71 | Your code currently does not meet JabRef's code guidelines. |
72 | 72 | We use [Gradle Modernizer Plugin](https://github.com/andygoossens/gradle-modernizer-plugin#gradle-modernizer-plugin) to ensure "modern" Java coding practices. |
73 | 73 | You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. |
74 | | - To see the test output, locate "Tests / Modernizer (pull_request)" and click on it. |
| 74 | + To see the test output, locate "Source Code Tests / Modernizer (pull_request)" and click on it. |
75 | 75 |
|
76 | 76 |
|
77 | 77 | Please fix the detected errors, commit, and push. |
|
130 | 130 | Hey, we noticed that you **force-pushed** your changes. |
131 | 131 | Force pushing is a bad practice when working together on a project (mainly because it is [not supported well by GitHub itself](https://github.com/orgs/community/discussions/3478)). |
132 | 132 | Commits are lost and comments on commits lose their context, thus making it harder to review changes. |
133 | | - At the end, all commits will be [squashed](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits) anyway before being merged into the `main` branch. |
| 133 | +
|
| 134 | +
|
| 135 | + When the pull request is getting integrated into `main`, all commits will be [squashed](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits) anyway. |
| 136 | + Thus, your individual commit history will not be visible in `main`. |
134 | 137 |
|
135 | 138 |
|
136 | 139 | In future, **please avoid that**. For now, you can continue working. |
|
0 commit comments