Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single word journal titles show up with an alert #4115

Closed
pbreheny opened this issue Jun 7, 2018 · 5 comments
Closed

Single word journal titles show up with an alert #4115

pbreheny opened this issue Jun 7, 2018 · 5 comments
Assignees

Comments

@pbreheny
Copy link

pbreheny commented Jun 7, 2018

Not sure when this problem was introduced, but in JabRef 4.3.1, single-word journal titles show up with an orange alert triangle as if they were incorrectly formatted:

jabref-crop

Perhaps this is an issue with checking for correct case? The problem goes away if you change the entry to "Bioinformatics X" or something.

Not a huge deal, but kind of distracting to see "false positive" alerts like this.

@stefan-kolb
Copy link
Member

Not all single word journal titles but only if an abbreviation is detected. see http://help.jabref.org/en/JournalAbbreviations

@stefan-kolb stefan-kolb added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jun 7, 2018
@pbreheny
Copy link
Author

pbreheny commented Jun 7, 2018

Hmm...I still don't see why this should be flagged with an alert. The abbreviation for most one-word journal titles is just the journal title (i.e., it doesn't need an abbreviation):

jabref-crop

It seems, then, there is no way to avoid having an alert show up for such journals?

@stefan-kolb
Copy link
Member

Good catch!

@stefan-kolb stefan-kolb added type: enhancement and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Jun 7, 2018
@tobiasdiez tobiasdiez self-assigned this Jun 7, 2018
tobiasdiez added a commit that referenced this issue Jun 7, 2018
tobiasdiez added a commit that referenced this issue Jun 13, 2018
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

Siedlerchr added a commit that referenced this issue Jun 15, 2018
* upstream/master: (22 commits)
  fix failing architecture test by making test class public again migrate architecture test to junit jupiter
  Fix build... (#4128)
  fix checkstyle after merge
  Migrate Review field in entry preview to comment (#4100)
  [WIP] Split push to applications in logic and gui (#4110)
  Fix checkstyle
  Fix #4115: Don't report journal name as abbreviated when full name = abbreviated name (#4116)
  Use <kbd>in changelog
  Groups right click (#4061)
  Fix open thread prevents shutdown (#4111)
  Extract v4.x changelog (#4125)
  Saves and reloads window state on close and on open (#4124)
  Fix convert to bibtex moves contents of the file field (#4123)
  Opens the directory of the currently edited file when opening a new file (#4106)
  Don't run on Swing thread
  Properly shutdown telemetry client
  Code cleanup
  Remove Swing stuff (L&F, font customization)
  Properly shutdown JabRef (not with System.exit)
  Replace swing clipboard with JavaFX one
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/BasePanel.java
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/gui/maintable/MainTable.java
#	src/main/java/org/jabref/gui/search/SearchResultFrame.java
#	src/main/java/org/jabref/preferences/JabRefPreferences.java
@Siedlerchr
Copy link
Member

Is this the same issue as #3925 and now fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants