Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing font size makes font size field too small #7085

Closed
1 task done
crystalfp opened this issue Nov 9, 2020 · 5 comments · Fixed by #7398
Closed
1 task done

Changing font size makes font size field too small #7085

crystalfp opened this issue Nov 9, 2020 · 5 comments · Fixed by #7398
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@crystalfp
Copy link

JabRef 5.2--2020-11-04--fcbe9c5
Windows 10 10.0 amd64
Java 14.0.2

Changing font size makes font size field too small (see screenshot below)

Steps to reproduce the behavior:

  1. Go to Preferences > Appearance and tick "Override default font setting"
  2. Set font size to 12
  3. Save and reenter JabRef
  4. The font size field show only the "1" of the "12".

Note that sometime the font size is not changed for the preference dialog and sometime the bug does not appear, but was unable to determine under which conditions this happens.

image

@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Nov 9, 2020
@calixtus
Copy link
Member

JabRef is internally using pixels to define widths. A solution would be to change every width indication to 'em'.

@crystalfp
Copy link
Author

Is this something that I can change in a custom theme?

@calixtus
Copy link
Member

calixtus commented Nov 10, 2020

I was just taking a note for ourself or somebody, who wants to work on this issue. The em indications are dependend on the font size an should automatically scale. There should be plenty of examples on the web about this (eg https://stackoverflow.com/questions/32999605/how-can-i-change-the-base-font-size-in-javafx-8-modena-theme-that-would-cascade#33001277 )
To solve this issue a lot can be done by editing the base.css theme file, but some things are somewhat hardwired in the fxml files and the ui Java sources in the codebase. That's one bad thing about the somewhat old codebase of JabRef, we are working on since some years, to modernize, sort and simplify everything.
If you like to give it a shot make a pull request with your changes. The PR does not have to be perfect and cover everything (although it would be very cool), but we can talk about it as soon it exists or work together on it.

@Sylvan1985
Copy link

There're other similar problems in the preferences, due to the fixed prefWidth. Like in the Entry table, the Colums will be hard to see and set.
Size_pr

@aschloe
Copy link

aschloe commented Nov 18, 2020

By the way, in the latest master version this only happens if you leave the preferences window briefly and reopen it, without closing JabRef. That's because when restarting JabRef, the preferences window no longer respects the custom font size.
Is there already an issue for that separate bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants