Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving library doesn't create .bib file but a file without ending #7451

Closed
State-Of-Joshing-Gentle-Peevishness opened this issue Feb 17, 2021 · 8 comments · Fixed by #7726
Closed
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. os: linux

Comments

@State-Of-Joshing-Gentle-Peevishness

File > New library and then Save library > choose name > lower right corner choose BIBTEX_DB file (only option) > Save
or File > Save library as > choose name > lower right corner choose BIBTEX_DB file (only option) > Save
File is saved without any ending. Expected to be saved as .bib instead, as none(?) other file-endings are displayed when using File > Open library.

Workaround: add .bib manually when choosing name.

JabRef 5.2--2020-12-24--6a2a512
Linux 5.8.0-43-generic amd64
Java 15.0.1

@State-Of-Joshing-Gentle-Peevishness State-Of-Joshing-Gentle-Peevishness changed the title Saving library doesn't create .bib file Saving library doesn't create .bib file but a file without ending Feb 17, 2021
@Siedlerchr
Copy link
Member

Siedlerchr commented Feb 27, 2021

I cannot reproduce this isuse with the latest master version under Mac. Extension is added. Maybe some linux thing?

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Feb 27, 2021
@mlep
Copy link
Contributor

mlep commented Feb 27, 2021

Well, easy to reproduce on Linux.

JabRef 5.3--2021-02-27--c7f2671
Linux 4.19.0-14-amd64 amd64
Java 15.0.2
JavaFX 15.0.1+1

@Siedlerchr Siedlerchr added os: linux and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Feb 27, 2021
@Siedlerchr
Copy link
Member

Okay, this is weird. After a bit of googling I stumbled across this bug which says it's intended for GTK applications: (wtf?)
Some applications add the extension, other not (gedit)
https://bugs.openjdk.java.net/browse/JDK-8123775

Well, the fix would be easy:
Check if the file returned from the file extension dialog contains the extension
Check if the file with extension already exists ->

  • Yes = > cancel/throw an error :
  • Not => save file with extension

@LyzardKing Do you maybe know if there is a kind of "flag" to add or not add the extension?

@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Mar 19, 2021
@aakarshvats638
Copy link

I would like to work on this issue if it is reproducible on windows

@LyzardKing
Copy link
Collaborator

@LyzardKing Do you maybe know if there is a kind of "flag" to add or not add the extension?

Do you mean in the save dialog? I'm not sure...

@ryanhore23
Copy link

I see this issue has been tagged with Linux, a small group of us from Adelaide University would love to contribute to this issue over the course of the coming weeks.

@srdeotarse
Copy link

I want to participate in GSOC 2021 , so would like to solve this issue as I have set up local workspace on Ubuntu 20.04 and successfully reproduced the issue @Siedlerchr

@LyzardKing
Copy link
Collaborator

The better solution here would be to fix it upstream in openjfx.
A quick fix in jabref would be trivial (as @Siedlerchr says), but not really solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. os: linux
Projects
Archived in project
7 participants