Skip to content

Fix autosave manager exception on shutdown #13882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koppor merged 11 commits into from
Sep 13, 2025
Merged

Fix autosave manager exception on shutdown #13882

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b6451f1
fix git modules requires and uses
Siedlerchr Aug 14, 2025
9bee24f
Merge remote-tracking branch 'upstream/main'
Siedlerchr Aug 21, 2025
c0d0a7c
Merge remote-tracking branch 'upstream/main'
Siedlerchr Aug 27, 2025
2c4d427
Merge remote-tracking branch 'upstream/main'
Siedlerchr Aug 28, 2025
5277005
Merge remote-tracking branch 'upstream/main'
Siedlerchr Sep 8, 2025
511549f
Merge remote-tracking branch 'upstream/main'
Siedlerchr Sep 9, 2025
2a819aa
Merge remote-tracking branch 'upstream/main'
Siedlerchr Sep 10, 2025
aa1818f
Merge remote-tracking branch 'upstream/main'
Siedlerchr Sep 11, 2025
87abac1
Merge remote-tracking branch 'upstream/main'
Siedlerchr Sep 13, 2025
4882129
Merge remote-tracking branch 'upstream/main'
Siedlerchr Sep 13, 2025
25f84ac
Fix Autosave manager exception on shutdown
Siedlerchr Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions jabgui/src/main/java/org/jabref/gui/autosaveandbackup/AutosaveManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ private AutosaveManager(BibDatabaseContext bibDatabaseContext, CoarseChangeFilte
this.executor.scheduleAtFixedRate(
() -> {
if (needsSave) {
eventBus.post(new AutosaveEvent());
needsSave = false;
eventBus.post(new AutosaveEvent());
needsSave = false;
}
},
DELAY_BETWEEN_AUTOSAVE_ATTEMPTS_IN_SECONDS,
Expand All @@ -61,7 +61,11 @@ public void listen(@SuppressWarnings("unused") BibDatabaseContextChangedEvent ev
}

private void shutdown() {
coarseChangeFilter.unregisterListener(this);
try {
coarseChangeFilter.unregisterListener(this);
} catch (IllegalArgumentException e) {
// ignore exception if the listener was not registered before
}
runningInstances.remove(this);
}

Expand All @@ -83,7 +87,7 @@ public static AutosaveManager start(BibDatabaseContext bibDatabaseContext, Coars
*/
public static void shutdown(BibDatabaseContext bibDatabaseContext) {
runningInstances.stream().filter(instance -> instance.bibDatabaseContext == bibDatabaseContext).findAny()
.ifPresent(instance -> instance.shutdown());
.ifPresent(AutosaveManager::shutdown);
}

public void registerListener(Object listener) {
Expand Down
Loading