From a273d8c03f512a928b3f06f2a7ac0c41fa559a8a Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Sun, 14 Sep 2025 22:25:01 +0200 Subject: [PATCH 01/18] Add new check for format --- .github/workflows/tests-code.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/tests-code.yml b/.github/workflows/tests-code.yml index 901526eeafc..d12af1339af 100644 --- a/.github/workflows/tests-code.yml +++ b/.github/workflows/tests-code.yml @@ -114,6 +114,17 @@ jobs: run: | ./gradlew --no-configuration-cache :rewriteDryRun + format: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v5 + - uses: koppor/intellij-format@update-to-latest-intellij + with: + mask: *.java + settings: "config/IntelliJ Code Style.xml" + message: "" + verify: true + modernizer: name: Modernizer runs-on: ubuntu-latest From 6f9b3539e3baf4a3da91812e5ceb67bb0b5b158e Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Sun, 14 Sep 2025 22:30:45 +0200 Subject: [PATCH 02/18] Introduce formatting issue --- .../jabref/logic/ai/summarization/GenerateSummaryTask.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/jablib/src/main/java/org/jabref/logic/ai/summarization/GenerateSummaryTask.java b/jablib/src/main/java/org/jabref/logic/ai/summarization/GenerateSummaryTask.java index 72a8e4b94fc..97264edb583 100644 --- a/jablib/src/main/java/org/jabref/logic/ai/summarization/GenerateSummaryTask.java +++ b/jablib/src/main/java/org/jabref/logic/ai/summarization/GenerateSummaryTask.java @@ -208,9 +208,7 @@ public String summarizeOneDocument(String filePath, String document) throws Inte int passes = 0; - // @formatter:off - do { - // @formatter:on + do{ passes++; LOGGER.debug("Summarizing chunk(s) for file \"{}\" of entry {} ({} pass)", filePath, citationKey, passes); From 3a98a4ad6476908320631a9ddccfdc97422a1d94 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Sun, 14 Sep 2025 22:40:05 +0200 Subject: [PATCH 03/18] Fix quotes --- .github/workflows/tests-code.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-code.yml b/.github/workflows/tests-code.yml index d12af1339af..5912732efcf 100644 --- a/.github/workflows/tests-code.yml +++ b/.github/workflows/tests-code.yml @@ -120,7 +120,7 @@ jobs: - uses: actions/checkout@v5 - uses: koppor/intellij-format@update-to-latest-intellij with: - mask: *.java + mask: "*.java" settings: "config/IntelliJ Code Style.xml" message: "" verify: true From 533bc5bf5134178bea8ff73f3af5646eb221880e Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Sun, 14 Sep 2025 23:24:56 +0200 Subject: [PATCH 04/18] Try to fix parameter --- .github/workflows/tests-code.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-code.yml b/.github/workflows/tests-code.yml index 5912732efcf..03d5d6069dd 100644 --- a/.github/workflows/tests-code.yml +++ b/.github/workflows/tests-code.yml @@ -121,7 +121,7 @@ jobs: - uses: koppor/intellij-format@update-to-latest-intellij with: mask: "*.java" - settings: "config/IntelliJ Code Style.xml" + settings: '"config/IntelliJ Code Style.xml"' message: "" verify: true From 0e0ba7a6d655dd738a61ab0717c09b6e289dabcf Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Sun, 14 Sep 2025 23:56:03 +0200 Subject: [PATCH 05/18] Change action --- .github/workflows/tests-code.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/tests-code.yml b/.github/workflows/tests-code.yml index 03d5d6069dd..e712cd209e8 100644 --- a/.github/workflows/tests-code.yml +++ b/.github/workflows/tests-code.yml @@ -118,12 +118,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v5 - - uses: koppor/intellij-format@update-to-latest-intellij + - uses: koppor/intellij-idea-format@update-to-latest-intellij with: - mask: "*.java" - settings: '"config/IntelliJ Code Style.xml"' - message: "" - verify: true + file-mask: "*.java" + settings-file: "config/IntelliJ Code Style.xml" modernizer: name: Modernizer From 6f285ffad70dbe4e79e085a9468bdf664ea6dda3 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Sun, 14 Sep 2025 23:56:47 +0200 Subject: [PATCH 06/18] Add failing --- .github/workflows/tests-code.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/tests-code.yml b/.github/workflows/tests-code.yml index e712cd209e8..d4fe928c344 100644 --- a/.github/workflows/tests-code.yml +++ b/.github/workflows/tests-code.yml @@ -122,6 +122,8 @@ jobs: with: file-mask: "*.java" settings-file: "config/IntelliJ Code Style.xml" + # job should fail in case there are changes + - run: git diff-files --quiet modernizer: name: Modernizer From 458970113400fcc3435f34fae0a5fd713218f786 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Mon, 15 Sep 2025 00:01:44 +0200 Subject: [PATCH 07/18] Add another bad thing --- .../org/jabref/http/server/resources/LibrariesResource.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jabsrv/src/main/java/org/jabref/http/server/resources/LibrariesResource.java b/jabsrv/src/main/java/org/jabref/http/server/resources/LibrariesResource.java index b8dbb9f9b5b..7d17b24d961 100644 --- a/jabsrv/src/main/java/org/jabref/http/server/resources/LibrariesResource.java +++ b/jabsrv/src/main/java/org/jabref/http/server/resources/LibrariesResource.java @@ -19,10 +19,10 @@ public class LibrariesResource { @Inject - private SrvStateManager srvStateManager; + private SrvStateManager srvStateManager; @Inject - private FilesToServe filesToServe; + private FilesToServe filesToServe; @Inject private Gson gson; From e3840290c92008a2c9f30003e1579f88d9a29d14 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Mon, 15 Sep 2025 00:04:23 +0200 Subject: [PATCH 08/18] Add step name --- .github/workflows/tests-code.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests-code.yml b/.github/workflows/tests-code.yml index d4fe928c344..54b670867dd 100644 --- a/.github/workflows/tests-code.yml +++ b/.github/workflows/tests-code.yml @@ -123,7 +123,8 @@ jobs: file-mask: "*.java" settings-file: "config/IntelliJ Code Style.xml" # job should fail in case there are changes - - run: git diff-files --quiet + - name: Check if any files changed + run: git diff-files --quiet modernizer: name: Modernizer From 5826af31591183c7831fefddecf4aa5fe4d8f93b Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Mon, 15 Sep 2025 00:05:20 +0200 Subject: [PATCH 09/18] Output changed files --- .github/workflows/tests-code.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-code.yml b/.github/workflows/tests-code.yml index 54b670867dd..45268d290ff 100644 --- a/.github/workflows/tests-code.yml +++ b/.github/workflows/tests-code.yml @@ -124,7 +124,7 @@ jobs: settings-file: "config/IntelliJ Code Style.xml" # job should fail in case there are changes - name: Check if any files changed - run: git diff-files --quiet + run: git diff-files modernizer: name: Modernizer From fd435807a0992e3a19e18e935d38b6c31d6698af Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Mon, 15 Sep 2025 00:08:54 +0200 Subject: [PATCH 10/18] Output changes --- .github/workflows/tests-code.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-code.yml b/.github/workflows/tests-code.yml index 45268d290ff..6b126371337 100644 --- a/.github/workflows/tests-code.yml +++ b/.github/workflows/tests-code.yml @@ -124,7 +124,7 @@ jobs: settings-file: "config/IntelliJ Code Style.xml" # job should fail in case there are changes - name: Check if any files changed - run: git diff-files + run: git diff --exit-code modernizer: name: Modernizer From d08fc556abd1f41db0a29a2beb21f1c756499ede Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Mon, 15 Sep 2025 00:26:42 +0200 Subject: [PATCH 11/18] Do not align parameters --- config/IntelliJ Code Style.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/config/IntelliJ Code Style.xml b/config/IntelliJ Code Style.xml index 6cee9322160..2e23ea4a5e1 100644 --- a/config/IntelliJ Code Style.xml +++ b/config/IntelliJ Code Style.xml @@ -35,6 +35,7 @@