-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add doi-to-bibtex to examples and JabKit #14244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I tried running it with a valid and an completely invalid doi Unmatched argument at index 2: '1abref'
Usage: jabkit doi-to-bibtex DOI...
Converts a DOI to BibTeX
DOI... one or more DOIs to fetchBut I would say it should not completely "crash" but print out the valid one and for the second the |
subhramit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Micro comments - I am committed to not letting vars enter again - so keeping them only in the example file
|
And maybe also a option which disables the error messages but still returns exit code 1, so if you want to work with the output and ignore errors for example. Can't name a case for that, but i can imagine that it could be helpful. But one could probably just read the out and ignore err output and achieve it without the extra option |
We should create an architecture test for that ^^ |
Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
…into add-doi-to-bibtex-example
|
It's far from perfect... Even with Needs to be more thought how we deal with I tried with Result: |
This is what
This is the intention of this PR ^^ |
|
OK, |
|
ah some ci checks |
Refs #14259 maybe |
|
Somehow jackson was updated in main - and jabsrv does not compile any more. |
|
Commit breaking main 32ce0b9 |
* main: Fix calling JBang command (#14282) .jbang scripts should not be included inside themselves (#14278) Fix typos (#14277) Refactor importDatabase for better readability (#14274) fix jbang (#14276) Feat: Add definition links for TeX Files (#14260) Update preventing module commits (#14273) Fix JabKitLuancher Rename packages in jabkit to start with org.jabref.toolkit to avoid split packages between jabkit and jabgui (#14052). (#14271) Add doi-to-bibtex to examples and JabKit (#14244)
* Simplyfy code * Fix step ignore * Add doi_to_bibtex.java * Add doi-to-bibtex to JabKit * Add CHANGELOG.md entry * Add some debug code (again) * Fix formatting * Fix logger * Also deal with jabkit * Remove debug * Fix casing * Fix condition * Continue on wrong DOI * Apply suggestions from code review Co-authored-by: Subhramit Basu <subhramit.bb@live.in> * Fix checkstyle * Fix space * Disable JUL output at JabKit * --porcelain does not output any logs to the console any more * Fix logger config * Have --porcelain working * Improve strings * Update CHANGELOG.md * Update jabkit/src/main/java/org/jabref/cli/DoiToBibtex.java * Workaround for tests * Compilefix --------- Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
Strongly demanded by the community. Was available inside JabRef; now we can offer as CLI.
Kind of follow-up to #14233.
We use CrossRef
Steps to test
Create and modify debug configuration for
org.jabref.JabKit#mainMandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)