Skip to content

Conversation

@HamzehAdawi
Copy link

@HamzehAdawi HamzehAdawi commented Nov 25, 2025

Closes #14401

This PR fixes the "Enable resetting of EntryEditorPreferences" issue.

Steps to test

Mandatory checks

@github-actions
Copy link
Contributor

Hey @HamzehAdawi!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️

We have automated checks in place, based on which you will soon get feedback if any of them are failing. In a while, maintainers will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

koppor
koppor previously requested changes Nov 25, 2025
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which part of the following image didn't you understand?

grafik

@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Nov 25, 2025
@calixtus
Copy link
Member

Try to use less AI and check your commits before pushing them. There are really sloppy mistakes that could be easily avoided by reading the code instead of just running an agent. Open source is not about writing the most code, but understand it and maybe also learn a little bit.

Please fix the mistakes.

@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 25, 2025
@HamzehAdawi
Copy link
Author

Removed the redundant methods and fixed EntryEditorPreferences, as requested. Please let me know if any additional changes are needed, sorry for the oversight.

Comment on lines +455 to +456
getEntryEditorTabs(),
getDefaultEntryEditorTabs(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know that this is the fun part?
They need to be adapted too, i think.

@HamzehAdawi
Copy link
Author

Moved EntryEditorPref constants from JabRefCli to JabRefGui.

@calixtus regarding the EntryEditorTabs, I am not entirely sure if this is what you had in mind, so please let me know if anything should be adjusted there.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 28, 2025
@Siedlerchr Siedlerchr changed the title Fix for issue 14401 Fix resetting of entry editor prefs Nov 29, 2025
@github-actions github-actions bot removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 30, 2025
@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Nov 30, 2025
@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 3, 2025
@koppor koppor requested a review from calixtus December 4, 2025 13:41
@koppor koppor dismissed their stale review December 4, 2025 13:41

Looks good at first sight.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first contrib status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable resetting of EntryEditorPreferences

3 participants