From 7920b92623466a9850e337b1625d07a6ff774413 Mon Sep 17 00:00:00 2001 From: johannes-manner Date: Tue, 6 Feb 2018 16:29:58 +0100 Subject: [PATCH] Fix koppor issues #3 Fixed the issue "DOI: encoded URLs should be supported". New divider within the DOI % is supported. --- src/main/java/org/jabref/model/entry/identifier/DOI.java | 2 +- src/test/java/org/jabref/model/entry/identifier/DOITest.java | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/jabref/model/entry/identifier/DOI.java b/src/main/java/org/jabref/model/entry/identifier/DOI.java index 754eaed239c..38c66733758 100644 --- a/src/main/java/org/jabref/model/entry/identifier/DOI.java +++ b/src/main/java/org/jabref/model/entry/identifier/DOI.java @@ -30,7 +30,7 @@ public class DOI implements Identifier { + "(" // begin group \1 + "10" // directory indicator + "(?:\\.[0-9]+)+" // registrant codes - + "[/:]" // divider + + "[/:%]" // divider + "(?:.+)" // suffix alphanumeric string + ")"; // end group \1 private static final String FIND_DOI_EXP = "" diff --git a/src/test/java/org/jabref/model/entry/identifier/DOITest.java b/src/test/java/org/jabref/model/entry/identifier/DOITest.java index 86d79a82e96..d6db25c4278 100644 --- a/src/test/java/org/jabref/model/entry/identifier/DOITest.java +++ b/src/test/java/org/jabref/model/entry/identifier/DOITest.java @@ -64,6 +64,8 @@ public void acceptURLDoi() { Assert.assertEquals("10.1006/jmbi.1998.2354", new DOI("http://doi.org/10.1006/jmbi.1998.2354").getDOI()); // https Assert.assertEquals("10.1006/jmbi.1998.2354", new DOI("https://doi.org/10.1006/jmbi.1998.2354").getDOI()); + // https with % divider + Assert.assertEquals("10.2307/1990888", new DOI("https://dx.doi.org/10.2307%2F1990888").getDOI()); // other domains Assert.assertEquals("10.1145/1294928.1294933", new DOI("http://doi.acm.org/10.1145/1294928.1294933").getDOI()); Assert.assertEquals("10.1145/1294928.1294933", new DOI("http://doi.acm.net/10.1145/1294928.1294933").getDOI());