Refactor dublin core utility #3756
Conversation
The tool is now implemented as a console application with a read-evaluate-print cycle.
| * | ||
| * @param args | ||
| */ | ||
| public static void main(String[] args) { |
There was a problem hiding this comment.
Like the idea, but why not integrate it with the rest of our cli infrastruture?
Maybe as part of an "Importer" or Exporter?
http://help.jabref.org/en/CommandLine#import-file--i-filenameimport-format
| /** | ||
| * The tool is implemented as a console application with a read-evaluate-print cycle. | ||
| * | ||
| * @param args |
There was a problem hiding this comment.
Remove empty parameter description 😇
lenhard
added
the
status: ready-for-review
Integrated the xmp functionality in the CLI infrastructure
|
I integrated the xmp functionality in the CLI infrastructure :) After exiting my tool with '0' the graphical user interface starts... |
|
When I am right, you just need to call Platform.exit() (at least when it's the javafx application thread start ) |
|
Platform.exit() does not work. Therefore I used the other option System.exit(0). The implementation is now ready for review. |
System.exit() because Platform.exit() does not work in this case.
|
@johannes-manner Okay, good to hear! Help files are all in their own Repo. Either you click on that Octocat Github thing in the right corner, or you go to that repo: |
| } | ||
| } | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
Do we actually need this tool as a separate executable now that the functionality is included in the usual CLI?
There was a problem hiding this comment.
It's a convenient tool to add metadata to pdf files. If there is the possiblity to build a standalone jar with the multi-model build, why not use the chance to offer this tool to more users and make this tool more popular?
koppor
removed
the
status: ready-for-review
* upstream/master: (94 commits) Add missing localization for Any file Refactor dublin core utility (#3756) Add Localization Update Architecture Tests to catch static imports (#3766) Added <any file type> to the Import File Filter Dialog. Don't trim when migrating review field (#3761) Reorder again Rename confirmation into "Merge fields" Fix logic Reorder checklist in PR template and add "good commit message" Replace x11 by unity7 Include desktop, desktop-legacy, wayland in snapcraft.yaml Improve Dublin Core (#3710) Incorporate suggestions by @Siedlerchr Update JUnit from 5.1.0-M2 -> 5.1.0 Update Mockito from 2.13.0 -> 2.15.0 Update wiremock from 2.14.0 -> 2.15.0 Fix exceptions for jacoco update gradle Add link to contribute.jabref.org (#3748) ... # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java
The tool is now implemented as a console application with a read-evaluate-print cycle.
It can be used with and without a jar file and can be used independently of #3704.