Improve search performance #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
|
Does this swallow event before the delay or does it just execute the search at a later time one by one? |
tobiasdiez
approved these changes
Apr 13, 2018
|
@stefan-kolb The timer is resetted when you type new chars |
stefan-kolb
approved these changes
Apr 13, 2018
| @@ -186,7 +191,13 @@ public void actionPerformed(ActionEvent e) { | |||
| updateSearchModeButtonText(); | |||
| searchModeButton.addActionListener(event -> toggleSearchModeAndSearch()); | |||
|
|
|||
| EasyBind.subscribe(searchField.textProperty(), searchText -> performSearch()); | |||
| //Add a delay of 400 milliseconds before starting search | |||
| Timer searchTask = FxTimer.create(Duration.ofMillis(400), () -> { | |||
There was a problem hiding this comment.
Maybe extract the search delay as a constant
|
|
||
| @SuppressWarnings("Duplicates") | ||
| public class GlobalSearchBar extends JPanel { | ||
|
|
||
| private static final PseudoClass CLASS_NO_RESULTS = PseudoClass.getPseudoClass("emptyResult"); | ||
| private static final PseudoClass CLASS_RESULTS_FOUND = PseudoClass.getPseudoClass("emptyResult"); | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(GlobalSearchBar.class); |
There was a problem hiding this comment.
Logger should be first attribute in the class
extract constant
Siedlerchr
added a commit
that referenced
this pull request
Apr 13, 2018
* upstream/master: Pdf exporter - delete xmp actions in the menu bar and the cli option (#3947) Improve search performance (#3950) New Crowdin translations (#3949) Update dependencies for junit, mockito and checkstyle (#3951) Add XMP Exporter (#3895) Switch colors of search icon for the two search modes (#3871) # Conflicts: # src/main/java/org/jabref/gui/search/GlobalSearchBar.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before executing the search there is now a short delay.
I tested this with the Huge file bib and the performance is way better.
Still the entry editor has a high load, but that's out of scope.
Thx to @halirutan who pointed me to the code in #3553