Solution for submitting dialog with Ctrl + Enter (#4496) #4592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created solution for suggested improvement described in #4496
Adjusted BaseDialog class to watch for new KeyBinding combination (default: ctrl + ENTER). When such combination is pressed in any dialog which extends BaseDialog, then system tries to find button with default action. If such button is found, then its event is fired.
Additional tests were not created as there currently is no BaseDialogTest test suite and existing dialog tests should cover the changes. In my opinion, quite major refactoring should be made to easily create unit tests for BaseDialog class.