From 13cbd07c76a94f502b6cf90ea5b011b5cb135ee4 Mon Sep 17 00:00:00 2001 From: kaiquekk Date: Mon, 18 Mar 2019 14:26:36 -0300 Subject: [PATCH 1/2] Add names for rank entry events Signed-off-by: kaiquekk --- .../java/org/jabref/gui/actions/StandardActions.java | 10 +++++----- src/main/resources/l10n/JabRef_en.properties | 5 +++++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/jabref/gui/actions/StandardActions.java b/src/main/java/org/jabref/gui/actions/StandardActions.java index 6e7493f32d7..e6c95b9e916 100644 --- a/src/main/java/org/jabref/gui/actions/StandardActions.java +++ b/src/main/java/org/jabref/gui/actions/StandardActions.java @@ -44,11 +44,11 @@ public enum StandardActions implements Action { QUALITY_ASSURED(Localization.lang("Toggle quality assured"), IconTheme.JabRefIcons.QUALITY_ASSURED), RANKING(Localization.lang("Rank"), IconTheme.JabRefIcons.RANKING), CLEAR_RANK(Localization.lang("Clear rank")), - RANK_1("", IconTheme.JabRefIcons.RANK1), - RANK_2("", IconTheme.JabRefIcons.RANK2), - RANK_3("", IconTheme.JabRefIcons.RANK3), - RANK_4("", IconTheme.JabRefIcons.RANK4), - RANK_5("", IconTheme.JabRefIcons.RANK5), + RANK_1(Localization.lang("Set rank to one"), IconTheme.JabRefIcons.RANK1), + RANK_2(Localization.lang("Set rank to two"), IconTheme.JabRefIcons.RANK2), + RANK_3(Localization.lang("Set rank to three"), IconTheme.JabRefIcons.RANK3), + RANK_4(Localization.lang("Set rank to four"), IconTheme.JabRefIcons.RANK4), + RANK_5(Localization.lang("Set rank to five"), IconTheme.JabRefIcons.RANK5), PRINTED(Localization.lang("Printed"), IconTheme.JabRefIcons.PRINTED), TOGGLE_PRINTED(Localization.lang("Toggle print status"), IconTheme.JabRefIcons.PRINTED), READ_STATUS(Localization.lang("Read status"), IconTheme.JabRefIcons.READ_STATUS), diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties index 6f889dd0133..77ebe5e08b3 100644 --- a/src/main/resources/l10n/JabRef_en.properties +++ b/src/main/resources/l10n/JabRef_en.properties @@ -2129,3 +2129,8 @@ Use\ selected\ document=Use selected document Accept\ changes=Accept changes Dismiss\ changes=Dismiss changes The\ library\ has\ been\ modified\ by\ another\ program.=The library has been modified by another program. +Set\ rank\ to\ one=Set rank to one +Set\ rank\ to\ two=Set rank to two +Set\ rank\ to\ three=Set rank to three +Set\ rank\ to\ four=Set rank to four +Set\ rank\ to\ five=Set rank to five From fbfd5778e8711ea15e01b094a3ffda84a2321c08 Mon Sep 17 00:00:00 2001 From: kaiquekk Date: Mon, 18 Mar 2019 14:42:14 -0300 Subject: [PATCH 2/2] Add changes to CHANGELOG Signed-off-by: kaiquekk --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9e14888432a..41e6cbf78ae 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -99,6 +99,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# - We fixed an issue where only one PDF file could be imported [#4422](https://github.com/JabRef/jabref/issues/4422) - We fixed an issue where "Move to group" would always move the first entry in the library and not the selected [#4414](https://github.com/JabRef/jabref/issues/4414) - We fixed an issue where an older dialog appears when downloading full texts from the quality menu. [#4489](https://github.com/JabRef/jabref/issues/4489) +- We fixed an issue where ranking an entry would generate an IllegalArgumentException. [#4754](https://github.com/JabRef/jabref/issues/4754)