From 7f8da92e1ab1f9bca0fd57e1d884ea4cbb6f5ad7 Mon Sep 17 00:00:00 2001 From: Carl Christian Snethlage Date: Sat, 14 Sep 2019 02:28:44 +0200 Subject: [PATCH 01/12] Initial, Fix double list, setValues to Background, Templates and ExportSort --- src/main/java/module-info.java | 3 + .../jabref/gui/SaveOrderConfigDisplay.fxml | 72 ++++--- .../gui/SaveOrderConfigDisplayView.java | 4 +- .../java/org/jabref/gui/icon/IconTheme.java | 4 + .../AbstractPreferenceTabView.java | 4 +- .../jabref/gui/preferences/AdvancedTab.fxml | 92 ++++----- .../gui/preferences/AdvancedTabView.java | 37 ++-- .../gui/preferences/AdvancedTabViewModel.java | 2 - .../gui/preferences/EntryEditorTabView.java | 23 +++ .../preferences/EntryEditorTabViewModel.java | 38 ++++ .../gui/preferences/ExportSortingTabView.java | 51 +++++ .../jabref/gui/preferences/ExternalTab.fxml | 188 +++++++++--------- .../gui/preferences/ExternalTabView.java | 35 ++-- .../gui/preferences/ExternalTabViewModel.java | 2 - .../org/jabref/gui/preferences/FileTab.fxml | 105 +++++----- .../jabref/gui/preferences/FileTabView.java | 47 +++-- .../gui/preferences/FileTabViewModel.java | 1 - .../jabref/gui/preferences/GeneralTab.fxml | 126 ++++++------ .../gui/preferences/GeneralTabView.java | 49 +++-- .../gui/preferences/GeneralTabViewModel.java | 1 - .../org/jabref/gui/preferences/GroupsTab.fxml | 50 ++--- .../jabref/gui/preferences/GroupsTabView.java | 19 +- .../gui/preferences/GroupsTabViewModel.java | 1 - .../jabref/gui/preferences/ImportTabView.java | 23 +++ .../gui/preferences/ImportTabViewModel.java | 55 +++++ .../gui/preferences/NameFormatterTabView.java | 15 +- .../NameFormatterTabViewModel.java | 1 - .../gui/preferences/PreferencesDialog.fxml | 66 +++--- .../preferences/PreferencesDialogView.java | 15 +- .../PreferencesDialogViewModel.java | 65 +++--- .../jabref/gui/preferences/PreviewTab.fxml | 121 ++++++----- .../gui/preferences/PreviewTabView.java | 84 ++++---- .../gui/preferences/PreviewTabViewModel.java | 2 - .../preferences/ShowPreferencesAction.java | 2 +- .../gui/preferences/TableColumnsTab.fxml | 2 +- .../gui/preferences/TableColumnsTabView.java | 42 ++-- .../preferences/TableColumnsTabViewModel.java | 16 +- .../jabref/gui/preferences/TableTabView.java | 23 +++ .../gui/preferences/TableTabViewModel.java | 38 ++++ .../gui/preferences/XmpPrivacyTabView.java | 30 ++- .../preferences/XmpPrivacyTabViewModel.java | 2 - 41 files changed, 895 insertions(+), 661 deletions(-) create mode 100644 src/main/java/org/jabref/gui/preferences/EntryEditorTabView.java create mode 100644 src/main/java/org/jabref/gui/preferences/EntryEditorTabViewModel.java create mode 100644 src/main/java/org/jabref/gui/preferences/ExportSortingTabView.java create mode 100644 src/main/java/org/jabref/gui/preferences/ImportTabView.java create mode 100644 src/main/java/org/jabref/gui/preferences/ImportTabViewModel.java create mode 100644 src/main/java/org/jabref/gui/preferences/TableTabView.java create mode 100644 src/main/java/org/jabref/gui/preferences/TableTabViewModel.java diff --git a/src/main/java/module-info.java b/src/main/java/module-info.java index 315e4bec469..22ff52c1682 100644 --- a/src/main/java/module-info.java +++ b/src/main/java/module-info.java @@ -72,4 +72,7 @@ requires antlr.runtime; requires commons.lang3; requires xmpbox; + requires de.saxsys.mvvmfx.validation; + requires richtextfx; + requires unirest.java; } diff --git a/src/main/java/org/jabref/gui/SaveOrderConfigDisplay.fxml b/src/main/java/org/jabref/gui/SaveOrderConfigDisplay.fxml index 14c2655be95..96f8c8d0cf9 100644 --- a/src/main/java/org/jabref/gui/SaveOrderConfigDisplay.fxml +++ b/src/main/java/org/jabref/gui/SaveOrderConfigDisplay.fxml @@ -8,35 +8,49 @@ - - - - - - - - - - - - - - + + + - + - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/main/java/org/jabref/gui/SaveOrderConfigDisplayView.java b/src/main/java/org/jabref/gui/SaveOrderConfigDisplayView.java index 2c4ef4c5f6f..ba8b30a0902 100644 --- a/src/main/java/org/jabref/gui/SaveOrderConfigDisplayView.java +++ b/src/main/java/org/jabref/gui/SaveOrderConfigDisplayView.java @@ -7,7 +7,7 @@ import javafx.scene.control.ComboBox; import javafx.scene.control.RadioButton; import javafx.scene.control.ToggleGroup; -import javafx.scene.layout.GridPane; +import javafx.scene.layout.VBox; import org.jabref.logic.l10n.Localization; import org.jabref.model.entry.field.Field; @@ -16,7 +16,7 @@ import com.airhacks.afterburner.views.ViewLoader; -public class SaveOrderConfigDisplayView extends GridPane { +public class SaveOrderConfigDisplayView extends VBox { private final SaveOrderConfig config; diff --git a/src/main/java/org/jabref/gui/icon/IconTheme.java b/src/main/java/org/jabref/gui/icon/IconTheme.java index 98b9a2074e8..4e16f123c36 100644 --- a/src/main/java/org/jabref/gui/icon/IconTheme.java +++ b/src/main/java/org/jabref/gui/icon/IconTheme.java @@ -271,6 +271,10 @@ public enum JabRefIcons implements JabRefIcon { PREVIOUS_UP(MaterialDesignIcon.CHEVRON_UP), NEXT_RIGHT(MaterialDesignIcon.CHEVRON_RIGHT), NEXT_DOWN(MaterialDesignIcon.CHEVRON_DOWN), + MOVE_LEFT(MaterialDesignIcon.CHEVRON_LEFT), + MOVE_UP(MaterialDesignIcon.CHEVRON_UP), + MOVE_RIGHT(MaterialDesignIcon.CHEVRON_RIGHT), + MOVE_DOWN(MaterialDesignIcon.CHEVRON_DOWN), FIT_WIDTH(MaterialDesignIcon.ARROW_EXPAND_ALL), FIT_SINGLE_PAGE(MaterialDesignIcon.NOTE), ZOOM_OUT(MaterialDesignIcon.MAGNIFY_MINUS), diff --git a/src/main/java/org/jabref/gui/preferences/AbstractPreferenceTabView.java b/src/main/java/org/jabref/gui/preferences/AbstractPreferenceTabView.java index b957082890b..cf8b4e69c4c 100644 --- a/src/main/java/org/jabref/gui/preferences/AbstractPreferenceTabView.java +++ b/src/main/java/org/jabref/gui/preferences/AbstractPreferenceTabView.java @@ -11,12 +11,12 @@ import org.jabref.gui.util.TaskExecutor; import org.jabref.preferences.JabRefPreferences; -public abstract class AbstractPreferenceTabView extends VBox implements PreferencesTab { +public abstract class AbstractPreferenceTabView extends VBox implements PreferencesTab { @Inject protected TaskExecutor taskExecutor; @Inject protected DialogService dialogService; - protected PreferenceTabViewModel viewModel; + protected T viewModel; protected JabRefPreferences preferences; diff --git a/src/main/java/org/jabref/gui/preferences/AdvancedTab.fxml b/src/main/java/org/jabref/gui/preferences/AdvancedTab.fxml index 7c9886d84fb..a98ac76d508 100644 --- a/src/main/java/org/jabref/gui/preferences/AdvancedTab.fxml +++ b/src/main/java/org/jabref/gui/preferences/AdvancedTab.fxml @@ -13,53 +13,53 @@ - -