Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix linux pdf opening again #5945

Merged
merged 6 commits into from
Feb 20, 2020
Merged

Try to fix linux pdf opening again #5945

merged 6 commits into from
Feb 20, 2020

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Feb 13, 2020

Fixes #5942 and fixes probably #5882

@Siedlerchr
Copy link
Member Author

Could you please try again with the newest version from this branch?
I forgot one method.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides BufferedReader closing "OK". Maybe, go ahead with that and then switch to ProcessBuilder in a follow-up PR? 😇

src/main/java/org/jabref/gui/util/StreamGobbler.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/gui/util/StreamGobbler.java Outdated Show resolved Hide resolved
* upstream/master:
  followup fix
  Fixfetcher (#5948)
  Bump byte-buddy-parent from 1.10.7 to 1.10.8 (#5952)
  Added MenuButtons to IntegrityCheckDialog (#5955)
  Reimplement custom entry types dialog (#5799)
  Bump unirest-java from 3.4.03 to 3.5.00 (#5953)
  MySQL: Allow public key retrieval (#5909)
  Restructure and improve docs for setting up IntelliJ (#5960)
  Change syntax for Oracle multi-row insert SQL statement (#5837)
  Bump classgraph from 4.8.62 to 4.8.64 (#5954)
  Squashed 'src/main/resources/csl-styles/' changes from c531528..9e81857
  Fix not escaping special characters in search pattern (#5938)
@Siedlerchr Siedlerchr merged commit 5369b3b into master Feb 20, 2020
@Siedlerchr Siedlerchr deleted the linuxOutputstream branch February 20, 2020 07:32
Siedlerchr added a commit that referenced this pull request Mar 6, 2020
* upstream/master:
  Try to fix linux pdf opening again (#5945)
  [WIP] Initial work on DBMSProcessor batch entry insertion into ENTRY table (#5814)
  followup fix
  Fixfetcher (#5948)
  Bump byte-buddy-parent from 1.10.7 to 1.10.8 (#5952)
  Added MenuButtons to IntegrityCheckDialog (#5955)
  Reimplement custom entry types dialog (#5799)
  Bump unirest-java from 3.4.03 to 3.5.00 (#5953)
  MySQL: Allow public key retrieval (#5909)
  Restructure and improve docs for setting up IntelliJ (#5960)
  Change syntax for Oracle multi-row insert SQL statement (#5837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a PDF blocks JabRef (under Ubuntu/Linux)
3 participants