Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat with Float32; reduction of preallocated; remove jld2 + ncdatasets deps #125

Merged
merged 10 commits into from
Jul 31, 2024

Conversation

JanJereczek
Copy link
Owner

I repeatedly bump into memory issues when running high resolution (nx = ny > 600). This is partly addressed here by reducing the number of arrays defined in PreAllocated and by deleting the 3D arrays from LayeredEarth.

@JanJereczek JanJereczek changed the title Reduce preallocated arrays Reduce preallocated arrays and remove jld2 + ncdatasets deps Jul 31, 2024
@JanJereczek
Copy link
Owner Author

Additionally, I removed the deps to JLD2 and to NCDatasets. The former is motivated by the fact that isostasy_data should not be julia-specific. The latter is motivated by the fact that we already need NetCDF.jl and hence we can easily remove NCDatasets.jl, which has the additional perc of being more legible.

@JanJereczek JanJereczek changed the title Reduce preallocated arrays and remove jld2 + ncdatasets deps Compat with Float32; reduction of preallocated; remove jld2 + ncdatasets deps Jul 31, 2024
@JanJereczek
Copy link
Owner Author

The code now includes a test with everything being Float32. This works and will avoid future issues about memory. In particular, this allows to run high resolution simulations on GPU!

@JanJereczek
Copy link
Owner Author

This addresses #119, #103, #120!

@JanJereczek JanJereczek merged commit 1afe693 into main Jul 31, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant