Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: use Symbol.for('level') when extracting label #144

Merged

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Mar 29, 2024

PR Feedback: 👍

Description

This pull request updates the LokiTransport class within index.js to use Symbol.for('level') for extracting the log level, enhancing the way log levels are handled.

Summary

  • Removed level from the destructuring assignment of info and instead, explicitly extracted it using Symbol.for('level').
  • This change ensures that the log level is accurately captured, especially in scenarios where the log level is symbolically represented.
  • Affected file: index.js in the LokiTransport class.

Fixes #112.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

This is an automated message generated by Sweep AI.

Copy link
Contributor Author

sweep-ai bot commented Mar 29, 2024

Rollback Files For Sweep

  • Rollback changes to index.js

This is an automated message generated by Sweep AI.

@sweep-ai sweep-ai bot added the Sweep label Mar 29, 2024
Copy link
Owner

@JaniAnttonen JaniAnttonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, together with the other Sweep PR this requires a new minor release instead of a patch since the API gets changed somewhat.

@JaniAnttonen JaniAnttonen merged commit 52c1c18 into development Apr 8, 2024
@JaniAnttonen JaniAnttonen deleted the sweep/use_symbolforlevel_when_extracting_label branch April 8, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use Symbol.for('level') when extracting label
1 participant