From 861a0657233f271ffa41c908ce68a2206ed970fd Mon Sep 17 00:00:00 2001 From: Isman Firmansyah Date: Wed, 2 Nov 2022 19:09:12 +0700 Subject: [PATCH] fix(pycloudlib): searching values from spanner returns empty set (#2833) * fix(pycloudlib): searching values from spanner returns empty set * chore(jans-pycloudlib): updated build (#2834) Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> Co-authored-by: mo-auto <54212639+mo-auto@users.noreply.github.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> --- docker-jans-auth-server/requirements.txt | 2 +- docker-jans-certmanager/requirements.txt | 2 +- docker-jans-config-api/requirements.txt | 2 +- docker-jans-configurator/requirements.txt | 2 +- docker-jans-fido2/requirements.txt | 2 +- docker-jans-persistence-loader/requirements.txt | 2 +- docker-jans-scim/requirements.txt | 2 +- jans-pycloudlib/jans/pycloudlib/persistence/spanner.py | 2 -- 8 files changed, 7 insertions(+), 9 deletions(-) diff --git a/docker-jans-auth-server/requirements.txt b/docker-jans-auth-server/requirements.txt index d0f552ef4e7..c8e1f488ada 100644 --- a/docker-jans-auth-server/requirements.txt +++ b/docker-jans-auth-server/requirements.txt @@ -1,4 +1,4 @@ # pinned to py3-grpcio version to avoid failure on native extension build grpcio==1.41.0 libcst<0.4 -git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib +git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib diff --git a/docker-jans-certmanager/requirements.txt b/docker-jans-certmanager/requirements.txt index 8e8169d5a3e..5586300f301 100644 --- a/docker-jans-certmanager/requirements.txt +++ b/docker-jans-certmanager/requirements.txt @@ -2,4 +2,4 @@ grpcio==1.41.0 click==6.7 libcst<0.4 -git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib +git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib diff --git a/docker-jans-config-api/requirements.txt b/docker-jans-config-api/requirements.txt index f1a3f3fee5a..d006e2edc91 100644 --- a/docker-jans-config-api/requirements.txt +++ b/docker-jans-config-api/requirements.txt @@ -2,4 +2,4 @@ grpcio==1.41.0 libcst<0.4 ruamel.yaml==0.16.10 -git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib +git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib diff --git a/docker-jans-configurator/requirements.txt b/docker-jans-configurator/requirements.txt index 53e10764a46..5b9a5b2c832 100644 --- a/docker-jans-configurator/requirements.txt +++ b/docker-jans-configurator/requirements.txt @@ -4,4 +4,4 @@ click==6.7 marshmallow==3.10.0 fqdn==1.4.0 libcst<0.4 -git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib +git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib diff --git a/docker-jans-fido2/requirements.txt b/docker-jans-fido2/requirements.txt index d0f552ef4e7..c8e1f488ada 100644 --- a/docker-jans-fido2/requirements.txt +++ b/docker-jans-fido2/requirements.txt @@ -1,4 +1,4 @@ # pinned to py3-grpcio version to avoid failure on native extension build grpcio==1.41.0 libcst<0.4 -git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib +git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib diff --git a/docker-jans-persistence-loader/requirements.txt b/docker-jans-persistence-loader/requirements.txt index f1a3f3fee5a..d006e2edc91 100644 --- a/docker-jans-persistence-loader/requirements.txt +++ b/docker-jans-persistence-loader/requirements.txt @@ -2,4 +2,4 @@ grpcio==1.41.0 libcst<0.4 ruamel.yaml==0.16.10 -git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib +git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib diff --git a/docker-jans-scim/requirements.txt b/docker-jans-scim/requirements.txt index f1a3f3fee5a..d006e2edc91 100644 --- a/docker-jans-scim/requirements.txt +++ b/docker-jans-scim/requirements.txt @@ -2,4 +2,4 @@ grpcio==1.41.0 libcst<0.4 ruamel.yaml==0.16.10 -git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib +git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib diff --git a/jans-pycloudlib/jans/pycloudlib/persistence/spanner.py b/jans-pycloudlib/jans/pycloudlib/persistence/spanner.py index 7d1d1c5d5be..3ae5b6a1972 100644 --- a/jans-pycloudlib/jans/pycloudlib/persistence/spanner.py +++ b/jans-pycloudlib/jans/pycloudlib/persistence/spanner.py @@ -249,8 +249,6 @@ def search(self, table_name: str, column_names: _t.Union[list[str], None] = None if not column_names: # TODO: faster lookup on column names col_names = list(self.get_table_mapping().get(table_name, {}).keys()) - else: - col_names = [] with self.database.snapshot() as snapshot: # type: ignore result = snapshot.read(