Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jans auth server client registration language metadata fix tests #2864

Closed
wants to merge 2 commits into from
Closed

Jans auth server client registration language metadata fix tests #2864

wants to merge 2 commits into from

Conversation

qbert2k
Copy link
Contributor

@qbert2k qbert2k commented Nov 4, 2022

Prepare

Description

Target issue

closes #issue-number-here

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR comp-jans-orm Component affected by issue or PR labels Nov 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

[notify] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yuriyz
Copy link
Contributor

yuriyz commented Nov 4, 2022

@qbert2k When I look to @yurem comment's it sounds as third option is chosen, is it correct?
I mean comments to this ticket #1482

I will let @yurem review it.

@yurem yurem enabled auto-merge (squash) November 7, 2022 16:59
yuriyz
yuriyz requested changes Nov 7, 2022
View reviewed changes
jans-auth-server/server/src/main/java/io/jans/as/server/register/ws/rs/RegisterService.java
@@ -149,19 +149,19 @@ public void updateClientFromRequestObject(Client client, RegisterRequest request
}

for (String key : requestObject.getClientNameLanguageTags()) {
client.setClientName(requestObject.getClientName(key), Locale.forLanguageTag(key));
client.setClientNameLocalized(requestObject.getClientName(key), Locale.forLanguageTag(key));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if there is no language tag set we end up client name skipped even if it's set in request object.
I mean we need plain setters for non-localized versions, like

client.setClientName(requestObject.getClientName());

Isn't it? Otherwise how non-localized version io.jans.as.common.model.registration.Client#clientName is used?

@qbert2k
Copy link
Contributor Author

qbert2k commented Nov 7, 2022

I am closing this pull request and opening a new one because it is not allowing me to merge changes from the main branch.

@qbert2k qbert2k closed this Nov 7, 2022
auto-merge was automatically disabled November 7, 2022 18:17

Pull request was closed

@moabu moabu deleted the jans-auth-server-client-registration-language-metadata-fix-tests branch June 27, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz requested changes

@yurem yurem yurem approved these changes

@devrimyatar devrimyatar Awaiting requested review from devrimyatar devrimyatar is a code owner

@smansoft smansoft Awaiting requested review from smansoft

Assignees
No one assigned
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR comp-jans-orm Component affected by issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qbert2k @yuriyz @yurem @mo-auto