From b8c5c8afce4c35b2f8f2b121464090170f742a27 Mon Sep 17 00:00:00 2001 From: David Hyldgaard Date: Sun, 13 Aug 2023 19:07:19 +0200 Subject: [PATCH] typo in tests and document snippet link removed --- docs/events/projections/healthchecks.md | 4 ---- .../AsyncDaemonHealthCheckExtensionsTests.cs | 4 ++-- src/Marten/Events/Daemon/AsyncDaemonHealthCheckExtensions.cs | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/docs/events/projections/healthchecks.md b/docs/events/projections/healthchecks.md index 3a0fc89bdfc..8ef17eed91e 100644 --- a/docs/events/projections/healthchecks.md +++ b/docs/events/projections/healthchecks.md @@ -4,8 +4,6 @@ Marten supports a customizable [HealthChecks](https://learn.microsoft.com/en-us/ > The healthcheck will only be checked against `Async` projections - - ```cs // Add HealthCheck Services.AddHealthChecks().AddMartenAsyncDaemonHealthCheck(maxEventLag: 500); @@ -13,5 +11,3 @@ Services.AddHealthChecks().AddMartenAsyncDaemonHealthCheck(maxEventLag: 500); // Map HealthCheck Endpoint app.MapHealthChecks("/health"); ``` -snippet source | anchor - diff --git a/src/Marten.AsyncDaemon.Testing/AsyncDaemonHealthCheckExtensionsTests.cs b/src/Marten.AsyncDaemon.Testing/AsyncDaemonHealthCheckExtensionsTests.cs index 13aa326d8b5..750199579a4 100644 --- a/src/Marten.AsyncDaemon.Testing/AsyncDaemonHealthCheckExtensionsTests.cs +++ b/src/Marten.AsyncDaemon.Testing/AsyncDaemonHealthCheckExtensionsTests.cs @@ -16,7 +16,7 @@ namespace Marten.AsyncDaemon.Testing; -public class AsyncDaemonHealthCheckExtensionsTests : DaemonContext +public class AsyncDaemonHealthCheckExtensionsTests: DaemonContext { private FakeHealthCheckBuilderStub builder = new(); @@ -122,7 +122,7 @@ public async Task should_be_healty_with_all_projections_caught_up() } [Fact] - public async Task should_be_healty_with_one_projections_lagging() + public async Task should_be_unhealty_with_one_projection_lagging() { StoreOptions(x => { diff --git a/src/Marten/Events/Daemon/AsyncDaemonHealthCheckExtensions.cs b/src/Marten/Events/Daemon/AsyncDaemonHealthCheckExtensions.cs index 9cdf8641d52..56042706386 100644 --- a/src/Marten/Events/Daemon/AsyncDaemonHealthCheckExtensions.cs +++ b/src/Marten/Events/Daemon/AsyncDaemonHealthCheckExtensions.cs @@ -42,7 +42,7 @@ internal record AsyncDaemonHealthCheckSettings(int MaxEventLag); /// /// Health check implementation /// - internal class AsyncDaemonHealthCheck : IHealthCheck + internal class AsyncDaemonHealthCheck: IHealthCheck { /// /// The to check health for. @@ -59,7 +59,6 @@ internal AsyncDaemonHealthCheck(IDocumentStore store, AsyncDaemonHealthCheckSett _store = store; _maxEventLag = settings.MaxEventLag; } - #region sample_addmartenasyncdaemonhealthcheck public async Task CheckHealthAsync(HealthCheckContext context, CancellationToken cancellationToken = default) { @@ -92,6 +91,5 @@ public async Task CheckHealthAsync(HealthCheckContext context return HealthCheckResult.Unhealthy($"Unhealthy: {ex.Message}", ex); } } - #endregion } }