Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use annotations 2.X from jakarta ee9 #381

Merged
merged 2 commits into from
Feb 12, 2023
Merged

use annotations 2.X from jakarta ee9 #381

merged 2 commits into from
Feb 12, 2023

Conversation

DRoppelt
Copy link
Contributor

@DRoppelt DRoppelt commented Jan 3, 2023

#379


This change is Reviewable

@DRoppelt DRoppelt changed the title use annotations 2.0.X from jakarta ee9, fixes #379 use annotations 2.X from jakarta ee9 Jan 3, 2023
Copy link
Member

@keilw keilw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jakarta EE 9 version is not 2.1, could we stick to EE 9 for the 1.4.x version of Moneta and upgrade to Jakarta EE 10 in the next one

@DRoppelt
Copy link
Contributor Author

DRoppelt commented Jan 9, 2023

I am not too familiar with the Jakarta lifecycle. I just assumed 2.0.0 and 2.1.0 would be "basically the same thing"

Do I understand right that annotations-api 2.0.0 would be JEE9 and 2.1.0 would be JEE10?
https://jakarta.ee/specifications/annotations/

If so, sure I can switch it from 2.1.0 to 2.0.0

@keilw keilw merged commit d57a83e into JavaMoney:master Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants