Skip to content

Move emotion packages and types for react-transition-group to peerDependencies #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uzikilon wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −3
Open

Move emotion packages and types for react-transition-group to peerDependencies #4972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c886b8
Dependancies update
lukebennett88 Oct 25, 2022
2172f7f
Add changeset
lukebennett88 Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fair-vans-guess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'react-select': patch
---

Move emotion packages and types for react-transition-group to peerDependencies
Copy link
Collaborator

@nderkim nderkim Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still patch if a dependency has been moved to peerDependencies?

Copy link
Collaborator

@lukebennett88 lukebennett88 Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code that ships to the user has been changed, but it doesn't add any new functionality (minor) or change the existing API (major), so I'd consider it a patch (unless I'm missing something?)

Copy link
Collaborator

@nderkim nderkim Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They might not already have emotion explicitly added as a dependency in their application, so wouldn't it be a potentially breaking change?

Copy link
Collaborator

@lukebennett88 lukebennett88 Oct 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a good point.
I think it varies by package manager, so it definitely could be a breaking change for a subset of users. I'll try to find someone who can give us a definitive answer 👍

8 changes: 5 additions & 3 deletions packages/react-select/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,26 @@
"repository": "https://github.com/JedWatson/react-select/tree/master/packages/react-select",
"dependencies": {
"@babel/runtime": "^7.12.0",
"@emotion/cache": "^11.4.0",
"@emotion/react": "^11.8.1",
"@floating-ui/dom": "^1.0.1",
"@types/react-transition-group": "^4.4.0",
"memoize-one": "^6.0.0",
"prop-types": "^15.6.0",
"react-transition-group": "^4.3.0",
"use-isomorphic-layout-effect": "^1.1.2"
},
"devDependencies": {
"@emotion/cache": "^11.4.0",
"@emotion/react": "^11.8.1",
"@types/jest-in-case": "^1.0.6",
"@types/react-transition-group": "^4.4.0",
"enzyme": "^3.8.0",
"enzyme-to-json": "^3.3.0",
"jest-in-case": "^1.0.2",
"react": "^16.13.0",
"react-dom": "^16.13.0"
},
"peerDependencies": {
"@emotion/cache": "^11.4.0",
"@emotion/react": "^11.8.1",
"react": "^16.8.0 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0"
},
Expand Down