Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the pathinfo interface #39

Closed
luisfabib opened this issue Oct 12, 2020 · 0 comments · Fixed by #41
Closed

Simplify the pathinfo interface #39

luisfabib opened this issue Oct 12, 2020 · 0 comments · Fixed by #41
Assignees
Labels
Milestone

Comments

@luisfabib
Copy link
Collaborator

In dipolarkernel the dipolar pathways are specified as a list of amplitude, refocusing time, and harmonic parameters:

pathinfo = [[],[],[]]
pathinfo[0] = [lam0,   nan, nan]    # unmodulated part, gives offset
pathinfo[1] = [lama,   0,   1]      # main modulation, refocusing at time zero
pathinfo[2] = [lam21, tau2, 1]      # 2+1 modulation, refocusing at time tau2

for the unmodulated pathway the refocusing time and harmonic must be specified as nan-values. This is a leftover from the MATLAB interface. Since the Python interface is list-based, the unmodulated pathway could be specified as a list with just the amplitude:

pathinfo = [[],[],[]]
pathinfo[0] = [lam0]             # unmodulated part, gives offset
pathinfo[1] = [lama,   0,   1]   # main modulation, refocusing at time zero
pathinfo[2] = [lam21, tau2, 1]   # 2+1 modulation, refocusing at time tau2
@luisfabib luisfabib added this to the 0.12.0 milestone Oct 12, 2020
@luisfabib luisfabib self-assigned this Oct 12, 2020
@luisfabib luisfabib linked a pull request Oct 20, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant