Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L-curve reg param do not work with a regparam search range #476

Closed
HKaras opened this issue Jul 1, 2024 · 0 comments · Fixed by #477
Closed

L-curve reg param do not work with a regparam search range #476

HKaras opened this issue Jul 1, 2024 · 0 comments · Fixed by #477
Assignees
Labels
bug Something isn't working
Milestone

Comments

@HKaras
Copy link
Member

HKaras commented Jul 1, 2024

The two L-curve based reg param selections do not work with the brent method which is the default. No error message is given and the fit result is returned at the lower bound of the regparamrange. It would be very easy for someone to think this was the optimal value when it is actually not.

Either a warning should be raised or it should default to a grid based search method. Currently, there is no easy way to enable a grid based search from the fit function

@HKaras HKaras added the bug Something isn't working label Jul 1, 2024
@HKaras HKaras added this to the v1.2 milestone Jul 1, 2024
@HKaras HKaras self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant