Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ridme example and changes examples from deadtime to tmin #446

Merged
merged 7 commits into from
Aug 15, 2023
Merged

Add Ridme example and changes examples from deadtime to tmin #446

merged 7 commits into from
Aug 15, 2023

Conversation

HKaras
Copy link
Member

@HKaras HKaras commented Aug 11, 2023

closes #438

@HKaras HKaras self-assigned this Aug 11, 2023
@HKaras HKaras requested a review from stestoll August 11, 2023 10:02
stestoll
stestoll requested changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@stestoll stestoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace all instances of "acquisition deadtime" with "start time".

@HKaras HKaras requested a review from stestoll August 11, 2023 14:45
stestoll
stestoll previously approved these changes Aug 11, 2023
View reviewed changes
stestoll
stestoll previously approved these changes Aug 11, 2023
View reviewed changes
@HKaras
Bug fix with propagate and evaluate functions
81474ef 
The propagate and evaluate functions had a bug that stopped them working on functions.
@stestoll stestoll merged commit 4dcdcc2 into JeschkeLab:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stestoll stestoll stestoll approved these changes

Assignees

@HKaras HKaras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RIDME example
2 participants
@HKaras @stestoll