Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing clicks inside SelectionContainer #1106

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Fix missing clicks inside SelectionContainer #1106

merged 5 commits into from
Feb 15, 2024

Conversation

MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Feb 15, 2024 •
edited
Loading

Proposed Changes

  • Do not recreate modifier nodes on focus change - Buttons inside DisableSelection now clickable. Before it receives only second click
  • Do not consume UP events if there were no drag before - Buttons inside SelectionContainer now clickable, but text inside them is still selectable
  • SelectionManager.hasFocus now true if any of it's children is focusable
  • onClearSelectionRequested now triggers on consumed click on focusable, non-selectable child

Testing

Test: Selection page in mpp

Issues Fixed

Fixes JetBrains/compose-multiplatform#1450

@MatkovIvan MatkovIvan merged commit 6b4ea61 into jb-main Feb 15, 2024
6 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-clicks-in-selection branch February 15, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazunin-v-jb mazunin-v-jb mazunin-v-jb approved these changes

@igordmn igordmn igordmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SelectionContainer not work with any clickable component
3 participants
@MatkovIvan @igordmn @mazunin-v-jb