Configure the "material3-window-size-class" module as CMP and include it to the publication

[terrakok]

Configure the material3-window-size-class module as CMP and include it to the publication.
Added new method to non-android source set to calculate WindowSizeClass.

Fixes https://youtrack.jetbrains.com/issue/CMP-2404

Testing

Checked it in the MPP demo app:

Release Notes

Features - Multiple Platforms

• Commonized material3-window-size-class module

[MatkovIvan]

Please move WindowSizeClassTest to commonTest it should work almost as-is.

Also please generate API dump (reason of red CI)

[MatkovIvan]

Suggested change

	skikoMain.dependsOn(commonMain)
	desktopMain.dependsOn(skikoMain)
	nonJvmMain.dependsOn(skikoMain)
	webMain.dependsOn(nonJvmMain)
	jsMain.dependsOn(webMain)
	wasmJsMain.dependsOn(webMain)
	nativeMain.dependsOn(nonJvmMain)
	skikoTest.dependsOn(commonTest)
	desktopTest.dependsOn(skikoTest)
	nonJvmTest.dependsOn(skikoTest)
	webTest.dependsOn(nonJvmTest)
	jsTest.dependsOn(webTest)
	wasmJsTest.dependsOn(webTest)
	nativeTest.dependsOn(nonJvmTest)
	skikoMain.dependsOn(commonMain)
	targets.configureEach { target ->
	if (target.platformType !in [KotlinPlatformType.androidJvm, KotlinPlatformType.common]) {
	target.compilations["main"].defaultSourceSet {
	dependsOn(skikoMain)
	}
	target.compilations["test"].defaultSourceSet {
	dependsOn(commonTest)
	}
	}
	}

[terrakok]

I don't see a profit of this code. it is harder to understand and spends same number of lines of code

[MatkovIvan]

Because you need to manually add dependencies to nativeMain to all specific architectures/OSes

[terrakok]

I wouldn't say I agree with the proposed changes.
To have a flexible and common logic for all modules we need to extract it to the plugin. At the moment I see just copy-pasted code snippets around the project.

[terrakok]

your snippet adds every leaf sources as dependy to the skiko. why? we need hierarhical structure

[chrisjenx]

Was it intentional to not add this too the ComposePlugin ?

[FunkyMuse]

Was it intentional to not add this too the ComposePlugin ?

I'm wondering the same thing

in the meantime

jetbrains-compose-window-size = { module = "org.jetbrains.compose.material3:material3-window-size-class", version.ref = "cmp-plugin" }

[chrisjenx]

Yes but it doesn't work so I wouldn't worry. Not sure how the tests passed TBH..

[FunkyMuse]

Yes but it doesn't work so I wouldn't worry. Not sure how the tests passed TBH..

Yeah, same here, I can't seem to reference the function calculateWindowSizeClass
Just wrote to slack https://kotlinlang.slack.com/archives/C3PQML5NU/p1724255794662019

[terrakok]

Pull requests are not right place to discuss features or issues. Let's do this on the youtrack

For your case:

val windowSizeClass = currentWindowAdaptiveInfo().windowSizeClass