Fix IME insets propagation and Scroll To Focused Node behaviour #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Sep 2, 2024
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/node/RootNodeOwner.skiko.kt
Outdated
Show resolved
Hide resolved
mazunin-v-jb
reviewed
Sep 3, 2024
...e/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/ComposeSceneKeyboardOffsetManager.kt
Outdated
Show resolved
Hide resolved
mazunin-v-jb
approved these changes
Sep 3, 2024
ASalavei
force-pushed
the
andrei.salavei/ime-insets-fix
branch
from
a494e07
to
7a56156
Compare
ASalavei
changed the title
ASalavei
changed the title
ASalavei
changed the title
|
@mazunin-v-jb , @MatkovIvan , I have significantly updated the keyboard animation implementation. Please take a look. @m-sasha , I added some changes to the iOS instrumented tests. You might want to take a look. |
m-sasha
approved these changes
Sep 9, 2024
...ose/ui/ui/src/uikitInstrumentedTest/kotlin/androidx/compose/ui/test/UIKitInstrumentedTest.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/PlatformInsets.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Sep 11, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Outdated
Show resolved
Hide resolved
ASalavei
added a commit
that referenced
this pull request
Sep 11, 2024
## Proposed Changes Update IME insets handling and improve keyboard appearance animation synchronisation. Add to skikoMain code responsible for layer offset when element is focused. ## Testing Test: All 4 combinations with all possible values of `ComposeUIViewControllerConfiguration.onFocusBehavior` and `ComposeUIViewControllerConfiguration.platformLayers` should be verified in combination with TextField on the scene. Also, verify Matryoshka-like interop views containing TextField. ## Issues Fixed Fixes: https://youtrack.jetbrains.com/issue/CMP-5009/Offset-difference-in-IME-padding-between-iOS-and-Android Fixes: https://youtrack.jetbrains.com/issue/CMP-1501/Long-TestField-still-behaves-strange Fixes: https://youtrack.jetbrains.com/issue/CMP-3621/Issues-with-Keyboard-and-TextField-on-iOS. Fixes: https://youtrack.jetbrains.com/issue/CMP-4506/Incorrect-imePadding-and-high-cpu-usage-when-repeatedly-opening-and-closing-Keyboard-on-iOS Fixes: https://youtrack.jetbrains.com/issue/CMP-6635/iOS.-almostFullScreen.-Selection-handlers-in-wrong-positions
|
Added Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update IME insets handling and improve keyboard appearance animation synchronisation.
Add to skikoMain code responsible for layer offset when element is focused.
Testing
Test: All 4 combinations with all possible values of
ComposeUIViewControllerConfiguration.onFocusBehaviorandComposeUIViewControllerConfiguration.platformLayersshould be verified in combination with TextField on the scene.Also, verify Matryoshka-like interop views containing TextField.
Issues Fixed
Fixes: https://youtrack.jetbrains.com/issue/CMP-5009/Offset-difference-in-IME-padding-between-iOS-and-Android
Fixes: https://youtrack.jetbrains.com/issue/CMP-1501/Long-TestField-still-behaves-strange
Fixes: https://youtrack.jetbrains.com/issue/CMP-3621/Issues-with-Keyboard-and-TextField-on-iOS.
Fixes: https://youtrack.jetbrains.com/issue/CMP-4506/Incorrect-imePadding-and-high-cpu-usage-when-repeatedly-opening-and-closing-Keyboard-on-iOS
Fixes: https://youtrack.jetbrains.com/issue/CMP-6635/iOS.-almostFullScreen.-Selection-handlers-in-wrong-positions
Release Notes
Fixes - iOS
TextFieldimePaddingand high cpu usage when repeatedly opening and closingKeyboardon iOS"