Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support material3-adaptive #3688

Closed
igordmn opened this issue Sep 15, 2023 · 8 comments
Closed

Support material3-adaptive #3688

igordmn opened this issue Sep 15, 2023 · 8 comments
Labels
commonization enhancement New feature or request

Comments

@igordmn
Copy link
Collaborator

igordmn commented Sep 15, 2023

This library is currently (15-09-2023) under development and haven't reach the stable 1.0 state yet: https://github.com/androidx/androidx/tree/androidx-main/compose/material3/material3-adaptive

It mostly developed in commonMain, so it is possible to port it to Compose Multiplatform

@igordmn igordmn added enhancement New feature or request submitted commonization and removed submitted labels Sep 15, 2023
@Omico
Copy link
Contributor

Omico commented Mar 10, 2024

This has been moved to https://github.com/androidx/androidx/tree/androidx-main/compose/material3/adaptive.
See also https://developer.android.com/jetpack/androidx/releases/compose-material3-adaptive.

@Omico
Copy link
Contributor

Omico commented Jun 6, 2024

We need to modify & publish our own androidx.window:window-core first. I have done some work on this. I’m currently using Compose Multiplatform 1.6.11, and the ported Jetpack Compose Material3 Adaptive libraries are version 1.0.0-alpha08. Newer versions of Jetpack Compose Material3 Adaptive libraries require Compose 1.7.

My project only has a JVM desktop and WASM target.

image

@doTTTTT
Copy link

doTTTTT commented Jun 6, 2024

@Omico In Window Manager 1.3.0 they added Kotlin Multiplatform support for Window Size Classes. this will help ?
https://developer.android.com/jetpack/androidx/releases/window#1.3.0

And Chris Banes publish a lib for the WindowSizeClass to be available in Kotlin Mutliplatform
https://github.com/chrisbanes/material3-windowsizeclass-multiplatform

@Omico
Copy link
Contributor

Omico commented Jun 7, 2024

@Omico In Window Manager 1.3.0 they added Kotlin Multiplatform support for Window Size Classes. this will help ? https://developer.android.com/jetpack/androidx/releases/window#1.3.0

And Chris Banes publish a lib for the WindowSizeClass to be available in Kotlin Mutliplatform https://github.com/chrisbanes/material3-windowsizeclass-multiplatform

These two are not the same.

See the difference between:
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:window/window-core/src/commonMain/kotlin/androidx/window/core/layout/WindowSizeClass.kt
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3-window-size-class/src/commonMain/kotlin/androidx/compose/material3/windowsizeclass/WindowSizeClass.kt

Jetpack Compose Material3 Adaptive libraries are using androidx.window:window-core.

I decided to open source the project ahead of time so you can check it out for yourself. https://github.com/OmicoDev/wwm

@dozy-programmer
Copy link

@Omico Is there a timeline of when this is expected to be available?

@Omico
Copy link
Contributor

Omico commented Aug 6, 2024

@Omico Is there a timeline of when this is expected to be available?

I'm not a member of the JetBrains/Google team, and it's unclear which team should be responsible for publishing this component to Maven. I think you should ask @igordmn for more information. Anyway, you'll be able to copy my work on your project.

@MatkovIvan
Copy link
Member

JetBrains/compose-multiplatform-core#1468

@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commonization enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants