-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory usage increases exponentially with each opening of ModalBottomSheet
on iOS
#4626
Closed
robxyy opened this issue
Apr 16, 2024
· 4 comments
· Fixed by JetBrains/compose-multiplatform-core#1292
Closed
Memory usage increases exponentially with each opening of ModalBottomSheet
on iOS
#4626
robxyy opened this issue
Apr 16, 2024
· 4 comments
· Fixed by JetBrains/compose-multiplatform-core#1292
Labels
Comments
After setting |
Yes, thank you! We've already proved, that the machinery responsible for Dialogs/Popups layers somehow leaks the memory, investigating it. |
Bisected a regression point: |
elijah-semyonov
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this issue
Apr 19, 2024
## Proposed Changes Remove views from superviews to break some retain cycle. ## Testing Test: TODO ## Issues Fixed Fixes: JetBrains/compose-multiplatform#4626
MatkovIvan
pushed a commit
to JetBrains/compose-multiplatform-core
that referenced
this issue
Apr 22, 2024
## Proposed Changes Replace `CGColorCreate` with `UIColor.clearColor.CGColor` ## Testing Test: Frequently open ModalBottomSheet or Popup, and then view memory leak information in `Instruments`. Fix before: <img width="720" alt="image" src="https://github.com/JetBrains/compose-multiplatform-core/assets/9105106/958839b6-9abd-4dbe-8ae2-6ed08412c8ab"> ## Issues Fixed Fixes: This is part of JetBrains/compose-multiplatform#4626
Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Memory usage increases exponentially with each opening of
ModalBottomSheet
oniOS
Affected platforms
Versions
To Reproduce
Expected behavior
Normal memory growth
Screenshots
The text was updated successfully, but these errors were encountered: