Add a redundancy warning to skiko.js for k/wasm target #5134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgonmic
approved these changes
Sep 10, 2024
skiko.js used to be required for k/wasm projects. But some time ago it was refactored to use skiko.mjs, so skiko.js is not needed anymore (for k/wasm, still needed for k/js). But some k/wasm projects still include skiko.js in index.html which leads to extra loading time. The intention is to notify them without causing 404 errors for now.
eymar
force-pushed
the
ok/warn_about_skikojs_in_kwasm_app
branch
from
cf2149d
to
76e7c2b
Compare
eymar
added a commit
that referenced
this pull request
Sep 11, 2024
skiko.js used to be required for k/wasm projects. But some time ago it was refactored to use skiko.mjs, so skiko.js is not needed anymore (for k/wasm, still needed for k/js). But there are k/wasm projects still including skiko.js in index.html which leads to extra loading time. The intention is to notify them without causing 404 errors for now. ## Testing - updated a test - tested manually <img width="856" alt="Screenshot 2024-09-10 at 15 34 41" src="https://github.com/user-attachments/assets/9ad9b790-d3fa-4907-b9ee-f5e682f38858"> ## Release Notes ### Highlights - Web - `skiko.js` is redundant in case of K/Wasm Compose for Web applications and it can be removed from index.html files to not load redundant files. We are going to remove `skiko.js` from the k/wasm distribution in the future releases. `skiko.js` is still needed in case of K/JS Compose for Web apps. (cherry picked from commit 8b56020)
|
Changed: to: |
|
Applied to Release notes: |
Tweener
added a commit
to Tweener/czan
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skiko.js used to be required for k/wasm projects. But some time ago it was refactored to use skiko.mjs, so skiko.js is not needed anymore (for k/wasm, still needed for k/js). But there are k/wasm projects still including skiko.js in index.html which leads to extra loading time. The intention is to notify them without causing 404 errors for now.
Testing
Release Notes
Highlights - Web
skiko.jsis redundant in case of K/Wasm Compose Multiplatform for web applications and it can be removed from index.html files to not load redundant files.skiko.jswill be removed from the k/wasm distribution in the future releases.skiko.jsis still needed in case of K/JS Compose Multiplatform for web apps.