Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postions sampled are not matched with aabb_scale #47

Open
hdzmtsssw opened this issue Sep 21, 2022 · 0 comments
Open

postions sampled are not matched with aabb_scale #47

hdzmtsssw opened this issue Sep 21, 2022 · 0 comments

Comments

@hdzmtsssw
Copy link

Hi there! When I visualize the 'pos' sampled by the density_grid_sampler in line 70 in runner.py, I found that whatever aabb_scale is, pos ranges in [0, 1]. And when I set 'const_dt=True', pos ranges even smaller when aabb_scale is larger! It seems that there is something wrong with the aabb_scale or the density_grid_sampler. @Gword

Here are some pictures. The yellow cube is a unit cube. The white points are rays_o. The red/black points are pos.
vasedeck_pos_aabbscale1
👆aabb_scale=1

vasedeck_pos_aabbscale2
👆aabb_scale=2

vasedeck_pos_aabbscale16
👆aabb_scale=16

vasedeck_pos_aabbscale1_constdt
👆aabb_scale=1, constdt=True

vasedeck_pos_aabbscale8_constdt
👆aabb_scale=8, constdt=True

@hdzmtsssw hdzmtsssw changed the title postions sampled is not matched with aabb_scale postions sampled are not matched with aabb_scale Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant