Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Typo" error in debugAddGlobalIntxxx() Methods leads to wring datatype #10

Open
SokoFromNZ opened this issue Jun 17, 2019 · 0 comments
Open

Comments

@SokoFromNZ
Copy link

Hi,

Just used your great library and found a small bug I thought I should report:

I was adding a int16 variable using debugAddGlobalInt16_t(...) but the App showed me the variable as uint16.

By checking your source I found the error in SerialDebug.cpp:
In the rows 2417, 2421 and 2425 as well as 2523, 2527 and 2531 you use the wrong value for parameter 3.

I've corrected it already locally for me. Would be great if you can take 50 seconds to do the same on your side so my local changes won't be reverted with your next version :)

thx
Soko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant