Skip to content
This repository has been archived by the owner on Feb 5, 2023. It is now read-only.

JoeKarow/47 initial steps #69

Merged
merged 56 commits into from
Jun 28, 2022
Merged

JoeKarow/47 initial steps #69

merged 56 commits into from
Jun 28, 2022

Conversation

JoeKarow
Copy link
Owner

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #47

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

JoeKarow and others added 30 commits June 18, 2022 21:28
user table - add in ability to disable user from signin
- adjusted scope for twitter login

- return user id & role properties to session on signin

- reject signin if user.disabled === true
This is to centralize the instance if PrismaClient to prevent multiple
instances from being spawned
prisma returns dates as objects, which Next does not like

This helper function converts given object keys to strings
This should be okay - useSession hook shouldn't cause any additional renders
@JoeKarow JoeKarow marked this pull request as draft June 26, 2022 18:00
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['breaking-change', 'bugfix', 'documentation', 'enhancement', 'refactor', 'performance', 'new-feature', 'maintenance', 'ci', 'dependencies']

@ghost
Copy link

ghost commented Jun 26, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@JoeKarow JoeKarow added enhancement Enhancement of the code, not introducing new features. new-feature New features or options. in-progress Issue is currently being worked on by a developer. automerge Enable Kodiak auto-merge labels Jun 26, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 26, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 26, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 27, 2022
@JoeKarow JoeKarow marked this pull request as ready for review June 28, 2022 17:10
@JoeKarow JoeKarow merged commit 41759a5 into main Jun 28, 2022
@JoeKarow JoeKarow deleted the JoeKarow/47-initial-steps branch June 28, 2022 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Enable Kodiak auto-merge enhancement Enhancement of the code, not introducing new features. in-progress Issue is currently being worked on by a developer. new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant