From a7cd86425d6a051ac8b3161df5d3121ad0762a8d Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Sat, 3 Dec 2022 01:32:00 +0100 Subject: [PATCH] clarify subtree tool policy (#1518) --- src/contributing.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/contributing.md b/src/contributing.md index 7100a316826cd..41ad1c915c5c9 100644 --- a/src/contributing.md +++ b/src/contributing.md @@ -191,8 +191,10 @@ differently from other crates that are directly in this repo: In contrast to `submodule` dependencies (see below for those), the `subtree` dependencies are just regular files and directories which can -be updated in tree. However, enhancements, bug fixes, etc. specific to these tools should be filed -against the tools directly in their respective upstream repositories. +be updated in tree. However, if possible, enhancements, bug fixes, etc. specific +to these tools should be filed against the tools directly in their respective +upstream repositories. The exception is that when rustc changes are required to +implement a new tool feature or test, that should happen in one collective rustc PR. #### Synchronizing a subtree