diff --git a/Dockerfile.cypress b/.circleci/Dockerfile.cypress similarity index 69% rename from Dockerfile.cypress rename to .circleci/Dockerfile.cypress index 3efef14f49..ac8efd848b 100644 --- a/Dockerfile.cypress +++ b/.circleci/Dockerfile.cypress @@ -3,7 +3,8 @@ FROM cypress/browsers:chrome67 ENV APP /usr/src/app WORKDIR $APP -RUN npm install --no-save cypress @percy/cypress > /dev/null +COPY package.json $APP/package.json +RUN npm run cypress:install > /dev/null COPY cypress $APP/cypress COPY cypress.json $APP/cypress.json diff --git a/.circleci/config.yml b/.circleci/config.yml index 2c8b15a75f..b7f788dfbc 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -39,7 +39,7 @@ jobs: name: Copy Test Results command: | mkdir -p /tmp/test-results/unit-tests - docker cp tests:/app/coverage.xml ./coverage.xml + docker cp tests:/app/coverage.xml ./coverage.xml docker cp tests:/app/junit.xml /tmp/test-results/unit-tests/results.xml - store_test_results: path: /tmp/test-results @@ -58,7 +58,7 @@ jobs: environment: COMPOSE_FILE: .circleci/docker-compose.cypress.yml COMPOSE_PROJECT_NAME: cypress - PERCY_TOKEN_ENCODED: MWM3OGUzNzk4ZWQ2NTE4YTBhMDAwZDNiNWE1Nzc4ZjEzZjYyMzY1MjE0NjY0NDRiOGE5ODc5ZGYzYTU4ZmE4NQ== + PERCY_TOKEN_ENCODED: ZGRiY2ZmZDQ0OTdjMzM5ZWE0ZGQzNTZiOWNkMDRjOTk4Zjg0ZjMxMWRmMDZiM2RjOTYxNDZhOGExMjI4ZDE3MA== docker: - image: circleci/node:8 steps: @@ -96,9 +96,7 @@ jobs: - setup_remote_docker - checkout - run: .circleci/update_version - - run: docker login -u $DOCKER_USER -p $DOCKER_PASS - - run: docker build -t redash/redash:$(.circleci/docker_tag) . - - run: docker push redash/redash:$(.circleci/docker_tag) + - run: .circleci/docker_build workflows: version: 2 build: @@ -109,21 +107,23 @@ workflows: - frontend-unit-tests - frontend-e2e-tests - build-tarball: - requires: - - backend-unit-tests - filters: - tags: - only: /v[0-9]+(\.[0-9\-a-z]+)*/ - branches: - only: - - master - - /release\/.*/ + requires: + - backend-unit-tests + - frontend-unit-tests + - frontend-e2e-tests + filters: + branches: + only: + - master + - /release\/.*/ - build-docker-image: - requires: - - backend-unit-tests - filters: - branches: - only: - - master - - preview-build - - /release\/.*/ + requires: + - backend-unit-tests + - frontend-unit-tests + - frontend-e2e-tests + filters: + branches: + only: + - master + - preview-image + - /release\/.*/ diff --git a/.circleci/docker-compose.cypress.yml b/.circleci/docker-compose.cypress.yml index 2581d5d1a9..2483582ce7 100644 --- a/.circleci/docker-compose.cypress.yml +++ b/.circleci/docker-compose.cypress.yml @@ -23,12 +23,12 @@ services: REDASH_LOG_LEVEL: "INFO" REDASH_REDIS_URL: "redis://redis:6379/0" REDASH_DATABASE_URL: "postgresql://postgres@postgres/postgres" - QUEUES: "queries,scheduled_queries,celery" + QUEUES: "queries,scheduled_queries,celery,schemas" WORKERS_COUNT: 2 cypress: build: context: ../ - dockerfile: Dockerfile.cypress + dockerfile: .circleci/Dockerfile.cypress depends_on: - server - worker diff --git a/.circleci/docker_build b/.circleci/docker_build new file mode 100755 index 0000000000..50acc2f526 --- /dev/null +++ b/.circleci/docker_build @@ -0,0 +1,17 @@ +#!/bin/bash +VERSION=$(jq -r .version package.json) +VERSION_TAG=$VERSION.b$CIRCLE_BUILD_NUM + +docker login -u $DOCKER_USER -p $DOCKER_PASS + +if [ $CIRCLE_BRANCH = master ] || [ $CIRCLE_BRANCH = preview-image ] +then + docker build -t redash/redash:preview -t redash/preview:$VERSION_TAG . + docker push redash/redash:preview + docker push redash/preview:$VERSION_TAG +else + docker build -t redash/redash:$VERSION_TAG . + docker push redash/redash:$VERSION_TAG +fi + +echo "Built: $VERSION_TAG" \ No newline at end of file diff --git a/.circleci/docker_tag b/.circleci/docker_tag deleted file mode 100755 index 5f20a48bd0..0000000000 --- a/.circleci/docker_tag +++ /dev/null @@ -1,10 +0,0 @@ -#!/bin/bash -if [ $CIRCLE_BRANCH = master ] || [ $CIRCLE_BRANCH = preview-build ] -then - FULL_VERSION='preview' -else - VERSION=$(jq -r .version package.json) - FULL_VERSION=$VERSION.b$CIRCLE_BUILD_NUM -fi - -echo $FULL_VERSION diff --git a/.codeclimate.yml b/.codeclimate.yml index c17ce2e20a..c7def082ae 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -1,22 +1,40 @@ -engines: +version: "2" +checks: + complex-logic: + enabled: false + file-lines: + enabled: false + method-complexity: + enabled: false + method-count: + enabled: false + method-lines: + config: + threshold: 100 + nested-control-flow: + enabled: false + identical-code: + enabled: false + similar-code: + enabled: false +plugins: pep8: enabled: true eslint: enabled: true - channel: "eslint-3" + channel: "eslint-5" config: config: client/.eslintrc.js checks: import/no-unresolved: enabled: false -ratings: - paths: - - "redash/**/*.py" - - "client/**/*.js" -exclude_paths: -- tests/**/*.py -- migrations/**/*.py -- old_migrations/**/*.py -- setup/**/* -- bin/**/* - + no-multiple-empty-lines: # TODO: Enable + enabled: false +exclude_patterns: +- "tests/**/*.py" +- "migrations/**/*.py" +- "setup/**/*" +- "bin/**/*" +- "**/node_modules/" +- "client/dist/" +- "**/*.pyc" diff --git a/.dockerignore b/.dockerignore index 69c145ad11..d233c7a9d5 100644 --- a/.dockerignore +++ b/.dockerignore @@ -3,4 +3,12 @@ client/dist/ node_modules/ .tmp/ .venv/ +venv/ .git/ +/.codeclimate.yml +/.coverage +/coverage.xml +/.circleci/ +/.github/ +/netlify.toml +/setup/ diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000..a4e1d25210 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,15 @@ +## What type of PR is this? (check all applicable) + + +- [ ] Refactor +- [ ] Feature +- [ ] Bug Fix +- [ ] New Query Runner (Data Source) +- [ ] New Alert Destination +- [ ] Other + +## Description + +## Related Tickets & Documents + +## Mobile & Desktop Screenshots/Recordings (if there are UI changes) diff --git a/.github/support.yml b/.github/support.yml new file mode 100644 index 0000000000..164b588b36 --- /dev/null +++ b/.github/support.yml @@ -0,0 +1,23 @@ +# Configuration for Support Requests - https://github.com/dessant/support-requests + +# Label used to mark issues as support requests +supportLabel: Support Question + +# Comment to post on issues marked as support requests, `{issue-author}` is an +# optional placeholder. Set to `false` to disable +supportComment: > + :wave: @{issue-author}, we use the issue tracker exclusively for bug reports + and planned work. However, this issue appears to be a support request. + Please use [our forum](https://discuss.redash.io) to get help. + +# Close issues marked as support requests +close: true + +# Lock issues marked as support requests +lock: false + +# Assign `off-topic` as the reason for locking. Set to `false` to disable +setLockReason: true + +# Repository to extend settings from +# _extends: repo diff --git a/.github/weekly-digest.yml b/.github/weekly-digest.yml new file mode 100644 index 0000000000..08cced6393 --- /dev/null +++ b/.github/weekly-digest.yml @@ -0,0 +1,7 @@ +# Configuration for weekly-digest - https://github.com/apps/weekly-digest +publishDay: mon +canPublishIssues: true +canPublishPullRequests: true +canPublishContributors: true +canPublishStargazers: true +canPublishCommits: true diff --git a/CHANGELOG.md b/CHANGELOG.md index 9341e1c32d..cbefdec544 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,55 +1,132 @@ # Change Log +## v7.0.0 - 2019-03-17 + +We're trying a new format for the CHANGELOG in this release. Focusing on the bigger changes, but for whoever interested, you can see all the changes [here](https://github.com/getredash/redash/compare/v6.0.0...master). + +Besides all the features, bug fixes and improvements listed below we managed to convert a large portion of Redash's frontend code from Angular.js to React. You can see status in [#3071](https://github.com/getredash/redash/issues/3071). + +This release was made possible with the help of 34 contributors. 🙇‍♂️ + +### Data Sources + +- **All data source options are now encrypted in the database.** By default the encryption uses the `REDASH_COOKIE_SECRET` value (`redash.settings.COOKIE_SECRET`), but you can specify a different value by setting the `REDASH_SECRET_KEY` environment variable value. Note that you need to set this _before_ doing the upgrade. +- New Data Sources: Uptycs and Apache Drill. +- Snowplow: is now enabled by default & supports region setting. +- Elasticsearch: add support for Amazon Elasticsearch IAM authentication (with IAM profile or key/secret pair). +- PostgreSQL: add support for serializing range values. +- Redshift: remove duplicate column information for late-binding views. +- Athena: load all databases (using pagination). +- BigQuery: correctly handle temp tables with no schema field. +- Jira (JQL): support for fetching all records with pagination. +- Prometheus: fix schema loading and add support for query range. + +### In-app Help + +You can now open the [Knowledge Base](https://redash.io/help) inside the application. We also added a few "help triggers" in the app, that will open the Knowledge Base in context of what you're currently doing. + +### Parameters + +- **Dashboard Parameters**: We improved the flow of adding queries with parameters to dashboards and now give you full control over how parameters are mapped. You no longer have to make sure all parameters have the same name or use the `Global` checkbox. We also added new options, like keeping the parameter local to the widget or setting a static value. [Read more in our Knowledge Base →](https://redash.io/help/user-guide/querying/query-parameters#Parameter-Mapping-on-Dashboards) +- We added server side validation of parameter values for all parameter types, except for parameters of `text` type. All validated parameter types are considered safe. When a query is using safe parameters (or no parameters at all), View Only users can refresh it. +- Refreshing safe queries is done using the new results API endpoint, which takes only a query ID (and optionally parameter values) and does not need the query text. + +### Query Editor Improvements + +- Run only the highlighted query text: hit Execute after highlighting a portion of your query and only the selected portion will be sent to the database. This is useful for testing sub-SELECT statements and CTE's. +- Improved auto complete: add a dot . after a table name in the query editor and auto complete will only suggest columns on that table. +- Autosave parameter configuration changes. +- YAML syntax support (for data sources like Yandex Metrica). + +### Improved Query Scheduler + +The Query Scheduler got a face lift and some new options: you can pick a day for a weekly schedule to run on and also set an end date after which the query will no longer execute on schedule. + +### Data Sources + +We added Apache Drill, Uptycs and a new JSON data source. Also fixed a few bugs in Athena's query runner and others. + +### User Management + +The users page got revamped with a new look and feel and few new features: + +- An indication when a user was last active. +- Show if an invited user hasn't finished the setup process yet (Pending Invitations section). +- You can now generate a new API key for users, if there's a concern it was compromised. + +### Admin + +- New Celery queues status screens, replacing the old Queries Status and better reflecting the status of running queries. +- Make the queue name for schema refresh job configurable. The default used to be hard coded `schemas`, which is not available on all setups. Now it's `celery`. +- The `gevent` library is installed by default, and you can now setup gunicorn to use `gevent` based workers. +- New Docker entrypoint command to do a health check for a worker process. +- Flask-Admin is no longer setup or supported. + +### Other Changes + +- New Alert destination: Google Hangouts Chat. +- When downloading results from the results API it will set a user friendly filename for the downloaded file. +- Archived Queries section added to the queries list. + +### Bug Fixes + +- Fixed: fork query does not fork tables but instead adds default table. +- Fixed: when deleting a visualization, any widget using it was left empty on the dashboard. +- Fixed: issues with Query Editor resizing on new versions of Chrome. +- Fixed: issues with exporting dictionaries to Excel. +- Fixed: Cohort visualization gets stuck when passing string values. +- Fixed: use series name for Pie chart label. +- Make sure Flask app created in Celery's worker process (could cause some query runners to get stuck while running queries). + ## v6.0.0 - 2018-12-16 -v6.0.0 release version. Mainly includes fixes for regressions from the beta version. +v6.0.0 release version. Mainly includes fixes for regressions from the beta version. This release had contributions from 5 people: @rauchy, @denisov-vlad, @arikfr, @ariarijp, and @gabrieldutra. Thank you, everyone 🙏 ### Changed -* #3183 Make refresh_queries less noisey in logs. @arikfr +- #3183 Make refresh_queries less noisey in logs. @arikfr ### Fixed -* #3163 Include correct version in production builds. @rauchy -* #3161 Clickhouse: fix int() conversion error. @denisov-vlad -* #3166 Directly using record_event task requires timestamp. @arikfr -* #3167 Alert.evaluate failing when the column is missing. @arikfr -* ##3162 Remove API permissions for users who have been disabled. @rauchy -* #3171 Reject empty query name. @ariarijp -* #3175, #3186 Fix disable error message. @rauchy, @gabrieldutra -* #3182 [Redshift] support for schema names with dots. @arikfr -* #3187 Safely create_app in Celery code (try to fetch current_app first). @arikfr +- #3163 Include correct version in production builds. @rauchy +- #3161 Clickhouse: fix int() conversion error. @denisov-vlad +- #3166 Directly using record_event task requires timestamp. @arikfr +- #3167 Alert.evaluate failing when the column is missing. @arikfr +- ##3162 Remove API permissions for users who have been disabled. @rauchy +- #3171 Reject empty query name. @ariarijp +- #3175, #3186 Fix disable error message. @rauchy, @gabrieldutra +- #3182 [Redshift] support for schema names with dots. @arikfr +- #3187 Safely create_app in Celery code (try to fetch current_app first). @arikfr ### Other -* #3155 Add DB Seed to Cypress and setup Percy. @gabrieldutra -* #3180 Remove coverage from pytest terminal output. @rauchy - +- #3155 Add DB Seed to Cypress and setup Percy. @gabrieldutra +- #3180 Remove coverage from pytest terminal output. @rauchy ## v6.0.0-beta - 2018-12-03 -This release was 2 months in the making and it is full with good stuff! +This release was 2 months in the making and it is full with good stuff! -* We have 5 new data sources: Databricks, IBM DB2, Kylin, Druid and Rockset. ⌗ -* There are fixes and improvements to 11 existing data sources (MySQL, Redshift, Postgres, MongoDB, Google BigQuery, Vertica, TreasureData, Presto, ClickHouse, Google Sheets and Google Analytics). -* The Query Results data source can now load cached results, just use the `cached_query_` prefix instead of `query_`. -* On the visualizations front we added a Heatmap visualization and did updated the table and counter visualizations. -* Alerts got some fixes and a new destination: PagerDuty. -* If the live autocomplete in the code editor annoys you, you can disable it now (although we're working to make it better, see #3092). -* Fast queries will now load faster. 🏃‍♂️ -* We improved the layout of visualizations and content on smaller screen sizes. 📱 -* For those of you who like sharing, you can now enable the ability to share ownership of queries and dashboards and let others to edit them. Check the Settings page to enable this feature. +- We have 5 new data sources: Databricks, IBM DB2, Kylin, Druid and Rockset. ⌗ +- There are fixes and improvements to 11 existing data sources (MySQL, Redshift, Postgres, MongoDB, Google BigQuery, Vertica, TreasureData, Presto, ClickHouse, Google Sheets and Google Analytics). +- The Query Results data source can now load cached results, just use the `cached_query_` prefix instead of `query_`. +- On the visualizations front we added a Heatmap visualization and did updated the table and counter visualizations. +- Alerts got some fixes and a new destination: PagerDuty. +- If the live autocomplete in the code editor annoys you, you can disable it now (although we're working to make it better, see #3092). +- Fast queries will now load faster. 🏃‍♂️ +- We improved the layout of visualizations and content on smaller screen sizes. 📱 +- For those of you who like sharing, you can now enable the ability to share ownership of queries and dashboards and let others to edit them. Check the Settings page to enable this feature. -There were also important changes to the code and infrastructure: +There were also important changes to the code and infrastructure: -* More components moved to React. -* We switched to Webpack 4 with the help of @dmonego. -* We upgraded to Celery 4 with the help of @emtwo, @jezdez, @mashrikt and @atharvai. -* We started moving towards Python 3 for our backend. The first step was to make sure our code pass basic sanity tests with Flake 8, which was implemented by @cclauss. -* We improved our testing on the frontend by adding setup for Jest tests and E2E testing using Cypress (@gabrieldutra). -* Each pull request now gets a deploy preview using Netlify to easily test frontend changes. +- More components moved to React. +- We switched to Webpack 4 with the help of @dmonego. +- We upgraded to Celery 4 with the help of @emtwo, @jezdez, @mashrikt and @atharvai. +- We started moving towards Python 3 for our backend. The first step was to make sure our code pass basic sanity tests with Flake 8, which was implemented by @cclauss. +- We improved our testing on the frontend by adding setup for Jest tests and E2E testing using Cypress (@gabrieldutra). +- Each pull request now gets a deploy preview using Netlify to easily test frontend changes. This is just a summary, you're welcome to review the full list below. ⬇ @@ -57,226 +134,220 @@ This release had contributions from 38 people: @arikfr, @kravets-levko, @jezdez, ### Added -* #2747, #3143 Add a new Databricks query runner. @alison985, @jezdez, @arikfr -* #2767 Add ability to add viz to dashboard from query edit page. @alison985, @jezdez -* #2780 Add a query autocomplete toggle. @alison985, @jezdez, @arikfr -* #2768 Add authentication via JWT providers. @SakuradaJun -* #2790 Add the ability to sort favorited queries, paginate the dashboard list and improve UI inconsistencies. @jezdez -* #2681 Add ability to search table column names in schema browser. @alison985 -* #2855 Add option to query cached results. @yoavbls -* #2740 Add ability for extensions to add periodic tasks. @emtwo -* #2924 Google Spreadsheets: Add support for opening by URL. @alexanderlz -* #2903 Add PagerDuty as an Alert Destination. @alexanderlz -* #2824 Add support for expanding dashboard visualizations. @sjakthol -* #2900 Add ability to specify a counter label. @ralphilius -* #2565 Add frontend extension capabilities. @emtwo -* #2848 Add IBM Db2 as a data source using the ibm-db Python package. @nicof38 -* #2959 Add option to auto reload widget data in shared dashboards. @arikfr -* #2993 Add page size settings. @kyoshidajp -* #2080 New Heatmap chart visualization with Plotly. @deecay -* #2991 Show users in CLI group list. @GitSumito -* #2342 New SQLPARSE_FORMAT_OPTIONS setting to configure query formatter. @ariarijp -* #3031 Add some tests for Query Results. @ariarijp -* #2936 Add Kylin data source. @Trigl -* #3047 Add Druid data source. @rauchy -* #3077 New user interface for the feature flag of the share edit permissions feature. @arikfr -* #3007 Add permissions to the result of "manage.py groups list" command. @Udomomo -* #3088 Add get_current_user() fuction for the Python query runner. @kyoshidajp -* #3114 Add event tracking to autocomplete toggle. @arikfr -* #3068 Add Rockset query runner. @igorcanadi, @arikfr -* #3105 Display frontend version. @rauchy +- #2747, #3143 Add a new Databricks query runner. @alison985, @jezdez, @arikfr +- #2767 Add ability to add viz to dashboard from query edit page. @alison985, @jezdez +- #2780 Add a query autocomplete toggle. @alison985, @jezdez, @arikfr +- #2768 Add authentication via JWT providers. @SakuradaJun +- #2790 Add the ability to sort favorited queries, paginate the dashboard list and improve UI inconsistencies. @jezdez +- #2681 Add ability to search table column names in schema browser. @alison985 +- #2855 Add option to query cached results. @yoavbls +- #2740 Add ability for extensions to add periodic tasks. @emtwo +- #2924 Google Spreadsheets: Add support for opening by URL. @alexanderlz +- #2903 Add PagerDuty as an Alert Destination. @alexanderlz +- #2824 Add support for expanding dashboard visualizations. @sjakthol +- #2900 Add ability to specify a counter label. @ralphilius +- #2565 Add frontend extension capabilities. @emtwo +- #2848 Add IBM Db2 as a data source using the ibm-db Python package. @nicof38 +- #2959 Add option to auto reload widget data in shared dashboards. @arikfr +- #2993 Add page size settings. @kyoshidajp +- #2080 New Heatmap chart visualization with Plotly. @deecay +- #2991 Show users in CLI group list. @GitSumito +- #2342 New SQLPARSE_FORMAT_OPTIONS setting to configure query formatter. @ariarijp +- #3031 Add some tests for Query Results. @ariarijp +- #2936 Add Kylin data source. @Trigl +- #3047 Add Druid data source. @rauchy +- #3077 New user interface for the feature flag of the share edit permissions feature. @arikfr +- #3007 Add permissions to the result of "manage.py groups list" command. @Udomomo +- #3088 Add get_current_user() fuction for the Python query runner. @kyoshidajp +- #3114 Add event tracking to autocomplete toggle. @arikfr +- #3068 Add Rockset query runner. @igorcanadi, @arikfr +- #3105 Display frontend version. @rauchy ### Changed -* #2636 Rewrite query editor with React. @washort, @arikfr -* #2637 Convert edit-in-place component to React. @washort, @arikfr -* #2766 Suitable events are now being recorded server side instead of in the frontend. @alison985, @jezdez -* #2796 Change placement (right/bottom) of chart legend depending on chart width. @kravets-levko -* #2833 Uses server side sort order for tag list and show count of tagged items. @jezdez -* #2318 Support authentication for the URL data source. @jezdez -* #2884 Rename Yandex Metrika to Metrica. @jezdez -* #2909 MySQL: hide sys tables. @arikfr -* #2817 Consistently use simplejson for loading and dumping JSON. @jezdez -* #2872 Use Plotly's function to clean y-values (x may be category or date/time). @kravets-levko -* #2938 Auto focus tag input. @kyoshidajp -* #2927 Design refinements for queries pages. @kocsmy -* #2950 Show activity status in CLI user list. @GitSumito -* #2968 Presto data source: setting protocol (http/https), safe loading of error messages. @arikfr -* #2967 Show groups in CLI user list. @GitSumito -* #2603 MongoDB: Update requirements to support srv. @arikfr -* #2961 MongoDB: Skip system collections when loading schema. @arikfr -* #2960 Add timeout to various HTTP requests. @arikfr -* #2983 Databricks: New logo, updated name and enabled by default. @arikfr -* #2982 Table visualization: change default size to 25 and add more size options. @arikfr -* #2866 Redshift: Hide tables the configured user cannot access. @sjakthol -* #3058 Mustache: don't html-escape query parameters values. @kravets-levko -* #3079 Always use basic autocomplete, as well as the live autocomplete. @arikfr -* #3084 Support tel://, sms://, mailto:// links in query results. @zhujunsan -* #3083 Clickhouse: Add WITH TOTALS option support. @denisov-vlad -* #3063 Allow setting colors for bubble charts. @toph -* #3085 BigQuery: Switch to Standard SQL as the default. @kyoshidajp -* #3094 Tags autocomplete: Show note when creating a new label. @kravets-levko -* #2984 Autocomplete toggle improvements. @arikfr -* #3089 Open new tab when forking a query. @kyoshidajp -* #3126 MongoDB: add support for sorting columns. @arikfr -* #3128 Improve backoff algorithm of query results polling to speed it up. @arikfr -* #3125 Vertica: update driver & add support for connection timeout. @arikfr -* #3124 Support unicode in Postgres/Redshift schema. @arikfr -* #3138 Migrate all tags components to React. @kravets-levko -* #3139 Better manage permissions modal. @kocsmy -* #3149 Improve tag link colors and fix group tags on Users page. @kocsmy -* #3146 Update, replace and fix new alert destination logos so it fits better. @kocsmy -* #3147 Add and improve recent db logos that didn't fit in size properly. @kocsmy -* #3148 Fix label positioning on no found screen. @kocsmy -* #3156 json_dumps: add support for serializing buffer objects. @arikfr +- #2636 Rewrite query editor with React. @washort, @arikfr +- #2637 Convert edit-in-place component to React. @washort, @arikfr +- #2766 Suitable events are now being recorded server side instead of in the frontend. @alison985, @jezdez +- #2796 Change placement (right/bottom) of chart legend depending on chart width. @kravets-levko +- #2833 Uses server side sort order for tag list and show count of tagged items. @jezdez +- #2318 Support authentication for the URL data source. @jezdez +- #2884 Rename Yandex Metrika to Metrica. @jezdez +- #2909 MySQL: hide sys tables. @arikfr +- #2817 Consistently use simplejson for loading and dumping JSON. @jezdez +- #2872 Use Plotly's function to clean y-values (x may be category or date/time). @kravets-levko +- #2938 Auto focus tag input. @kyoshidajp +- #2927 Design refinements for queries pages. @kocsmy +- #2950 Show activity status in CLI user list. @GitSumito +- #2968 Presto data source: setting protocol (http/https), safe loading of error messages. @arikfr +- #2967 Show groups in CLI user list. @GitSumito +- #2603 MongoDB: Update requirements to support srv. @arikfr +- #2961 MongoDB: Skip system collections when loading schema. @arikfr +- #2960 Add timeout to various HTTP requests. @arikfr +- #2983 Databricks: New logo, updated name and enabled by default. @arikfr +- #2982 Table visualization: change default size to 25 and add more size options. @arikfr +- #2866 Redshift: Hide tables the configured user cannot access. @sjakthol +- #3058 Mustache: don't html-escape query parameters values. @kravets-levko +- #3079 Always use basic autocomplete, as well as the live autocomplete. @arikfr +- #3084 Support tel://, sms://, mailto:// links in query results. @zhujunsan +- #3083 Clickhouse: Add WITH TOTALS option support. @denisov-vlad +- #3063 Allow setting colors for bubble charts. @toph +- #3085 BigQuery: Switch to Standard SQL as the default. @kyoshidajp +- #3094 Tags autocomplete: Show note when creating a new label. @kravets-levko +- #2984 Autocomplete toggle improvements. @arikfr +- #3089 Open new tab when forking a query. @kyoshidajp +- #3126 MongoDB: add support for sorting columns. @arikfr +- #3128 Improve backoff algorithm of query results polling to speed it up. @arikfr +- #3125 Vertica: update driver & add support for connection timeout. @arikfr +- #3124 Support unicode in Postgres/Redshift schema. @arikfr +- #3138 Migrate all tags components to React. @kravets-levko +- #3139 Better manage permissions modal. @kocsmy +- #3149 Improve tag link colors and fix group tags on Users page. @kocsmy +- #3146 Update, replace and fix new alert destination logos so it fits better. @kocsmy +- #3147 Add and improve recent db logos that didn't fit in size properly. @kocsmy +- #3148 Fix label positioning on no found screen. @kocsmy +- #3156 json_dumps: add support for serializing buffer objects. @arikfr ### Fixed -* #2849 Fix invalid reference to alert.to_dict() in webhook. @wankdanker -* #2840 Improve counter visualization text scaling. @kravets-levko -* #2854 Widget titles are no longer rendered wrong on public dashboards. @kravets-levko -* #2318 Removed redundant exception handling in data sources since that's handled in the query backend. @jezdez -* #2886 Fix Javascript build that broke because registerAll tried to run EditInPlace component. @arikfr -* #2911 Don’t show “Add to dashboard” in dropdown to unsaved queries. @jezdez -* #2916 Fix export query results output file name. @gabrieldutra -* #2917 Fix output file name not changing after rename query. @gabrieldutra -* #2868 Address edge case when retrieving Glue schemas for Athena data source. @kadrach -* #2929 Fix: date value in a filter is duplicated. @combineads -* #2875 Unbreak charts with long legend break in horizontal mode. Update plotly.js. @kravets-levko -* #2937 Fix event recording in admin API backend. @kyoshidajp -* #2953 Minor fixes for the Clickhouse data source. @denisov-vlad -* #2941 Bring back fix to Box plot hover. @arikfr -* #2957 Apply missing CSS classes to EditInPlace component. @arikfr -* #2897 Show "Add description" only after saving the query. @arikfr -* #2922 Query page layout improvements for small screens. @kravets-levko -* #2956 Clickhouse: move timeout to params. @denisov-vlad -* #2964 Fix no tags shown when having empty set. @gabrieldutra -* #2757 Use full text search ranking when searching in list views. @jezdez -* #2969 Query Results data source: improved errors, quoted column names. @arikfr -* #2906 Preventing open redirection in loging process. @kyoshidajp -* #2867 TreasureData: Deduplicate column names. @zaimy -* #2994 Fix scheme of various URLs from http to https. @kyoshidajp -* #2992 Fix an invalid prop type warning in new version notifier. @kyoshidajp -* #3022 Fix Toolbox covering part of a chart. @kravets-levko -* #2998 Fix charts losing responsive features after refreshing the dashboard. @kravets-levko -* #3034 Postgres: handle NaN/Infinity values. @kravets-levko -* #2745 Sort columns with undefined values. @Yossi-a -* #3041 Sort CLI output of lists. @GitSumito -* #2803, #3006 Address various tag display issues on query list page. @kocsmy, @alison985 -* #3049 Fix edit-in-place component which ignored isEditable flag and didn't work on Groups page. @kravets-levko -* #2965 Google Analytics: Fix crash when no results are returned. @alexanderlz -* #3061 Fix table visualization so that the horizontal scrollbar is not be always visible. @kravets-levko -* #3076 Add white-space padding to separators in the footer. @burnash -* #2919 Fix URL data source to not require a URL. @arikfr -* #3098 Force AngularJS to update query editor properly. @washort -* #3100 Delete redundant regex segment in query result frontend. @zhujunsan -* #2978 Prevent the query update timestamp from changing when it is linked to new query results. @rauchy -* #3046 Fix query page header. @kravets-levko -* #3097 Mongo: Fix collection fields retreival bug when Views are present. @jodevsa -* #3107 Keep query text in local state for now. @washort -* #3111 Fix mobile padding issues on Query results. @kocsmy -* #3122 Show menu divider only if query is archived. @jezdez -* #3120 Fix tag counts for dashboards and queries. @jezdez -* #3141 Fix schema refresh to work on MySQL 8. @hoangphuoc25 -* #3142 Fix: editing dashboard title results in the visualizations being replaced by the loading markers. @kravets-levko +- #2849 Fix invalid reference to alert.to_dict() in webhook. @wankdanker +- #2840 Improve counter visualization text scaling. @kravets-levko +- #2854 Widget titles are no longer rendered wrong on public dashboards. @kravets-levko +- #2318 Removed redundant exception handling in data sources since that's handled in the query backend. @jezdez +- #2886 Fix Javascript build that broke because registerAll tried to run EditInPlace component. @arikfr +- #2911 Don’t show “Add to dashboard” in dropdown to unsaved queries. @jezdez +- #2916 Fix export query results output file name. @gabrieldutra +- #2917 Fix output file name not changing after rename query. @gabrieldutra +- #2868 Address edge case when retrieving Glue schemas for Athena data source. @kadrach +- #2929 Fix: date value in a filter is duplicated. @combineads +- #2875 Unbreak charts with long legend break in horizontal mode. Update plotly.js. @kravets-levko +- #2937 Fix event recording in admin API backend. @kyoshidajp +- #2953 Minor fixes for the Clickhouse data source. @denisov-vlad +- #2941 Bring back fix to Box plot hover. @arikfr +- #2957 Apply missing CSS classes to EditInPlace component. @arikfr +- #2897 Show "Add description" only after saving the query. @arikfr +- #2922 Query page layout improvements for small screens. @kravets-levko +- #2956 Clickhouse: move timeout to params. @denisov-vlad +- #2964 Fix no tags shown when having empty set. @gabrieldutra +- #2757 Use full text search ranking when searching in list views. @jezdez +- #2969 Query Results data source: improved errors, quoted column names. @arikfr +- #2906 Preventing open redirection in loging process. @kyoshidajp +- #2867 TreasureData: Deduplicate column names. @zaimy +- #2994 Fix scheme of various URLs from http to https. @kyoshidajp +- #2992 Fix an invalid prop type warning in new version notifier. @kyoshidajp +- #3022 Fix Toolbox covering part of a chart. @kravets-levko +- #2998 Fix charts losing responsive features after refreshing the dashboard. @kravets-levko +- #3034 Postgres: handle NaN/Infinity values. @kravets-levko +- #2745 Sort columns with undefined values. @Yossi-a +- #3041 Sort CLI output of lists. @GitSumito +- #2803, #3006 Address various tag display issues on query list page. @kocsmy, @alison985 +- #3049 Fix edit-in-place component which ignored isEditable flag and didn't work on Groups page. @kravets-levko +- #2965 Google Analytics: Fix crash when no results are returned. @alexanderlz +- #3061 Fix table visualization so that the horizontal scrollbar is not be always visible. @kravets-levko +- #3076 Add white-space padding to separators in the footer. @burnash +- #2919 Fix URL data source to not require a URL. @arikfr +- #3098 Force AngularJS to update query editor properly. @washort +- #3100 Delete redundant regex segment in query result frontend. @zhujunsan +- #2978 Prevent the query update timestamp from changing when it is linked to new query results. @rauchy +- #3046 Fix query page header. @kravets-levko +- #3097 Mongo: Fix collection fields retreival bug when Views are present. @jodevsa +- #3107 Keep query text in local state for now. @washort +- #3111 Fix mobile padding issues on Query results. @kocsmy +- #3122 Show menu divider only if query is archived. @jezdez +- #3120 Fix tag counts for dashboards and queries. @jezdez +- #3141 Fix schema refresh to work on MySQL 8. @hoangphuoc25 +- #3142 Fix: editing dashboard title results in the visualizations being replaced by the loading markers. @kravets-levko ### Other -* #2850 The setup scripts are now based on Ubuntu 18.04 LTS and Docker. @pashaxp, @arikfr -* #2985 Add Jest based tests to our stack. @arikfr -* #2999 Add netlify configuration. @arikfr -* #3000 Initial Cypress based E2E test infrastructure. @gabrieldutra -* #2898 Move Ant styles into a central location. @arikfr -* #2910 Fix webpack build error about BigMessage. @jezdez -* #2928 Speed up builds by skipping installing requirements_all_ds.txt in CI unit tests. @arikfr -* #2963 Fix tarball build failure. @emtwo -* #2996 Fix setup.sh failures when run as root. @arikfr -* #2989 Rearrange make targets. @koooge -* #3036 Update Flask-Admin to 1.5.2. @yoavbls -* #2901 Fix documentation links. @kravets-levko -* #3073 Remove only Redash containers in clean Make task. @ariarijp -* #3048 Remove pytest-watch dependency to workaround an issue with watchdog. @rauchy -* #2905 Update development docker-compose.yml file to use latest Redis and Postgres servers and specify working volume explictly. @Rovel -* #3032 Makefile: Add make targets for test. @koooge -* #2933 Switch to Webpack 4. @dmonego -* #2908 Update setup files. @arikfr -* #2946 Update snowflake_connector_python version. @arikfr -* #2773 Upgrade to Celery 4.2.1. @emtwo, @jezdez -* #2881 CircleCI: Make flake8 tests pass on Legacy Python and Python 3. @cclauss -* #2907 Remove unused dependencies (honcho, wsgiref). @arikfr -* #3039 Build docker image on master branch. @arikfr -* #3106 Fix registerAll failures after minification. @arikfr - +- #2850 The setup scripts are now based on Ubuntu 18.04 LTS and Docker. @pashaxp, @arikfr +- #2985 Add Jest based tests to our stack. @arikfr +- #2999 Add netlify configuration. @arikfr +- #3000 Initial Cypress based E2E test infrastructure. @gabrieldutra +- #2898 Move Ant styles into a central location. @arikfr +- #2910 Fix webpack build error about BigMessage. @jezdez +- #2928 Speed up builds by skipping installing requirements_all_ds.txt in CI unit tests. @arikfr +- #2963 Fix tarball build failure. @emtwo +- #2996 Fix setup.sh failures when run as root. @arikfr +- #2989 Rearrange make targets. @koooge +- #3036 Update Flask-Admin to 1.5.2. @yoavbls +- #2901 Fix documentation links. @kravets-levko +- #3073 Remove only Redash containers in clean Make task. @ariarijp +- #3048 Remove pytest-watch dependency to workaround an issue with watchdog. @rauchy +- #2905 Update development docker-compose.yml file to use latest Redis and Postgres servers and specify working volume explictly. @Rovel +- #3032 Makefile: Add make targets for test. @koooge +- #2933 Switch to Webpack 4. @dmonego +- #2908 Update setup files. @arikfr +- #2946 Update snowflake_connector_python version. @arikfr +- #2773 Upgrade to Celery 4.2.1. @emtwo, @jezdez +- #2881 CircleCI: Make flake8 tests pass on Legacy Python and Python 3. @cclauss +- #2907 Remove unused dependencies (honcho, wsgiref). @arikfr +- #3039 Build docker image on master branch. @arikfr +- #3106 Fix registerAll failures after minification. @arikfr ## v5.0.2 - 2018-10-18 ### Security -* Fix: prevent Open Redirect vulnerability. - +- Fix: prevent Open Redirect vulnerability. ## v5.0.1 - 2018-09-27 ### Added -* Added support for JWT authentication (for services like Cloudflare Access or Google IAP). +- Added support for JWT authentication (for services like Cloudflare Access or Google IAP). ### Changed -* Upgraded Celery version to 3.1.26 to make upgrade to Celery 4 easier. - +- Upgraded Celery version to 3.1.26 to make upgrade to Celery 4 easier. ## v5.0.0 - 2018-09-21 Final release for V5. Most of the changes were already in the beta release of V5, but this includes several fixes along with UI improvements. - 🙏 Thanks to @arikfr, @jezdez, @kravets-levko, @alison985, @kocsmy, @yossi-a, @tdsmith, @nasmithan, @jrbenny35, @sjakthol, @ariarijp and @combineads who contributed to this release. - ### Security -* Fix: don't expose Google OAuth client secret. @arikfr +- Fix: don't expose Google OAuth client secret. @arikfr ### Changed -* Improve mobile rendering of dashboards and queries. @kocsmy -* UI improvements for favorites and empty state. @arikfr -* Remove unnecessary X at the end of the query search. @kocsmy -* Add server-side sorting to dashboard list. @jezdez -* Sort queries in descending order. @jezdez -* Throw error when non-owner tries to add a user to dashboard permissions. @alison985 -* Propagate query execution errors from Celery tasks properly. @alison985 -* Reload the route when using the app header search input. @jezdez +- Improve mobile rendering of dashboards and queries. @kocsmy +- UI improvements for favorites and empty state. @arikfr +- Remove unnecessary X at the end of the query search. @kocsmy +- Add server-side sorting to dashboard list. @jezdez +- Sort queries in descending order. @jezdez +- Throw error when non-owner tries to add a user to dashboard permissions. @alison985 +- Propagate query execution errors from Celery tasks properly. @alison985 +- Reload the route when using the app header search input. @jezdez ### Fixed -* Fix: BigQuery default location is null and not US. @arikfr -* Fix: query embeds are broken. @arikfr -* Fix: typo in Celery log foramt. @ariarijp -* Use QuerySerializer in outdated queries list. @jezdez -* Fix: sometimes widgets are getting zero height. @kravets-levko -* Athena: Switch to simple_json to serialize NaN/Infinity values as nulls. @kravets-levko, @jezdez -* Fix: queries with parameters with no value breaking the scheduler. @arikfr -* Fix: MongoDB query results parser didn't support unicode keys. @arikfr -* Fix: Google Analytics schema wasn't loading in some cases. @arikfr -* Fix: date/time parameters not working as global param @kravets-levko. -* Fix: Widgets crumble when trying to move / resize a widget. @kravets-levko -* Fix: handling rows with "length" field with forOwn method. @yossi-a -* Fix: query selection not working on alert page. @sjakthol -* Fix: query_results for Embedded Parameters (removed deprecated to_dict function). @nasmithan -* Fix: unicode not supported in dashboard search. @combineads -* Fix: unicode not supported in users search. @arikfr +- Fix: BigQuery default location is null and not US. @arikfr +- Fix: query embeds are broken. @arikfr +- Fix: typo in Celery log foramt. @ariarijp +- Use QuerySerializer in outdated queries list. @jezdez +- Fix: sometimes widgets are getting zero height. @kravets-levko +- Athena: Switch to simple_json to serialize NaN/Infinity values as nulls. @kravets-levko, @jezdez +- Fix: queries with parameters with no value breaking the scheduler. @arikfr +- Fix: MongoDB query results parser didn't support unicode keys. @arikfr +- Fix: Google Analytics schema wasn't loading in some cases. @arikfr +- Fix: date/time parameters not working as global param @kravets-levko. +- Fix: Widgets crumble when trying to move / resize a widget. @kravets-levko +- Fix: handling rows with "length" field with forOwn method. @yossi-a +- Fix: query selection not working on alert page. @sjakthol +- Fix: query_results for Embedded Parameters (removed deprecated to_dict function). @nasmithan +- Fix: unicode not supported in dashboard search. @combineads +- Fix: unicode not supported in users search. @arikfr ### Other -* Add test for using saved parameters in scheduled queries. @alison985 -* Minor code smell cleanup. @jezdez -* Update QueryResultListResource docstring. @tdsmith -* Switch to CirlceCI 2.0 @jrbenny35, @arikfr -* Remove unnecessary init methods. @jezdez - +- Add test for using saved parameters in scheduled queries. @alison985 +- Minor code smell cleanup. @jezdez +- Update QueryResultListResource docstring. @tdsmith +- Switch to CirlceCI 2.0 @jrbenny35, @arikfr +- Remove unnecessary init methods. @jezdez ## v5.0.0-Beta - 2018-08-06 @@ -284,19 +355,19 @@ This is the first beta of the V5 release (and hopefully the last one). This vers Some notable changes: -* Extensive work on parameters UI: - * New Date Range parameter type. - * UI for creating new parameters. - * Support for Now/Today as default value of date/time parameter. -* Tagging and favorites ⭐️ support for queries and dashboards. -* Users list page was improved (search, additional information) and you can now disable users. -* Query editor improvements: additional keyboard shortcuts and support for searching in query text. -* Visualizations improvements: option to select colors of pie chart sectors, X Axis type auto detect and option to format values, labels and tooltips. -* Data Sources: - * Support for Yandex Metrika and AppMetrika. - * BigQuery: location property support and schema will load all tables now. - * Elasticsearch: stop sending source_content_type parameter which wasn't supported in older versions. -* Started migrating the frontend codebase to React. +- Extensive work on parameters UI: + - New Date Range parameter type. + - UI for creating new parameters. + - Support for Now/Today as default value of date/time parameter. +- Tagging and favorites ⭐️ support for queries and dashboards. +- Users list page was improved (search, additional information) and you can now disable users. +- Query editor improvements: additional keyboard shortcuts and support for searching in query text. +- Visualizations improvements: option to select colors of pie chart sectors, X Axis type auto detect and option to format values, labels and tooltips. +- Data Sources: + - Support for Yandex Metrika and AppMetrika. + - BigQuery: location property support and schema will load all tables now. + - Elasticsearch: stop sending source_content_type parameter which wasn't supported in older versions. +- Started migrating the frontend codebase to React. And much more! @@ -304,82 +375,82 @@ And much more! ### Added -* #2712: Date/Time Range parameter type (@kravets-levko) -* #2482: Add support for ChatWork Alert Destination. (@matsumo) -* #2678: Explicit "Add Parameter" Button in Query Editor. (@kravets-levko) -* #2513: Add location property to BigQuery data source settings. (@kyoshidajp) -* #2616: Pie chart: support setting pie chart sector colors. (@kravets-levko) -* #2697: Date/Time parameters: support for "Now" as default value. (@kravets-levko) -* #2693: Enable search function in Query Editor. (@arikfr) -* #2573: Tagging and favorites for Queries and Dashboards (@arikfr) -* #2640: Keyboard shortcut to collapse query editor/schema browser (@kravets-levko) -* #2674: Add support for the Chrome Logger extension (@arikfr) -* #2653: Add redash db size to status page (@alison985) -* #2669: Store Athena query id with result metadata (@tdawber) -* #2546: Configuration for incorporating React components (@washort) -* #2533: New datasource: Yandex Metrika & AppMetrika (@denisov-vlad) -* #2536: Chart: formats for values, labels and tooltips (@kravets-levko) -* #2560: Introduce Policy object (@arikfr) -* #2380: Admin should be able to disable a user (@kravets-levko) -* #2509: Show custom date format on settings page (@kyoshidajp) +- #2712: Date/Time Range parameter type (@kravets-levko) +- #2482: Add support for ChatWork Alert Destination. (@matsumo) +- #2678: Explicit "Add Parameter" Button in Query Editor. (@kravets-levko) +- #2513: Add location property to BigQuery data source settings. (@kyoshidajp) +- #2616: Pie chart: support setting pie chart sector colors. (@kravets-levko) +- #2697: Date/Time parameters: support for "Now" as default value. (@kravets-levko) +- #2693: Enable search function in Query Editor. (@arikfr) +- #2573: Tagging and favorites for Queries and Dashboards (@arikfr) +- #2640: Keyboard shortcut to collapse query editor/schema browser (@kravets-levko) +- #2674: Add support for the Chrome Logger extension (@arikfr) +- #2653: Add redash db size to status page (@alison985) +- #2669: Store Athena query id with result metadata (@tdawber) +- #2546: Configuration for incorporating React components (@washort) +- #2533: New datasource: Yandex Metrika & AppMetrika (@denisov-vlad) +- #2536: Chart: formats for values, labels and tooltips (@kravets-levko) +- #2560: Introduce Policy object (@arikfr) +- #2380: Admin should be able to disable a user (@kravets-levko) +- #2509: Show custom date format on settings page (@kyoshidajp) ### Changed -* #2715: Improve users list page (@arikfr) -* #2710: Update Ant variables to fit Redash's style (@kocsmy) -* #2709: Move format button next Add New Param button. (@arikfr) -* #2664: Dashboard shows a spinner when query failed to load (@kravets-levko) -* #2626: Show real status when loading cached query result (@kravets-levko) -* #2663: Set column name implicitly when column name is blank (@ariarijp) -* #2695: Improve Date/DateTime type parameters (@kravets-levko) -* #2694: Block users with disposable email addresses (@arikfr) -* #2687: YAML: changed load to safe_load (@denisov-vlad) -* #2514: Update value parsing for google spreadsheets source (@atharvai) -* #2570: fixes query pagination alignment (@alison985) -* #2584: keep query result pagination out of scroll (@alison985) -* #2647: Improve Script Query Runner (@ariarijp) -* #2583: Query header improvements on widgets (@kocsmy) -* #2671: Save some space (@kocsmy) -* #2658: delaying schema filtering to improve responsiveness (@alison985) -* #2648: Update datasource documentation links (@Pablohn26) -* #2613: Improve Script Query Runner (@ariarijp) -* #2619: data source sort case insensitive (@alison985) -* #2604: Improve Google Spreadsheets Query Runner (@ariarijp) -* #2542: Closes #2541: x-axis improvements. (@emtwo) -* #2590: Remove redundant variables (@ariarijp) -* #2585: Show data only mode: allow to add and delete visualizations (@kravets-levko) -* #2549: Allow get_tables to see views and v10-style partitioned tables (@coreyhuinker) -* #2568: sort datasources alphabetically (@alison985) -* #2444: feat: show error if saml response cannot be parsed (@sjakthol) -* #2554: Display name to be delete (@kyoshidajp) -* #2510: Display confirmation dialog when deleting a item (@kyoshidajp) -* #2518: Design improvements (@kocsmy) -* #2520: Filter data sources in a data source input area (@kyoshidajp) +- #2715: Improve users list page (@arikfr) +- #2710: Update Ant variables to fit Redash's style (@kocsmy) +- #2709: Move format button next Add New Param button. (@arikfr) +- #2664: Dashboard shows a spinner when query failed to load (@kravets-levko) +- #2626: Show real status when loading cached query result (@kravets-levko) +- #2663: Set column name implicitly when column name is blank (@ariarijp) +- #2695: Improve Date/DateTime type parameters (@kravets-levko) +- #2694: Block users with disposable email addresses (@arikfr) +- #2687: YAML: changed load to safe_load (@denisov-vlad) +- #2514: Update value parsing for google spreadsheets source (@atharvai) +- #2570: fixes query pagination alignment (@alison985) +- #2584: keep query result pagination out of scroll (@alison985) +- #2647: Improve Script Query Runner (@ariarijp) +- #2583: Query header improvements on widgets (@kocsmy) +- #2671: Save some space (@kocsmy) +- #2658: delaying schema filtering to improve responsiveness (@alison985) +- #2648: Update datasource documentation links (@Pablohn26) +- #2613: Improve Script Query Runner (@ariarijp) +- #2619: data source sort case insensitive (@alison985) +- #2604: Improve Google Spreadsheets Query Runner (@ariarijp) +- #2542: Closes #2541: x-axis improvements. (@emtwo) +- #2590: Remove redundant variables (@ariarijp) +- #2585: Show data only mode: allow to add and delete visualizations (@kravets-levko) +- #2549: Allow get_tables to see views and v10-style partitioned tables (@coreyhuinker) +- #2568: sort datasources alphabetically (@alison985) +- #2444: feat: show error if saml response cannot be parsed (@sjakthol) +- #2554: Display name to be delete (@kyoshidajp) +- #2510: Display confirmation dialog when deleting a item (@kyoshidajp) +- #2518: Design improvements (@kocsmy) +- #2520: Filter data sources in a data source input area (@kyoshidajp) ### Fixed -* #2722: Elasticsearch: Don't send source_content_type parameter. (@arikfr) -* #2719: Remove closing input tags (@maxv) -* #2458: Get all tables in the BigQuery (@kyoshidajp) -* #2698: Make sure we return distinct data source values (@arikfr) -* #2315: Fix: pyHive type matches (@yuua) -* #2638: Dashboard stops rendering when adding widget with empty query (@kravets-levko) -* #2610: Fix export query results output file name (@gabrieldutra) -* #2574: commit query result to db before evaluating alerts (@mtrbean) -* #2580: add break-word wrap to add/edit text box on dashboard (@alison985) -* #2578: Fix connection error when you run "create_tables" (@ariarijp) -* #2572: remove extra menu line if query is archived (@alison985) -* #2526: Fix pivot hide control in dashboards (@deecay) -* #2511: Fixing signed_out.html template (@kocsmy) -* #2523: Frontend: fix boolean field with null value display as null. (@innovia) +- #2722: Elasticsearch: Don't send source_content_type parameter. (@arikfr) +- #2719: Remove closing input tags (@maxv) +- #2458: Get all tables in the BigQuery (@kyoshidajp) +- #2698: Make sure we return distinct data source values (@arikfr) +- #2315: Fix: pyHive type matches (@yuua) +- #2638: Dashboard stops rendering when adding widget with empty query (@kravets-levko) +- #2610: Fix export query results output file name (@gabrieldutra) +- #2574: commit query result to db before evaluating alerts (@mtrbean) +- #2580: add break-word wrap to add/edit text box on dashboard (@alison985) +- #2578: Fix connection error when you run "create_tables" (@ariarijp) +- #2572: remove extra menu line if query is archived (@alison985) +- #2526: Fix pivot hide control in dashboards (@deecay) +- #2511: Fixing signed_out.html template (@kocsmy) +- #2523: Frontend: fix boolean field with null value display as null. (@innovia) ### Other -* #2682: Add Zeit's now support to have preview builds for every PR (@arikfr) -* #2668: Upgrade bootstrap script to Redash 4.0.1 (@ariarijp) -* #2639: Add tests for SpreadSheets (@ariarijp) -* #2635: Add tests for Query Results (@ariarijp) -* #2537: Remove trailing semicolon (@sieben) +- #2682: Add Zeit's now support to have preview builds for every PR (@arikfr) +- #2668: Upgrade bootstrap script to Redash 4.0.1 (@ariarijp) +- #2639: Add tests for SpreadSheets (@ariarijp) +- #2635: Add tests for Query Results (@ariarijp) +- #2537: Remove trailing semicolon (@sieben) ## v4.0.1 - 2018-05-02 @@ -571,7 +642,6 @@ And much more! - Handling whitespace characters in Query Results data source. @ariarijp - [MySQL] Close cursor when cancellig the query. @jasonsmithj - ## v3.0.0 - 2017-11-13 ### Added @@ -617,7 +687,7 @@ And much more! - Salesforce: improve error messages we receive from the API. @akiray03 - Custom JS code visualization improvements. @deecay - DQL: Update version to 0.5.24. @aterreno -- Cassandra: get_schema support for both C* 2.x and 3.x, support for SortedSet type serialization. (@mfouilleul)) +- Cassandra: get_schema support for both C\* 2.x and 3.x, support for SortedSet type serialization. (@mfouilleul)) - Replace deprecated ng-annotate with babel plugin. @44px - Update Python dependencies to recent versions. @alison985 - Bootstrap script: create /opt/redash directory only if it doesn't exist. @isomura @@ -653,7 +723,6 @@ And much more! This is a patch release, that adds support for Redshift ACM certificates (see #2044 for details). - ## v2.0.0 - 2017-08-08 ### Added @@ -663,7 +732,7 @@ This is a patch release, that adds support for Redshift ACM certificates (see #2 - Add the propertyOrder field to specify order of data source settings. @rmakulov - Add Plotly based Boxplot visualization. @deecay - [Presto] Add: query cancellation support. @fbertsch -- [MongoDB] add $oids JSON extension. +- [MongoDB] add \$oids JSON extension. - [PostgreSQL] support for loading materialized views in schema. - [MySQL] Add option to hide SSL settings. - [MySQL] support for RDS MySQL and SSL. @@ -733,7 +802,7 @@ This is a patch release, that adds support for Redshift ACM certificates (see #2 - [Google Spreadsheets] handle distant future dates. - [SQLite] better handle utf-8 error messages. - Fix: don't remove locks for queries with task status of PENDING. -- Only split columns with __/:: that end with filter/MultiFilter. +- Only split columns with \_\_/:: that end with filter/MultiFilter. - Alert notifications fail (sometime) with a SQLAlchemy error. - Safeguard against empty query results when checking alert status. @danielerapati - Delete data source doesn't work when query results referenced by queries. @@ -752,7 +821,6 @@ This is a patch release, that adds support for Redshift ACM certificates (see #2 - PostgreSQL passwords with spaces were not supported. (#1056) - PivotTable wasn't updating after first save. - ## v1.0.3 - 2017-04-18 ### Fixed @@ -799,7 +867,7 @@ This is a patch release, that adds support for Redshift ACM certificates (see #2 - Fix: query embed dialog close button wasn't working @r0fls - Fix: make errors from Presto runner JSON-serializable @washort - Fix: race condition in query task status reporting @washort -- Fix: remove $$hashKey from Pivot table +- Fix: remove \$\$hashKey from Pivot table - Fix: map visualization had severe performance issue. - Fix: pemrission dialog wasn't rendering. - Fix: word cloud visualization didn't show column names. @@ -816,7 +884,7 @@ This is a patch release, that adds support for Redshift ACM certificates (see #2 ### Changed - [#1563](https://github.com/getredash/redash/pull/1563) Send events to webhook as JSON with a schema. -- [#1601] [Presto] friendlier error messages. (@aslotnick) +- [#1601][presto] friendlier error messages. (@aslotnick) - Move the query runner unavailable log message to be DEBUG level instead of WARNING, as it was mainly confusing people. - Remove "Send to Cloud" button from Plotly based visualizations. - Change Plotly's default hover mode to "Compare". @@ -825,7 +893,7 @@ This is a patch release, that adds support for Redshift ACM certificates (see #2 ### Fixed - [#1564] Fix: map visualization column picker wasn't populated. (@janusd) -- [#1597] [SQL Server] Fix: schema wasn't loading on case sensitive servers. (@deecay) +- [#1597][sql server] Fix: schema wasn't loading on case sensitive servers. (@deecay) - Fix: dashbonard owner couldn't edit his dashboard. - Fix: toggle_publish event wasn't logged properly. - Fix: events with API keys were not logged. @@ -840,7 +908,7 @@ This is a patch release, that adds support for Redshift ACM certificates (see #2 - Fix: extra whitespace created by the filters component. - Fix: query results cleanup task was trying to delete query objects. - Fix: alert subscriptions were not triggered. -- [DynamoDB] Fix: count(*) queries were broken. (@kopanitsa)) +- [DynamoDB] Fix: count(\*) queries were broken. (@kopanitsa)) - Fix: Redash is using too many database connections. - Fix: download links were not working in dashboards. - Fix: the first selection in multi filters was broken in dashboards. @@ -857,9 +925,9 @@ This is a patch release, that adds support for Redshift ACM certificates (see #2 This version has two big changes behind the scenes: -* Refactor the frontend to use latest (at the time) Angular version (1.5) along with better frontend pipeline based on) +- Refactor the frontend to use latest (at the time) Angular version (1.5) along with better frontend pipeline based on) WebPack. -* Refactor the backend code to use SQLAlchemy and Alembic, for easier migrations/upgrades.) +- Refactor the backend code to use SQLAlchemy and Alembic, for easier migrations/upgrades.) Along with that we have many fixes, additions, new data sources (Google Analytics, ClickHouse, Amazon Athena, Snowflake) and fixes to the existing ones (mainly ElasticSearch and Cassandra). @@ -942,7 +1010,7 @@ We're releasing a new upgrade script -- see [here](https://redash.io/help-onprem ### Added -- 61fe16e #1374: Add: allow '*' in REDASH_CORS_ACCESS_CONTROL_ALLOW_ORIGIN (Allen Short) +- 61fe16e #1374: Add: allow '\*' in REDASH_CORS_ACCESS_CONTROL_ALLOW_ORIGIN (Allen Short) - 2f09043 #1113: Add: share modify/access permissions for queries and dashboard (whummer) - 3db0eea #1341: Add: support for specifying SAML nameid-format (zoetrope) - b0ecd0e #1343: Add: support for local SAML metadata file (zoetrope) @@ -1006,7 +1074,6 @@ We're releasing a new upgrade script -- see [here](https://redash.io/help-onprem - 5d43cbe #1198: Change: add support for Standard SQL in BigQuery query runner (mystelynx) - 84d0c22 #1193: Change: modify the argument order of moment.add function call (Kenya Yamaguchi) - ### Fixed - d6febb0 #1375: Fix: Download Dataset does not work when not logged in (Joshua Dechant) @@ -1060,7 +1127,7 @@ The main features of this release are: Also, this release includes numerous smaller features, improvements, and bug fixes. -A big thank you goes to all who contributed code and documentation in this release: @AntoineAugusti, @James226, @adamlwgriffiths, @alexdebrie, @anthony-coble, @ariarijp, @dheerajrav, @edwardsharp, @machira, @nabilblk, @ninneko, @ordd, @tomerben, @toru-takahashi, @vishesh92, @vorakumar and @whummer. +A big thank you goes to all who contributed code and documentation in this release: @AntoineAugusti, @James226, @adamlwgriffiths, @alexdebrie, @anthony-coble, @ariarijp, @dheerajrav, @edwardsharp, @machira, @nabilblk, @ninneko, @ordd, @tomerben, @toru-takahashi, @vishesh92, @vorakumar and @whummer. ### Added @@ -1075,7 +1142,7 @@ A big thank you goes to all who contributed code and documentation in this relea - f64622d #1089: Add support for serialising UUID type within MSSQL #961 (@James226) - 857caab #1085: Feature: API to pause a data source (@arikfr) - 214aa3b #1060: Feature: support configuring user's groups with SAML (@vorakumar) -- e20a005 #1007: Issue#1006: Make bottom margin editable for Chart visualization (@vorakumar) +- e20a005 #1007: Issue#1006: Make bottom margin editable for Chart visualization (@vorakumar) - 6e0dd2b #1063: Add support for date/time Y axis (@tomerben) - b5a4a6b #979: Feature: Add CLI to edit group permissions (@ninneko) - 6d495d2 #1014: Add server-side parameter handling for embeds (@whummer) @@ -1121,7 +1188,7 @@ A big thank you goes to all who contributed code and documentation in this relea - e10ecd2 #1058: Bring back filters if dashboard filters are enabled (@AntoineAugusti) - 701035f #1059: Fix: DynamoDB having issues when setting host (@arikfr) - 2924d4f #1040: Small fixes to visualizations view (@arikfr) -- fec0d5f #1037: Fix: multi filter wasn't working with __ syntax (@dheerajrav) +- fec0d5f #1037: Fix: multi filter wasn't working with \_\_ syntax (@dheerajrav) - b066ce4 #1033: Fix: only ask for notification permissions if wasn't denied (@arikfr) - 960c416 #1032: Fix: make sure we return dashboards only for current org only (@arikfr) - b3844d3 #1029: Hive: close connection only if it exists (@arikfr) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1288782f5f..8bd64799b9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,6 @@ The following is a set of guidelines for contributing to Redash. These are guide ## Quick Links: -- [Feature Roadmap](https://trello.com/b/b2LUHU7A/redash-roadmap) - [Feature Requests](https://discuss.redash.io/c/feature-requests) - [Documentation](https://redash.io/help/) - [Blog](https://blog.redash.io/) @@ -61,7 +60,7 @@ If you would like to suggest an enhancement or ask for a new feature: ### Documentation -The project's documentation can be found at [https://redash.io/help/](https://redash.io/help/). The [documentation sources](https://github.com/getredash/website/tree/master/website/_kb) are hosted on GitHub. To contribute edits / new pages, you can use GitHub's interface. Click the "Edit on GitHub" link on the documentation page to quickly open the edit interface. +The project's documentation can be found at [https://redash.io/help/](https://redash.io/help/). The [documentation sources](https://github.com/getredash/website/tree/master/src/pages/kb) are hosted on GitHub. To contribute edits / new pages, you can use GitHub's interface. Click the "Edit on GitHub" link on the documentation page to quickly open the edit interface. ## Additional Notes diff --git a/Dockerfile b/Dockerfile index 5176e7df46..4484bd4037 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,3 +1,12 @@ +FROM node:10 as frontend-builder + +WORKDIR /frontend +COPY package.json package-lock.json /frontend/ +RUN npm install + +COPY . /frontend +RUN npm run build + FROM redash/base:latest # Controls whether to install extra dependencies needed for all data sources. @@ -9,12 +18,12 @@ COPY requirements.txt requirements_dev.txt requirements_all_ds.txt ./ RUN pip install -r requirements.txt -r requirements_dev.txt RUN if [ "x$skip_ds_deps" = "x" ] ; then pip install -r requirements_all_ds.txt ; else echo "Skipping pip install -r requirements_all_ds.txt" ; fi -COPY . ./ -RUN npm install && npm run bundle && npm run build && rm -rf node_modules +COPY . /app +COPY --from=frontend-builder /frontend/client/dist /app/client/dist RUN chown -R redash /app USER redash -EXPOSE 5000 - ENTRYPOINT ["/app/bin/docker-entrypoint"] CMD ["server"] + +EXPOSE 5000 diff --git a/LICENSE b/LICENSE index 36e13c08e0..ee7059ab36 100644 --- a/LICENSE +++ b/LICENSE @@ -1,4 +1,4 @@ -Copyright (c) 2013-2018, Arik Fraimovich. +Copyright (c) 2013-2019, Arik Fraimovich. All rights reserved. Redistribution and use in source and binary forms, with or without modification, diff --git a/Makefile b/Makefile index d13ecacf31..19a146fa49 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -.PHONY: compose_build up test_db create_database clean down bundle tests lint backend-unit-tests frontend-unit-tests test build watch start +.PHONY: compose_build up test_db create_database clean down bundle tests lint backend-unit-tests frontend-unit-tests test build watch start redis-cli bash compose_build: docker-compose build @@ -49,3 +49,9 @@ watch: bundle start: bundle npm run start + +redis-cli: + docker-compose run --rm redis redis-cli -h redis + +bash: + docker-compose run --rm server bash diff --git a/bin/docker-entrypoint b/bin/docker-entrypoint index 0d45eb5482..c7d0e473b6 100755 --- a/bin/docker-entrypoint +++ b/bin/docker-entrypoint @@ -3,7 +3,7 @@ set -e worker() { WORKERS_COUNT=${WORKERS_COUNT:-2} - QUEUES=${QUEUES:-queries,scheduled_queries,celery} + QUEUES=${QUEUES:-queries,scheduled_queries,celery,schemas} echo "Starting $WORKERS_COUNT workers for queues: $QUEUES..." exec /usr/local/bin/celery worker --app=redash.worker -c$WORKERS_COUNT -Q$QUEUES -linfo --maxtasksperchild=10 -Ofair @@ -12,10 +12,11 @@ worker() { scheduler() { WORKERS_COUNT=${WORKERS_COUNT:-1} QUEUES=${QUEUES:-celery} + SCHEDULE_DB=${SCHEDULE_DB:-celerybeat-schedule} echo "Starting scheduler and $WORKERS_COUNT workers for queues: $QUEUES..." - exec /usr/local/bin/celery worker --app=redash.worker --beat -c$WORKERS_COUNT -Q$QUEUES -linfo --maxtasksperchild=10 -Ofair + exec /usr/local/bin/celery worker --app=redash.worker --beat -s$SCHEDULE_DB -c$WORKERS_COUNT -Q$QUEUES -linfo --maxtasksperchild=10 -Ofair } server() { @@ -26,6 +27,10 @@ create_db() { exec /app/manage.py database create_tables } +celery_healthcheck() { + exec /usr/local/bin/celery inspect ping --app=redash.worker -d celery@$HOSTNAME +} + help() { echo "Redash Docker." echo "" @@ -35,9 +40,11 @@ help() { echo "server -- start Redash server (with gunicorn)" echo "worker -- start Celery worker" echo "scheduler -- start Celery worker with a beat (scheduler) process" + echo "celery_healthcheck -- runs a Celery healthcheck. Useful for Docker's HEALTHCHECK mechanism." echo "" echo "shell -- open shell" echo "dev_server -- start Flask development server with debugger and auto reload" + echo "debug -- start Flask development server with remote debugger via ptvsd" echo "create_db -- create database tables" echo "manage -- CLI to manage redash" echo "tests -- run tests" @@ -71,6 +78,11 @@ case "$1" in export FLASK_DEBUG=1 exec /app/manage.py runserver --debugger --reload -h 0.0.0.0 ;; + debug) + export FLASK_DEBUG=1 + export REMOTE_DEBUG=1 + exec /app/manage.py runserver --debugger --no-reload -h 0.0.0.0 + ;; shell) exec /app/manage.py shell ;; diff --git a/client/.babelrc b/client/.babelrc index a6ae74fe1d..7ba3d2057b 100644 --- a/client/.babelrc +++ b/client/.babelrc @@ -1,8 +1,15 @@ { - "presets": ["env", "react", "stage-2"], + "presets": [ + ["@babel/preset-env", { + "targets": "> 0.5%, last 2 versions, Firefox ESR, ie 11, not dead", + "useBuiltIns": "usage" + }], + "@babel/preset-react" + ], "plugins": [ "angularjs-annotate", - "transform-object-assign", + "@babel/plugin-proposal-class-properties", + "@babel/plugin-transform-object-assign", ["babel-plugin-transform-builtin-extend", { "globals": ["Error"] }] diff --git a/client/.eslintrc.js b/client/.eslintrc.js index 10fae2b4c6..73caba79e3 100644 --- a/client/.eslintrc.js +++ b/client/.eslintrc.js @@ -18,6 +18,7 @@ module.exports = { 'no-param-reassign': 0, 'no-mixed-operators': 0, 'no-underscore-dangle': 0, + "no-use-before-define": ["error", "nofunc"], "prefer-destructuring": "off", "prefer-template": "off", "no-restricted-properties": "off", @@ -26,19 +27,34 @@ module.exports = { "no-lonely-if": "off", "consistent-return": "off", "no-control-regex": "off", + 'no-multiple-empty-lines': 'warn', + "no-script-url": "off", // some tags should have href="javascript:void(0)" + 'operator-linebreak': 'off', + 'react/destructuring-assignment': 'off', "react/jsx-filename-extension": "off", + 'react/jsx-one-expression-per-line': 'off', "react/jsx-uses-react": "error", "react/jsx-uses-vars": "error", + 'react/jsx-wrap-multilines': 'warn', + 'react/no-access-state-in-setstate': 'warn', "react/prefer-stateless-function": "warn", "react/forbid-prop-types": "warn", "react/prop-types": "warn", "jsx-a11y/anchor-is-valid": "off", + "jsx-a11y/click-events-have-key-events": "off", + "jsx-a11y/label-has-associated-control": ["warn", { + "controlComponents": true + }], + "jsx-a11y/label-has-for": "off", + "jsx-a11y/no-static-element-interactions": "off", "max-len": ['error', 120, 2, { ignoreUrls: true, ignoreComments: false, ignoreRegExpLiterals: true, ignoreStrings: true, ignoreTemplateLiterals: true, - }] + }], + "no-else-return": ["error", {"allowElseIf": true}], + "object-curly-newline": ["error", {"consistent": true}], } }; diff --git a/client/app/__tests__/enzyme_setup.js b/client/app/__tests__/enzyme_setup.js new file mode 100644 index 0000000000..82edfc9e5a --- /dev/null +++ b/client/app/__tests__/enzyme_setup.js @@ -0,0 +1,4 @@ +import { configure } from 'enzyme'; +import Adapter from 'enzyme-adapter-react-16'; + +configure({ adapter: new Adapter() }); diff --git a/client/app/__tests__/mocks.js b/client/app/__tests__/mocks.js new file mode 100644 index 0000000000..14fccbe90b --- /dev/null +++ b/client/app/__tests__/mocks.js @@ -0,0 +1,5 @@ +import MockDate from 'mockdate'; + +const date = new Date('2000-01-01T02:00:00.000'); + +MockDate.set(date); diff --git a/client/app/assets/images/db-logos/aws_es.png b/client/app/assets/images/db-logos/aws_es.png new file mode 100644 index 0000000000..cbf84873f3 Binary files /dev/null and b/client/app/assets/images/db-logos/aws_es.png differ diff --git a/client/app/assets/images/db-logos/drill.png b/client/app/assets/images/db-logos/drill.png new file mode 100644 index 0000000000..a19d9385f6 Binary files /dev/null and b/client/app/assets/images/db-logos/drill.png differ diff --git a/client/app/assets/images/db-logos/uptycs.png b/client/app/assets/images/db-logos/uptycs.png new file mode 100644 index 0000000000..3f9ead8785 Binary files /dev/null and b/client/app/assets/images/db-logos/uptycs.png differ diff --git a/client/app/assets/images/destinations/hangouts_chat.png b/client/app/assets/images/destinations/hangouts_chat.png new file mode 100644 index 0000000000..ef934b0a2c Binary files /dev/null and b/client/app/assets/images/destinations/hangouts_chat.png differ diff --git a/client/app/assets/images/destinations/slack.png b/client/app/assets/images/destinations/slack.png index 857731a518..39c62a6e9d 100644 Binary files a/client/app/assets/images/destinations/slack.png and b/client/app/assets/images/destinations/slack.png differ diff --git a/client/app/assets/less/ant.less b/client/app/assets/less/ant.less new file mode 100644 index 0000000000..c42a83e2a7 --- /dev/null +++ b/client/app/assets/less/ant.less @@ -0,0 +1,249 @@ +@import '~antd/lib/style/core/iconfont'; +@import '~antd/lib/style/core/motion'; +@import '~antd/lib/alert/style/index'; +@import '~antd/lib/input/style/index'; +@import '~antd/lib/input-number/style/index'; +@import '~antd/lib/date-picker/style/index'; +@import '~antd/lib/modal/style/index'; +@import '~antd/lib/tooltip/style/index'; +@import '~antd/lib/select/style/index'; +@import '~antd/lib/checkbox/style/index'; +@import '~antd/lib/upload/style/index'; +@import '~antd/lib/form/style/index'; +@import '~antd/lib/button/style/index'; +@import '~antd/lib/radio/style/index'; +@import '~antd/lib/time-picker/style/index'; +@import '~antd/lib/pagination/style/index'; +@import '~antd/lib/table/style/index'; +@import '~antd/lib/popover/style/index'; +@import '~antd/lib/icon/style/index'; +@import '~antd/lib/tag/style/index'; +@import '~antd/lib/grid/style/index'; +@import '~antd/lib/switch/style/index'; +@import '~antd/lib/drawer/style/index'; +@import '~antd/lib/divider/style/index'; +@import '~antd/lib/dropdown/style/index'; +@import '~antd/lib/menu/style/index'; +@import '~antd/lib/list/style/index'; +@import "~antd/lib/badge/style/index"; +@import "~antd/lib/card/style/index"; +@import "~antd/lib/spin/style/index"; +@import "~antd/lib/tabs/style/index"; +@import 'inc/ant-variables'; + +// Remove bold in labels for Ant checkboxes and radio buttons +.ant-checkbox-wrapper, +.ant-radio-wrapper { + font-weight: normal; +} + +// Fix for disabled button styles inside Tooltip component. +// Tooltip wraps disabled buttons with `` and moves all styles +// and classes to that ``. This resets all button styles and +// turns it into simple inline element (because now it's wrapper is a button) +.btn { + button[disabled] { + -moz-appearance: none !important; + -webkit-appearance: none !important; + appearance: none !important; + border: 0 !important; + outline: none !important; + background: transparent !important; + margin: 0 !important; + padding: 0 !important; + } +} + +// Fix for Ant dropdowns when they are used in Boootstrap modals +.ant-dropdown-in-bootstrap-modal { + z-index: 1050; +} + +// Button overrides +.@{btn-prefix-cls} { + transition-duration: 150ms; +} + +// Fix ant input number showing duplicate arrows +.ant-input-number-input::-webkit-outer-spin-button, +.ant-input-number-input::-webkit-inner-spin-button { + -webkit-appearance: none; + margin: 0; +} + +// Pagination overrides (based on existing Bootstrap overrides) +.@{pagination-prefix-cls} { + display: inline-block; + margin-top: 18px; + margin-bottom: 18px; + vertical-align: top; + + &-item { + background-color: @pagination-bg; + border-color: transparent; + color: @pagination-color; + font-size: 14px; + margin-right: 5px; + + a { + color: inherit; + } + + &:focus, + &:hover { + background-color: @pagination-hover-bg; + border-color: transparent; + color: @pagination-hover-color; + a { + color: inherit; + } + } + + &-active { + &, + &:hover, + &:focus { + background-color: @pagination-active-bg; + color: @pagination-active-color; + border-color: transparent; + pointer-events: none; + cursor: default; + + a { + color: inherit; + } + } + } + } + + &-disabled { + &, + &:hover, + &:focus { + opacity: 0.5; + pointer-events: none; + } + } + + &-prev, + &-next { + .@{pagination-prefix-cls}-item-link { + background-color: @pagination-bg; + border-color: transparent; + color: @pagination-color; + line-height: @pagination-item-size - 2px; + } + + &:focus .@{pagination-prefix-cls}-item-link, + &:hover .@{pagination-prefix-cls}-item-link { + background-color: @pagination-hover-bg; + border-color: transparent; + color: @pagination-hover-color; + } + } + + &-prev, + &-jump-prev, + &-jump-next { + margin-right: 5px; + } + + &-jump-prev, + &-jump-next { + .@{pagination-prefix-cls}-item-container { + .@{pagination-prefix-cls}-item-link-icon { + color: @pagination-color; + } + } + } +} + +// Table + +.@{table-prefix-cls} { + color: inherit; + + tr, + th, + td { + transition: none !important; + } + + &-thead > tr > th { + padding: @table-padding-vertical * 2 @table-padding-horizontal; + } + + .@{table-prefix-cls}-column-sorters { + &:before, + &:hover:before { + content: none; + } + } + + &-thead > tr > th { + .@{table-prefix-cls}-column-sorter { + &-up, + &-down { + &.on { + color: @table-header-icon-active-color; + } + } + } + } + + // Custom styles + + &-headerless &-tbody > tr:first-child > td { + border-top: @border-width-base @border-style-base @border-color-split; + } +} + +// List + +.@{list-prefix-cls} { + &-item { + // custom rule + &.selected { + background-color: #F6F8F9; + } + + &.disabled { + background-color: fade(#F6F8F9, 40%); + + & > * { + opacity: 0.4; + } + } + } +} + +// styling for short modals (no lines) +.@{dialog-prefix-cls}.shortModal { + .@{dialog-prefix-cls} { + &-header, + &-footer { + border: none; + padding: 16px; + } + &-body { + padding: 10px 16px; + } + &-close-x { + width: 46px; + height: 46px; + line-height: 46px; + } + } +} + +// description in modal header +.modal-header-desc { + font-size: @font-size-base; + color: @text-color-secondary; + font-weight: normal; + margin-top: 4px; +} + +.ant-popover { + z-index: 1000; // make sure it doesn't cover drawer +} diff --git a/client/app/assets/less/inc/ant-variables.less b/client/app/assets/less/inc/ant-variables.less new file mode 100644 index 0000000000..4e86e0b8b2 --- /dev/null +++ b/client/app/assets/less/inc/ant-variables.less @@ -0,0 +1,74 @@ +/* -------------------------------------------------------- + Colors +-----------------------------------------------------------*/ +@lightblue: #03A9F4; +@primary-color: #2196F3; + +@redash-gray: rgba(102, 136, 153, 1); +@redash-orange: rgba(255, 120, 100, 1); +@redash-black: rgba(0, 0, 0, 1); +@redash-yellow: rgba(252, 252, 161, 0.75); + +/* -------------------------------------------------------- + Font +-----------------------------------------------------------*/ +@redash-font: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif; +@font-family-no-number: @redash-font; +@font-family: @redash-font; +@code-family: @redash-font; +@font-size-base: 13px; + + +/* -------------------------------------------------------- + Typograpgy +-----------------------------------------------------------*/ +@text-color: #595959; + + +/* -------------------------------------------------------- + Form +-----------------------------------------------------------*/ +@input-height-base: 35px; +@input-color: #595959; +@border-radius-base: 2px; +@border-color-base: #E8E8E8; + + +/* -------------------------------------------------------- + Button +-----------------------------------------------------------*/ +@btn-danger-bg: fade(@redash-gray, 10%); +@btn-danger-border: fade(@redash-gray, 15%); + + +/* -------------------------------------------------------- + Pagination +-----------------------------------------------------------*/ +@pagination-item-size: 33px; +@pagination-font-family: @redash-font; +@pagination-font-weight-active: normal; + +@pagination-bg: fade(@redash-gray, 15%); +@pagination-color: #7E7E7E; +@pagination-active-bg: @lightblue; +@pagination-active-color: #FFF; +@pagination-disabled-bg: fade(@redash-gray, 15%); +@pagination-hover-color: #333; +@pagination-hover-bg: fade(@redash-gray, 25%); + + +/* -------------------------------------------------------- + Table +-----------------------------------------------------------*/ +@table-border-radius-base: 0; +@table-header-color: #333; +@table-header-bg: fade(@redash-gray, 3%); +@table-header-icon-color: fade(@text-color, 20%); +@table-header-icon-active-color: @text-color; +@table-header-sort-bg: @table-header-bg; +@table-header-sort-active-bg: @table-header-bg; +@table-header-filter-active-bg: @table-header-bg; +@table-body-sort-bg: transparent; +@table-row-hover-bg: fade(@redash-gray, 5%); +@table-padding-vertical: 7px; +@table-padding-horizontal: 10px; diff --git a/client/app/assets/less/inc/base.less b/client/app/assets/less/inc/base.less index c3642b6526..46865650a9 100755 --- a/client/app/assets/less/inc/base.less +++ b/client/app/assets/less/inc/base.less @@ -73,6 +73,10 @@ strong { } +.clickable { + cursor: pointer; +} + .resize-vertical { resize: vertical !important; transition: height 0s !important; diff --git a/client/app/assets/less/inc/generics.less b/client/app/assets/less/inc/generics.less index da230213de..0ad99bd54e 100755 --- a/client/app/assets/less/inc/generics.less +++ b/client/app/assets/less/inc/generics.less @@ -146,6 +146,8 @@ Width -----------------------------------------------------------*/ .w-100 { width: 100% !important; } +.w-50 { width: 50% !important; } +.w-25 { width: 25% !important; } /* -------------------------------------------------------- diff --git a/client/app/assets/less/inc/navbar.less b/client/app/assets/less/inc/navbar.less index 038daa1d0e..c65b309b66 100755 --- a/client/app/assets/less/inc/navbar.less +++ b/client/app/assets/less/inc/navbar.less @@ -1,6 +1,5 @@ a.navbar-brand { padding: 5px 5px 0px 0px; - margin-left: 0px !important; } .navbar .fa { diff --git a/client/app/assets/less/inc/variables.less b/client/app/assets/less/inc/variables.less index 0a3fae6fbd..f93cf25226 100755 --- a/client/app/assets/less/inc/variables.less +++ b/client/app/assets/less/inc/variables.less @@ -55,6 +55,7 @@ /* -------------------------------------------------------- Form -----------------------------------------------------------*/ +@input-color: #595959; @input-color-placeholder: #b4b4b4; @input-border: #e8e8e8; @input-border-radius: 0; @@ -98,7 +99,6 @@ @state-success-text: @green; @state-info-text: @blue; @state-danger-text: lighten(@red, 5%); -@state-warning-text: @orange; /* -------------------------------------------------------- @@ -106,19 +106,16 @@ -----------------------------------------------------------*/ @alert-success-border: transparent; @alert-info-border: transparent; -@alert-warning-border: transparent; @alert-danger-border: transparent; @alert-inverse-border: transparent; @alert-success-bg: fade(@green, 70%); @alert-info-bg: fade(@blue, 70%); -@alert-warning-bg: fade(@amber, 70%); @alert-danger-bg: fade(@red, 70%); @alert-inverse-bg: #333; @alert-success-text: #fff; @alert-info-text: #fff; -@alert-warning-text: #fff; @alert-danger-text: #fff; @alert-inverse-text: #fff; diff --git a/client/app/assets/less/inc/visualizations/misc.less b/client/app/assets/less/inc/visualizations/misc.less index a01778d59c..d439837db0 100644 --- a/client/app/assets/less/inc/visualizations/misc.less +++ b/client/app/assets/less/inc/visualizations/misc.less @@ -1,3 +1,6 @@ -visualization-renderer .pagination { - margin: 0; +visualization-renderer { + .pagination, + .ant-pagination { + margin: 0; + } } diff --git a/client/app/assets/less/main.less b/client/app/assets/less/main.less index db3d55c294..8a6ba78c19 100644 --- a/client/app/assets/less/main.less +++ b/client/app/assets/less/main.less @@ -1,5 +1,3 @@ -@import 'redash/ant'; - /** LESS Plugins **/ @import 'inc/less-plugins/for'; diff --git a/client/app/assets/less/redash/ant.less b/client/app/assets/less/redash/ant.less deleted file mode 100644 index deb8d75555..0000000000 --- a/client/app/assets/less/redash/ant.less +++ /dev/null @@ -1,38 +0,0 @@ -@import '~antd/lib/style/core/iconfont.less'; -@import '~antd/lib/style/core/motion.less'; -@import '~antd/lib/input/style/index.less'; -@import '~antd/lib/date-picker/style/index.less'; -@import '~antd/lib/tooltip/style/index.less'; -@import '~antd/lib/select/style/index.less'; - -// Overwritting Ant Design defaults to fit into Redash current style -@font-family-no-number : @redash-font; -@font-family : @redash-font; -@code-family : @redash-font; - -@border-radius-base : @redash-input-radius; -@border-color-base : #e8e8e8; - -@primary-color : @blue; - -// Fix for disabled button styles inside Tooltip component. -// Tooltip wraps disabled buttons with `` and moves all styles -// and classes to that ``. This resets all button styles and -// turns it into simple inline element (because now it's wrapper is a button) -.btn { - button[disabled] { - -moz-appearance: none !important; - -webkit-appearance: none !important; - appearance: none !important; - border: 0 !important; - outline: none !important; - background: transparent !important; - margin: 0 !important; - padding: 0 !important; - } -} - -// Fix for Ant dropdowns when they are used in Boootstrap modals -.ant-dropdown-in-bootstrap-modal { - z-index: 1050; -} diff --git a/client/app/assets/less/redash/query.less b/client/app/assets/less/redash/query.less index 20791a8c47..157c8b6823 100644 --- a/client/app/assets/less/redash/query.less +++ b/client/app/assets/less/redash/query.less @@ -202,8 +202,11 @@ edit-in-place p.editable:hover { } } -.visualization-renderer .pagination { - margin-top: 10px; +.visualization-renderer { + .pagination, + .ant-pagination { + margin-top: 10px; + } } .embed__vis { @@ -649,10 +652,6 @@ nav .rg-bottom { } } - a.navbar-brand { - display: none; - } - .datasource-small { visibility: visible; } @@ -663,10 +662,6 @@ nav .rg-bottom { display: none; } - a.navbar-brand { - display: block; - } - .filter-container { padding-right: 0; } diff --git a/client/app/assets/less/redash/redash-newstyle.less b/client/app/assets/less/redash/redash-newstyle.less index 2f18c05ad4..97973d3bc0 100644 --- a/client/app/assets/less/redash/redash-newstyle.less +++ b/client/app/assets/less/redash/redash-newstyle.less @@ -35,6 +35,10 @@ body { } } +.word-wrap-break { + word-wrap: break-word; +} + .clearboth { clear: both; } @@ -54,27 +58,9 @@ body { border-left-color: #1b809e; } -.list-content { - @media (min-width: 992px) { - padding-right: 0; - } -} - -.list-control-r-b { - @media (max-width: 992px) { - display: none; - } -} - -.list-control-t { - @media (min-width: 992px) { - display: none; - } -} - // Fixed width layout for specific pages @media (min-width: 768px) { - settings-screen, home-page, page-dashboard-list, page-queries-list, alerts-list-page, alert-page, queries-search-results-page, .fixed-container { + settings-screen, home-page, page-dashboard-list, page-queries-list, page-alerts-list, alert-page, queries-search-results-page, .fixed-container { .container { width: 750px; } @@ -82,7 +68,7 @@ body { } @media (min-width: 992px) { - settings-screen, home-page, page-dashboard-list, page-queries-list, alerts-list-page, alert-page, queries-search-results-page, .fixed-container { + settings-screen, home-page, page-dashboard-list, page-queries-list, page-alerts-list, alert-page, queries-search-results-page, .fixed-container { .container { width: 970px; } @@ -90,7 +76,7 @@ body { } @media (min-width: 1200px) { - settings-screen, home-page, page-dashboard-list, page-queries-list, alerts-list-page, alert-page, queries-search-results-page, .fixed-container { + settings-screen, home-page, page-dashboard-list, page-queries-list, page-alerts-list, alert-page, queries-search-results-page, .fixed-container { .container { width: 1170px; } @@ -168,16 +154,12 @@ body { box-shadow: inset 3px 0px 0px @brand-primary; } -.table.table-data { - > tbody > tr > td { +.table-data { + tbody > tr > td { padding-top: 5px !important; } - tr:hover { - cursor: pointer; - } - - .btn-favourite { + .btn-favourite, .btn-archive { font-size: 15px; } } @@ -190,7 +172,7 @@ body { } } -.btn-favourite { +.btn-favourite, .btn-archive { color: #d4d4d4; transition: all .25s ease-in-out; @@ -203,7 +185,20 @@ body { } } -.page-header--new .btn-favourite { +.btn-archive { + color: #d4d4d4; + transition: all .25s ease-in-out; + + &:hover, &:focus { + color: @gray-light; + } + + .fa-archive { + color: @gray-light; + } +} + +.page-header--new .btn-favourite, .page-header--new .btn-archive { font-size: 19px; } @@ -239,7 +234,7 @@ body { } } -.navbar li a .btn-favourite .fa { +.navbar li a .btn-favourite .fa, .navbar li a .btn-archive .fa { font-size: 100%; } @@ -366,7 +361,7 @@ body { padding: 20px; } -page-header, .page-header--new { +.page-header-wrapper, .page-header--new { h3 { margin: 0.2em 0; line-height: 1.3; @@ -468,7 +463,7 @@ page-header, .page-header--new { .label-tag-archived, .label-tag { margin-right: 3px; - display: inline-block; + display: inline; margin-top: 2px; max-width: 24ch; .text-overflow(); @@ -640,11 +635,6 @@ page-header, .page-header--new { background: #fff; margin-bottom: 10px; - a.navbar-brand { - padding: 4px 0px 0px 0px; - margin-left: -3px !important; - } - .btn-group.open .dropdown-toggle { -webkit-box-shadow: none; box-shadow: none; @@ -655,6 +645,18 @@ page-header, .page-header--new { } } +.navbar-link-ANGULAR_REMOVE_ME { + line-height: 18px; + padding: 10px 15px; + display: block; + + @media (min-width: 768px) { + padding-top: 16px; + padding-bottom: 16px; + } +} + +.navbar-link-ANGULAR_REMOVE_ME, .navbar-default .navbar-nav > li > a { color: #000; font-weight: 500; @@ -706,6 +708,11 @@ page-header, .page-header--new { height: 20px; } +.user_list__user--invitation-pending { + color: fade(@alert-danger-bg, 75%); + font-weight: 500; +} + .btn__new { margin-left: 15px; } @@ -717,11 +724,10 @@ page-header, .page-header--new { .navbar-brand { position: absolute; - left: 49%; - margin-left: -50px !important; + left: 50%; + margin-left: -25px !important; // center display: block; zoom: 0.9; - margin-top: 3px; } .va-top { @@ -806,11 +812,9 @@ page-header, .page-header--new { // Forms .form-control { border-radius: @redash-input-radius; - color: #9E9E9E; &:focus { box-shadow: none !important; - color: #111; border-color: @blue; } @@ -843,6 +847,7 @@ text.slicetext { .navbar-brand { left: 2%; + margin-left: 0 !important; } //Fix navbar collapse @@ -883,13 +888,28 @@ text.slicetext { } } -@media (min-width: 768px) and (max-width: 850px) { - .menu-search { - width: 175px; +@media (min-width: 768px) { + @media (max-width: 880px) { + .navbar-link-ANGULAR_REMOVE_ME, + .navbar-default .navbar-nav > li > a, + .navbar-form { + padding-left: 10px !important; + padding-right: 10px !important; + } + + a.navbar-brand { + margin-left: -15px !important; + } } - a.navbar-brand { - display: none !important; + @media (max-width: 810px) { + .menu-search { + width: 175px; + } + + a.navbar-brand { + margin-left: 13px !important; + } } } @@ -933,3 +953,26 @@ text.slicetext { } } +.ui-select-choices-row.disabled > span { + background-color: inherit !important; +} + +.list-group-item.inactive, +.ui-select-choices-row.disabled { + background-color: #eee !important; + border-color: transparent; + opacity: 0.5; + box-shadow: none; + color: #333; + pointer-events: none; + cursor: not-allowed; +} + +.select-option-divider { + margin: 10px 0 !important; +} + +.table-data .label-tag { + display: inline-block; + max-width: 135px; +} \ No newline at end of file diff --git a/client/app/assets/less/redash/tags-control.less b/client/app/assets/less/redash/tags-control.less index 3aaf402620..6698c4a5f7 100644 --- a/client/app/assets/less/redash/tags-control.less +++ b/client/app/assets/less/redash/tags-control.less @@ -8,6 +8,15 @@ &.inline-tags-control { display: inline-block; - vertical-align: middle; } + + &.disabled { + opacity: 0.4; + } +} + +// This is for using .inline-tags-control in Angular which renders +// a little differently than React (e.g. in Alert.html) +.inline-tags-control .tags-control { + display: inline-block; } diff --git a/client/app/components/AutocompleteToggle.jsx b/client/app/components/AutocompleteToggle.jsx index e74e0a9047..5a4c9bff20 100644 --- a/client/app/components/AutocompleteToggle.jsx +++ b/client/app/components/AutocompleteToggle.jsx @@ -2,7 +2,7 @@ import React from 'react'; import Tooltip from 'antd/lib/tooltip'; import PropTypes from 'prop-types'; import '@/redash-font/style.less'; -import recordEvent from '@/lib/recordEvent'; +import recordEvent from '@/services/recordEvent'; export default function AutocompleteToggle({ state, disabled, onToggle }) { let tooltipMessage = 'Live Autocomplete Enabled'; diff --git a/client/app/components/BigMessage.jsx b/client/app/components/BigMessage.jsx index e667113e6b..1063c1c950 100644 --- a/client/app/components/BigMessage.jsx +++ b/client/app/components/BigMessage.jsx @@ -2,9 +2,9 @@ import React from 'react'; import PropTypes from 'prop-types'; import { react2angular } from 'react2angular'; -export function BigMessage({ message, icon, children }) { +export function BigMessage({ message, icon, children, className }) { return ( -
+

@@ -19,11 +19,13 @@ BigMessage.propTypes = { message: PropTypes.string, icon: PropTypes.string.isRequired, children: PropTypes.node, + className: PropTypes.string, }; BigMessage.defaultProps = { message: '', children: null, + className: 'tiled bg-white', }; export default function init(ngModule) { diff --git a/client/app/components/DateInput.jsx b/client/app/components/DateInput.jsx index e72dc4112e..733c3b669c 100644 --- a/client/app/components/DateInput.jsx +++ b/client/app/components/DateInput.jsx @@ -1,14 +1,14 @@ -import moment from 'moment'; import React from 'react'; import PropTypes from 'prop-types'; import { react2angular } from 'react2angular'; import DatePicker from 'antd/lib/date-picker'; +import { clientConfig } from '@/services/auth'; +import { Moment } from '@/components/proptypes'; -function DateInput({ +export function DateInput({ value, onSelect, - // eslint-disable-next-line react/prop-types - clientConfig, + className, }) { const format = clientConfig.dateFormat || 'YYYY-MM-DD'; const additionalAttributes = {}; @@ -17,6 +17,7 @@ function DateInput({ } return ( { - const value = props[propName]; - if ((value !== null) && !moment.isMoment(value)) { - return new Error('Prop `' + propName + '` supplied to `' + componentName + - '` should be a Moment.js instance.'); - } - }, + value: Moment, onSelect: PropTypes.func, + className: PropTypes.string, }; DateInput.defaultProps = { value: null, onSelect: () => {}, + className: '', }; export default function init(ngModule) { - ngModule.component('dateInput', react2angular(DateInput, null, ['clientConfig'])); + ngModule.component('dateInput', react2angular(DateInput)); } init.init = true; diff --git a/client/app/components/DateRangeInput.jsx b/client/app/components/DateRangeInput.jsx index 0d864216ad..8dc2bd973f 100644 --- a/client/app/components/DateRangeInput.jsx +++ b/client/app/components/DateRangeInput.jsx @@ -1,15 +1,17 @@ -import moment from 'moment'; import { isArray } from 'lodash'; import React from 'react'; import PropTypes from 'prop-types'; import { react2angular } from 'react2angular'; -import { RangePicker } from 'antd/lib/date-picker'; +import DatePicker from 'antd/lib/date-picker'; +import { clientConfig } from '@/services/auth'; +import { Moment } from '@/components/proptypes'; -function DateRangeInput({ +const { RangePicker } = DatePicker; + +export function DateRangeInput({ value, onSelect, - // eslint-disable-next-line react/prop-types - clientConfig, + className, }) { const format = clientConfig.dateFormat || 'YYYY-MM-DD'; const additionalAttributes = {}; @@ -18,6 +20,7 @@ function DateRangeInput({ } return ( { - const value = props[propName]; - if ( - (value !== null) && !( - isArray(value) && (value.length === 2) && - moment.isMoment(value[0]) && moment.isMoment(value[1]) - ) - ) { - return new Error('Prop `' + propName + '` supplied to `' + componentName + - '` should be an array of two Moment.js instances.'); - } - }, + value: PropTypes.arrayOf(Moment), onSelect: PropTypes.func, + className: PropTypes.string, }; DateRangeInput.defaultProps = { value: null, onSelect: () => {}, + className: '', }; export default function init(ngModule) { - ngModule.component('dateRangeInput', react2angular(DateRangeInput, null, ['clientConfig'])); + ngModule.component('dateRangeInput', react2angular(DateRangeInput)); } init.init = true; diff --git a/client/app/components/DateTimeInput.jsx b/client/app/components/DateTimeInput.jsx index 739ec17f8d..d51210813a 100644 --- a/client/app/components/DateTimeInput.jsx +++ b/client/app/components/DateTimeInput.jsx @@ -1,15 +1,15 @@ -import moment from 'moment'; import React from 'react'; import PropTypes from 'prop-types'; import { react2angular } from 'react2angular'; import DatePicker from 'antd/lib/date-picker'; +import { clientConfig } from '@/services/auth'; +import { Moment } from '@/components/proptypes'; -function DateTimeInput({ +export function DateTimeInput({ value, withSeconds, onSelect, - // eslint-disable-next-line react/prop-types - clientConfig, + className, }) { const format = (clientConfig.dateFormat || 'YYYY-MM-DD') + (withSeconds ? ' HH:mm:ss' : ' HH:mm'); @@ -19,6 +19,7 @@ function DateTimeInput({ } return ( { - const value = props[propName]; - if ((value !== null) && !moment.isMoment(value)) { - return new Error('Prop `' + propName + '` supplied to `' + componentName + - '` should be a Moment.js instance.'); - } - }, + value: Moment, withSeconds: PropTypes.bool, onSelect: PropTypes.func, + className: PropTypes.string, }; DateTimeInput.defaultProps = { value: null, withSeconds: false, onSelect: () => {}, + className: '', }; export default function init(ngModule) { - ngModule.component('dateTimeInput', react2angular(DateTimeInput, null, ['clientConfig'])); + ngModule.component('dateTimeInput', react2angular(DateTimeInput)); } init.init = true; diff --git a/client/app/components/DateTimeRangeInput.jsx b/client/app/components/DateTimeRangeInput.jsx index 5cab36c0f6..55e8ca7514 100644 --- a/client/app/components/DateTimeRangeInput.jsx +++ b/client/app/components/DateTimeRangeInput.jsx @@ -1,16 +1,18 @@ -import moment from 'moment'; import { isArray } from 'lodash'; import React from 'react'; import PropTypes from 'prop-types'; import { react2angular } from 'react2angular'; -import { RangePicker } from 'antd/lib/date-picker'; +import DatePicker from 'antd/lib/date-picker'; +import { clientConfig } from '@/services/auth'; +import { Moment } from '@/components/proptypes'; -function DateTimeRangeInput({ +const { RangePicker } = DatePicker; + +export function DateTimeRangeInput({ value, withSeconds, onSelect, - // eslint-disable-next-line react/prop-types - clientConfig, + className, }) { const format = (clientConfig.dateFormat || 'YYYY-MM-DD') + (withSeconds ? ' HH:mm:ss' : ' HH:mm'); @@ -20,6 +22,7 @@ function DateTimeRangeInput({ } return ( { - const value = props[propName]; - if ( - (value !== null) && !( - isArray(value) && (value.length === 2) && - moment.isMoment(value[0]) && moment.isMoment(value[1]) - ) - ) { - return new Error('Prop `' + propName + '` supplied to `' + componentName + - '` should be an array of two Moment.js instances.'); - } - }, + value: PropTypes.arrayOf(Moment), withSeconds: PropTypes.bool, onSelect: PropTypes.func, + className: PropTypes.string, }; DateTimeRangeInput.defaultProps = { value: null, withSeconds: false, onSelect: () => {}, + className: '', }; export default function init(ngModule) { - ngModule.component('dateTimeRangeInput', react2angular(DateTimeRangeInput, null, ['clientConfig'])); + ngModule.component('dateTimeRangeInput', react2angular(DateTimeRangeInput)); } init.init = true; - diff --git a/client/app/components/DialogWrapper.jsx b/client/app/components/DialogWrapper.jsx new file mode 100644 index 0000000000..de94a43c68 --- /dev/null +++ b/client/app/components/DialogWrapper.jsx @@ -0,0 +1,209 @@ +import { isFunction } from 'lodash'; +import React from 'react'; +import PropTypes from 'prop-types'; +import ReactDOM from 'react-dom'; + +/** + Wrapper for dialogs based on Ant's component. + + + Using wrapped dialogs + ===================== + + Wrapped component is an object with two fields: + + { + showModal: (dialogProps) => object({ + result: Promise, + close: (result) => void, + dismiss: (reason) => void, + }), + Component: React.Component, // wrapped dialog component + } + + To open dialog, use `showModal` method; optionally you can pass additional properties that + will be expanded on wrapped component: + + const dialog = SomeWrappedDialog.showModal() + + const dialog = SomeWrappedDialog.showModal({ greeting: 'Hello' }) + + To get result of modal, use `result` property: + + dialog.result + .then(...) // pressed OK button or used `close` method; resolved value is a result of dialog + .catch(...) // pressed Cancel button or used `dismiss` method; optional argument is a rejection reason. + + Also, dialog has `close` and `dismiss` methods that allows to close dialog by caller. Passed arguments + will be used to resolve/reject `dialog.result` promise. `update` methods allows to pass new properties + to dialog. + + + Creating a dialog + ================ + + 1. Add imports: + + import { wrap as wrapDialog, DialogPropType } from 'path/to/DialogWrapper'; + + 2. define a `dialog` property on your component: + + propTypes = { + dialog: DialogPropType.isRequired, + }; + + `dialog` property is an object: + + { + props: object, // properties for component; + close: (result) => void, // method to confirm dialog; `result` will be returned to caller + dismiss: (reason) => void, // method to reject dialog; `reason` will be returned to caller + } + + 3. expand additional properties on component: + + render() { + const { dialog } = this.props; + return ( + + ); + } + + 4. wrap your component and export it: + + export default wrapDialog(YourComponent). + + Your component is ready to use. Wrapper will manage 's visibility and events. + If you want to override behavior of `onOk`/`onCancel` - don't forget to close dialog: + + customOkHandler() { + this.saveData().then(() => { + this.props.dialog.close({ success: true }); // or dismiss(); + }); + } + + render() { + const { dialog } = this.props; + return ( + this.customOkHandler()}> + ); + } + + + Settings + ======== + + You can setup this wrapper to use custom `Promise` library (for example, Bluebird): + + import DialogWrapper from 'path/to/DialogWrapper'; + import Promise from 'bluebird'; + + DialogWrapper.Promise = Promise; + + It could be useful to avoid `unhandledrejection` exception that would fire with native Promises, + or when some custom Promise library is used in application. + +*/ + +export const DialogPropType = PropTypes.shape({ + props: PropTypes.shape({ + visible: PropTypes.bool, + onOk: PropTypes.func, + onCancel: PropTypes.func, + afterClose: PropTypes.func, + }).isRequired, + close: PropTypes.func.isRequired, + dismiss: PropTypes.func.isRequired, +}); + +// default export of module +const DialogWrapper = { + Promise, + DialogPropType, + wrap() {}, +}; + +function openDialog(DialogComponent, props) { + const dialog = { + props: { + visible: true, + onOk: () => {}, + onCancel: () => {}, + afterClose: () => {}, + }, + close: () => {}, + dismiss: () => {}, + }; + + const dialogResult = { + resolve: () => {}, + reject: () => {}, + }; + + const container = document.createElement('div'); + document.body.appendChild(container); + + function render() { + ReactDOM.render(, container); + } + + function destroyDialog() { + // Allow calling chain to roll up, and then destroy component + setTimeout(() => { + ReactDOM.unmountComponentAtNode(container); + document.body.removeChild(container); + }, 10); + } + + function closeDialog(result) { + dialogResult.resolve(result); + dialog.props.visible = false; + render(); + } + + function dismissDialog(reason) { + dialogResult.reject(reason); + dialog.props.visible = false; + render(); + } + + dialog.props.onOk = closeDialog; + dialog.props.onCancel = dismissDialog; + dialog.props.afterClose = destroyDialog; + dialog.close = closeDialog; + dialog.dismiss = dismissDialog; + + const result = { + close: closeDialog, + dismiss: dismissDialog, + update: (newProps) => { + props = { ...props, ...newProps }; + render(); + }, + result: new DialogWrapper.Promise((resolve, reject) => { + dialogResult.resolve = resolve; + dialogResult.reject = reject; + }), + }; + + render(); // show it only when all structures initialized to avoid unnecessary re-rendering + + // Some known libraries support + // Bluebird: http://bluebirdjs.com/docs/api/suppressunhandledrejections.html + if (isFunction(result.result.suppressUnhandledRejections)) { + result.result.suppressUnhandledRejections(); + } + + return result; +} + +export function wrap(DialogComponent) { + return { + Component: DialogComponent, + showModal: props => openDialog(DialogComponent, props), + }; +} + +DialogWrapper.wrap = wrap; + +export default DialogWrapper; diff --git a/client/app/components/DynamicComponent.jsx b/client/app/components/DynamicComponent.jsx new file mode 100644 index 0000000000..645cb2b94b --- /dev/null +++ b/client/app/components/DynamicComponent.jsx @@ -0,0 +1,50 @@ +import { isFunction, isString } from 'lodash'; +import React from 'react'; +import PropTypes from 'prop-types'; + +const componentsRegistry = new Map(); +const activeInstances = new Set(); + +export function registerComponent(name, component) { + if (isString(name) && name !== '') { + componentsRegistry.set(name, isFunction(component) ? component : null); + // Refresh active DynamicComponent instances which use this component + activeInstances.forEach((dynamicComponent) => { + if (dynamicComponent.props.name === name) { + dynamicComponent.forceUpdate(); + } + }); + } +} + +export function unregisterComponent(name) { + registerComponent(name, null); +} + +export default class DynamicComponent extends React.Component { + static propTypes = { + name: PropTypes.string.isRequired, + children: PropTypes.node, + }; + + static defaultProps = { + children: null, + }; + + componentDidMount() { + activeInstances.add(this); + } + + componentWillUnmount() { + activeInstances.delete(this); + } + + render() { + const { name, children, ...props } = this.props; + const RealComponent = componentsRegistry.get(name); + if (!RealComponent) { + return null; + } + return {children}; + } +} diff --git a/client/app/components/EditInPlace.jsx b/client/app/components/EditInPlace.jsx index 369f5d470b..2a923b33b3 100644 --- a/client/app/components/EditInPlace.jsx +++ b/client/app/components/EditInPlace.jsx @@ -1,6 +1,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import { react2angular } from 'react2angular'; +import { trim } from 'lodash'; export class EditInPlace extends React.Component { static propTypes = { @@ -18,6 +19,7 @@ export class EditInPlace extends React.Component { placeholder: '', value: '', }; + constructor(props) { super(props); this.state = { @@ -39,7 +41,7 @@ export class EditInPlace extends React.Component { }; stopEditing = () => { - const newValue = this.inputRef.current.value; + const newValue = trim(this.inputRef.current.value); const ignorableBlank = this.props.ignoreBlanks && newValue === ''; if (!ignorableBlank && newValue !== this.props.value) { this.props.onDone(newValue); @@ -67,14 +69,13 @@ export class EditInPlace extends React.Component { ); - renderEdit = () => - React.createElement(this.props.editor, { - ref: this.inputRef, - className: 'rd-form-control', - defaultValue: this.props.value, - onBlur: this.stopEditing, - onKeyDown: this.keyDown, - }); + renderEdit = () => React.createElement(this.props.editor, { + ref: this.inputRef, + className: 'rd-form-control', + defaultValue: this.props.value, + onBlur: this.stopEditing, + onKeyDown: this.keyDown, + }); render() { return ( diff --git a/client/app/components/EditParameterSettingsDialog.jsx b/client/app/components/EditParameterSettingsDialog.jsx new file mode 100644 index 0000000000..01b0504156 --- /dev/null +++ b/client/app/components/EditParameterSettingsDialog.jsx @@ -0,0 +1,218 @@ + +import { includes, startsWith, words, capitalize, clone, isNull } from 'lodash'; +import React, { useState, useEffect } from 'react'; +import PropTypes from 'prop-types'; +import Modal from 'antd/lib/modal'; +import Form from 'antd/lib/form'; +import Checkbox from 'antd/lib/checkbox'; +import Button from 'antd/lib/button'; +import Select from 'antd/lib/select'; +import Input from 'antd/lib/input'; +import Divider from 'antd/lib/divider'; +import { wrap as wrapDialog, DialogPropType } from '@/components/DialogWrapper'; +import { QuerySelector } from '@/components/QuerySelector'; +import { Query } from '@/services/query'; + +const { Option } = Select; +const formItemProps = { labelCol: { span: 6 }, wrapperCol: { span: 16 } }; + +function getDefaultTitle(text) { + return capitalize(words(text).join(' ')); // humanize +} + +function isTypeDate(type) { + return startsWith(type, 'date') && !isTypeDateRange(type); +} + +function isTypeDateRange(type) { + return /-range/.test(type); +} + +function NameInput({ name, type, onChange, existingNames, setValidation }) { + let helpText = ''; + let validateStatus = ''; + + if (!name) { + helpText = 'Choose a keyword for this parameter'; + setValidation(false); + } else if (includes(existingNames, name)) { + helpText = 'Parameter with this name already exists'; + setValidation(false); + validateStatus = 'error'; + } else { + if (isTypeDateRange(type)) { + helpText = ( + + Appears in query as {' '} + + {`{{${name}.start}} {{${name}.end}}`} + + + ); + } + setValidation(true); + } + + return ( + + onChange(e.target.value)} autoFocus /> + + ); +} + +NameInput.propTypes = { + name: PropTypes.string.isRequired, + onChange: PropTypes.func.isRequired, + existingNames: PropTypes.arrayOf(PropTypes.string).isRequired, + setValidation: PropTypes.func.isRequired, + type: PropTypes.string.isRequired, +}; + +function EditParameterSettingsDialog(props) { + const [param, setParam] = useState(clone(props.parameter)); + const [isNameValid, setIsNameValid] = useState(true); + const [initialQuery, setInitialQuery] = useState(); + + const isNew = !props.parameter.name; + + // fetch query by id + useEffect(() => { + const { queryId } = props.parameter; + if (queryId) { + Query.get({ id: queryId }, (query) => { + setInitialQuery(query); + }); + } + }, []); + + function isFulfilled() { + // name + if (!isNameValid) { + return false; + } + + // title + if (param.title === '') { + return false; + } + + // query + if (param.type === 'query' && !param.queryId) { + return false; + } + + return true; + } + + function onConfirm(e) { + // update title to default + if (!param.title) { + // forced to do this cause param won't update in time for save + param.title = getDefaultTitle(param.name); + setParam(param); + } + + props.dialog.close(param); + + e.preventDefault(); // stops form redirect + } + + return ( + Cancel + ), ( + + )]} + > +
+ {isNew && ( + setParam({ ...param, name })} + setValidation={setIsNameValid} + existingNames={props.existingParams} + type={param.type} + /> + )} + + setParam({ ...param, title: e.target.value })} + /> + + + + + {isTypeDate(param.type) && ( + + setParam({ ...param, useCurrentDateTime: e.target.checked })} + > + Default to Today/Now if no other value is set + + + )} + {param.type === 'enum' && ( + + setParam({ ...param, enumOptions: e.target.value })} + /> + + )} + {param.type === 'query' && ( + + setParam({ ...param, queryId: q && q.id })} + type="select" + /> + + )} + +
+ ); +} + +EditParameterSettingsDialog.propTypes = { + parameter: PropTypes.object.isRequired, // eslint-disable-line react/forbid-prop-types + dialog: DialogPropType.isRequired, + existingParams: PropTypes.arrayOf(PropTypes.string), +}; + +EditParameterSettingsDialog.defaultProps = { + existingParams: [], +}; + +export default wrapDialog(EditParameterSettingsDialog); diff --git a/client/app/components/EmailSettingsWarning.jsx b/client/app/components/EmailSettingsWarning.jsx new file mode 100644 index 0000000000..7533c30881 --- /dev/null +++ b/client/app/components/EmailSettingsWarning.jsx @@ -0,0 +1,22 @@ +import React from 'react'; +import PropTypes from 'prop-types'; +import { react2angular } from 'react2angular'; +import { currentUser, clientConfig } from '@/services/auth'; + +export function EmailSettingsWarning({ featureName }) { + return (clientConfig.mailSettingsMissing && currentUser.isAdmin) ? ( +

+ {`It looks like your mail server isn't configured. Make sure to configure it for the ${featureName} to work.`} +

+ ) : null; +} + +EmailSettingsWarning.propTypes = { + featureName: PropTypes.string.isRequired, +}; + +export default function init(ngModule) { + ngModule.component('emailSettingsWarning', react2angular(EmailSettingsWarning)); +} + +init.init = true; diff --git a/client/app/components/FavoritesControl.jsx b/client/app/components/FavoritesControl.jsx new file mode 100644 index 0000000000..665d7e7b83 --- /dev/null +++ b/client/app/components/FavoritesControl.jsx @@ -0,0 +1,79 @@ +import React from 'react'; +import PropTypes from 'prop-types'; +import { react2angular } from 'react2angular'; +import { $rootScope } from '@/services/ng'; + +export class FavoritesControl extends React.Component { + static propTypes = { + item: PropTypes.shape({ + is_favorite: PropTypes.bool.isRequired, + }).isRequired, + onChange: PropTypes.func, + // Force component update when `item` changes. + // Remove this when `react2angular` will finally go to hell + forceUpdate: PropTypes.string, // eslint-disable-line react/no-unused-prop-types + }; + + static defaultProps = { + onChange: () => {}, + forceUpdate: '', + }; + + toggleItem(event, item, callback) { + const action = item.is_favorite ? item.$unfavorite.bind(item) : item.$favorite.bind(item); + const savedIsFavorite = item.is_favorite; + + action().then(() => { + item.is_favorite = !savedIsFavorite; + this.forceUpdate(); + $rootScope.$broadcast('reloadFavorites'); + callback(); + }); + } + + render() { + const { item, onChange } = this.props; + const icon = item.is_favorite ? 'fa fa-star' : 'fa fa-star-o'; + const title = item.is_favorite ? 'Remove from favorites' : 'Add to favorites'; + return ( + this.toggleItem(event, item, onChange)} + > +