Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/create better solution for env vars #725

Merged
merged 44 commits into from
Jan 26, 2025
Merged

feat/create better solution for env vars #725

merged 44 commits into from
Jan 26, 2025

Conversation

PatrykKuniczak
Copy link
Collaborator

* Please fill in the required items.

Priority*

  • High: This PR needs to be merged first for other tasks.
  • Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

I've decided to fix issue about import.meta.env by solution with only process.env because i hope this will be more simple, to have only one instance with all envs

Changes*

I've removed vite env solution and replace it with process.env

How to check the feature

Try to add env(Read docs about it) and try to access it anywhere

@PatrykKuniczak PatrykKuniczak force-pushed the feat/create-custom-env-solution-for-modules branch 3 times, most recently from 3ac79d7 to 4c03d1a Compare September 11, 2024 20:59
@PatrykKuniczak PatrykKuniczak linked an issue Sep 12, 2024 that may be closed by this pull request
Create custom solution for env #722
Closed
@PatrykKuniczak PatrykKuniczak added the enhancement New feature or request label Dec 18, 2024
@PatrykKuniczak PatrykKuniczak force-pushed the feat/create-custom-env-solution-for-modules branch from 4c03d1a to 2ef32ce Compare December 28, 2024 16:41
@PatrykKuniczak PatrykKuniczak force-pushed the feat/create-custom-env-solution-for-modules branch from 2ef32ce to b9e9e79 Compare January 12, 2025 13:24
@PatrykKuniczak PatrykKuniczak changed the base branch from main to dev January 12, 2025 13:24
@PatrykKuniczak PatrykKuniczak mentioned this pull request Jan 14, 2025
Merged
3 tasks
@PatrykKuniczak PatrykKuniczak force-pushed the feat/create-custom-env-solution-for-modules branch 2 times, most recently from 49f0487 to d8cd675 Compare January 20, 2025 20:11
@PatrykKuniczak PatrykKuniczak force-pushed the feat/create-custom-env-solution-for-modules branch from 1e04904 to 606de54 Compare January 25, 2025 18:59
@PatrykKuniczak PatrykKuniczak marked this pull request as ready for review January 25, 2025 19:19
Jonghakseo
Jonghakseo approved these changes Jan 25, 2025
View reviewed changes
Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatrykKuniczak
chore: create script for automatic creating .env file and update RE…
7efeef9 
…ADME
@PatrykKuniczak
chore: create script for load env from CLI into .env
8d3f6dd
@PatrykKuniczak
chore: create more validation for set_global_env.sh
4b664e7
@PatrykKuniczak
fix: remove unnecessary else from copy_env.sh
256bc0b
@PatrykKuniczak
chore: add with-env script to root package.json
acfe671
@PatrykKuniczak
chore: update readme Env Vars section
a2977e5
@PatrykKuniczak
fix: remove type-check from build and remove cross-env where I've for…
385f6ea 
…gotten
@PatrykKuniczak
chore: add move explanation about CLI env setting to README.md
e2d33b9
@PatrykKuniczak
chore: add node type for all modules tsconfig.json
9fe50ce
@PatrykKuniczak
chore: add patterns for globalEnv for turbo
6eb9bf5
@PatrykKuniczak
chore: rename example env
d9cb972
@PatrykKuniczak
chore: update README.md for new approach
a5d1a77
@PatrykKuniczak
chore: update set_global_env.sh script to the new prefixes CLI_CEB an…
48a7c59 
…d CEB_
@PatrykKuniczak
chore: update README.md for new approach
0712a59
@PatrykKuniczak
fix: add missing CLI_CEB_* pattern for turbo.json
f395aec
@PatrykKuniczak
fix: add missing(during conflicts resolving) typescript package to …
585f6d2 
…main package.json
@PatrykKuniczak
fix: rename index.ts to .mts for index of zipper and adjust to new env
1eedd52
@PatrykKuniczak
feat: change CEB_DEV_LOCALE and isDev placeholders to real env values
c5a549a
@PatrykKuniczak
fix: define env file for i18n prepare-build
1342d78
@PatrykKuniczak
fix: remove unnecessary noEmit from chrome-extension tsconfig
50cbe55
@PatrykKuniczak
clean: remove unnecessary isFirefox from manifest.ts
f08856f
@PatrykKuniczak
fix: add missing "noEmit" for pre-build.tsconfig.json for chrome-exte…
da00a17 
…nsion
@PatrykKuniczak
clean: remove unnecessary import from make-manifest-plugin.ts
68cbd27
@PatrykKuniczak
clean: remove unnecessary copy-env script from set-global-env script
e56d114
@PatrykKuniczak
feat: create global env object and new solution for dynamic env values
babe2d3
@PatrykKuniczak
feat: update root README.md and move env part to env/README.md
81a3644
@PatrykKuniczak
chore: add CEB_CI to example.env
077aeb5
@PatrykKuniczak
feat: change env module to be module (tsconfig)
aeb668a
@PatrykKuniczak
feat: changes refs from process.env to env from package
2360ae6
@PatrykKuniczak
chore: create base-build script and restart cli envs on build
cdaac9c
@PatrykKuniczak
feat: create zipper as module (tsconfig) and add new env values
b382a33
@PatrykKuniczak
fix: resolve pnpm-lock.yaml conflicts
6d1bb45
@PatrykKuniczak
fix: remove unused esbuild package
f9541fc
@PatrykKuniczak
fix: issue with node packages polyfilling
4dc88cf
@PatrykKuniczak
feat: restructure env module
064e333
@PatrykKuniczak
fix: adjust env call to new approach (with only process.env)
47591e5
@PatrykKuniczak
fix: rename consts to const for env module
25fcfc6
@PatrykKuniczak
docs: change README.md to solution with process.env
e355ec7
@PatrykKuniczak
clean: remove unnecessary values from wdio.browser.conf.ts
574448d
@PatrykKuniczak PatrykKuniczak force-pushed the feat/create-custom-env-solution-for-modules branch from db1e1bc to 574448d Compare January 26, 2025 08:38
@PatrykKuniczak PatrykKuniczak merged commit 2b9f85e into dev Jan 26, 2025
5 checks passed
@PatrykKuniczak PatrykKuniczak deleted the feat/create-custom-env-solution-for-modules branch January 26, 2025 08:39
@PatrykKuniczak PatrykKuniczak mentioned this pull request Jan 26, 2025
Merged
3 tasks
@PatrykKuniczak PatrykKuniczak mentioned this pull request Feb 14, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonghakseo Jonghakseo Jonghakseo approved these changes

Assignees

@PatrykKuniczak PatrykKuniczak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create custom solution for env
2 participants
@PatrykKuniczak @Jonghakseo