Skip to content

Commit

Permalink
fix(vm-config): always use init-localchain and init-transfer (Ago…
Browse files Browse the repository at this point in the history
…ric#9672)

## Description

While working on orchnet, I discovered that `decentral-itest-vaults-config.json` lacked references to the `init-localchain.js` and `init-transfer.js` core-evals.

This PR:
- enables them for future chains, since we intend to use them wherever `init-network.js` is present
- removes config references to Pegasus, since it is an obsolete demonstration of an IBC contract, and now we have newer and better examples,
- reduces loud warnings from `vat-bank.js` when unregistered asset balances were detected, since we expect this to be commonplace when dealing with IBC assets from many chains

### Security Considerations
n/a

### Scaling Considerations
Less logging from `vat-bank.js`, once it is upgraded (or started on a new chain).

### Testing Considerations


### Upgrade Considerations
The `vat-bank.js` changes do not modify functionality except logging, so I consider it safe to include for future chains without requiring mainnet's bank vat to be upgraded.
  • Loading branch information
mergify[bot] authored Jul 9, 2024
2 parents b196804 + 9b317a0 commit 8f019c0
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions packages/cosmic-swingset/economy-template.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
],
[
"@agoric/builders/scripts/vats/init-network.js",
"@agoric/builders/scripts/pegasus/init-core.js",
"@agoric/builders/scripts/vats/init-transfer.js"
"@agoric/builders/scripts/vats/init-localchain.js",
"@agoric/builders/scripts/vats/init-transfer.js"
],
[
{
Expand Down
2 changes: 1 addition & 1 deletion packages/vats/src/vat-bank.js
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ const prepareBankChannelHandler = zone =>
updater = addressToUpdater.get(address);
}
} catch (e) {
console.error('Unregistered denom in', update, e);
console.debug('Unregistered denom in', update, e);
}
if (updater) {
try {
Expand Down
4 changes: 3 additions & 1 deletion packages/vm-config/decentral-itest-vaults-config.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
{
"$comment": "This SwingSet config file (see loadSwingsetConfigFile) is designed to bring up vaults test networks in an automated fashion. It includes coreProposals to start vaults. Testing facilities are limited to an initialPrice for ATOM and addresses with known keys.",
"$comment": "Not just vaults! This SwingSet config (see loadSwingsetConfigFile) started for integration testing of Vaults is designed to bring up vaults but became the defacto config for integration testing outside this repo (e.g. instagoric). It includes coreProposals to start Inter Protocol (including vaults) plus Orchestration. Testing facilities are limited to an initialPrice for ATOM and addresses with known keys.",
"bootstrap": "bootstrap",
"defaultReapInterval": 1000,
"coreProposals": [
"@agoric/builders/scripts/vats/init-core.js",
"@agoric/builders/scripts/vats/init-network.js",
"@agoric/builders/scripts/vats/init-localchain.js",
"@agoric/builders/scripts/vats/init-transfer.js",
{
"module": "@agoric/builders/scripts/inter-protocol/init-core.js",
"entrypoint": "defaultProposalBuilder",
Expand Down
1 change: 0 additions & 1 deletion packages/vm-config/demo-proposals.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[
"@agoric/builders/scripts/inter-protocol/init-core.js",
"@agoric/builders/scripts/pegasus/init-core.js",
"@agoric/builders/scripts/vats/init-network.js",
"@agoric/builders/scripts/vats/init-localchain.js",
"@agoric/builders/scripts/vats/init-transfer.js"
Expand Down

0 comments on commit 8f019c0

Please sign in to comment.