tweak: Minor QOL improvements to ModGrid sorting (#52) · Jorixon/JASM@fe8dd68

Triggered via push October 1, 2023 15:58

Jorixon

pushed fe8dd68

main

Status Success

Total duration 4m 16s

Artifacts 1

dotnet-desktop.yml

on: push

Matrix: build

Annotations

15 warnings

build (Release, x64): src/GIMI-ModManager.Core/Services/SkinManagerService.cs#L62

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L14

Possible null reference return.

build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L19

Possible null reference return.

build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L33

Dereference of a possibly null reference.

build (Release, x64): src/GIMI-ModManager.Core/Helpers/Json.cs#L9

Possible null reference return.

build (Release, x64): src/GIMI-ModManager.WinUI/Views/Controls/EditableTextBlock.xaml.cs#L70

'EditableTextBlock.StyleProperty' hides inherited member 'FrameworkElement.StyleProperty'. Use the new keyword if hiding was intended.

build (Release, x64): src/GIMI-ModManager.WinUI/Views/Controls/EditableTextBlock.xaml.cs#L73

'EditableTextBlock.Style' hides inherited member 'FrameworkElement.Style'. Use the new keyword if hiding was intended.

build (Release, x64): src/GIMI-ModManager.WinUI/Services/ModDragAndDropService.cs#L136

The variable 'e' is declared but never used

build (Release, x64): src/GIMI-ModManager.WinUI/Services/LocalSettingsService.cs#L93

Possible null reference argument for parameter 'value' in 'Task<string> Json.StringifyAsync(object value)'.

build (Release, x64): src/GIMI-ModManager.WinUI/Services/LocalSettingsService.cs#L99

Possible null reference argument for parameter 'value' in 'Task<string> Json.StringifyAsync(object value)'.

build (Release, x64): src/GIMI-ModManager.Core/Services/SkinManagerService.cs#L62

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

build (Release, x64): src/GIMI-ModManager.Core/Helpers/Json.cs#L9

Possible null reference return.

build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L14

Possible null reference return.

build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L19

Possible null reference return.

build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L33

Dereference of a possibly null reference.