fix: account for mapped types without modifiers in isPropertyReadonlyInType #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
JoshuaKGoldberg
changed the title
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 25.31% 33.89% +8.57%
==========================================
Files 13 13
Lines 237 239 +2
Branches 98 99 +1
==========================================
+ Hits 60 81 +21
+ Misses 174 140 -34
- Partials 3 18 +15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| name, | ||
| typeChecker | ||
|
|
||
| const { modifiersType } = type as { modifiersType?: ts.Type }; |
There was a problem hiding this comment.
We might want to create a hasModifiersType utility function.
Lets do this in another PR though.
RebeccaStevens
approved these changes
Feb 15, 2023
|
@allcontributors add @JoshuaKGoldberg for bug |
|
I've put up a pull request to add @JoshuaKGoldberg! 🎉 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Checks if
type.modifiersTypeexists before askingisPropertyReadonlyInType(modifiersType, ...).This is a recreation of ajafff/tsutils#136. Which means 😄:
Co-authored-by: @kirjs