From 000b15a40b0a7403444e8a23a270dc21df6fa0cf Mon Sep 17 00:00:00 2001
From: Vincent Esche <regexident@gmail.com>
Date: Wed, 7 Aug 2019 13:14:37 +0200
Subject: [PATCH] Upgraded to recommended project settings

---
 Surge.xcodeproj/project.pbxproj               |  5 +++-
 .../xcshareddata/xcschemes/Surge-iOS.xcscheme | 28 ++++++++-----------
 .../xcschemes/Surge-macOS.xcscheme            | 24 +++++++---------
 .../xcschemes/Surge-tvOS.xcscheme             | 24 +++++++---------
 .../xcschemes/Surge-watchOS.xcscheme          |  6 +---
 5 files changed, 37 insertions(+), 50 deletions(-)

diff --git a/Surge.xcodeproj/project.pbxproj b/Surge.xcodeproj/project.pbxproj
index aacccdf0..440d509a 100644
--- a/Surge.xcodeproj/project.pbxproj
+++ b/Surge.xcodeproj/project.pbxproj
@@ -506,7 +506,7 @@
 			attributes = {
 				LastSwiftMigration = 0710;
 				LastSwiftUpdateCheck = 0910;
-				LastUpgradeCheck = 0930;
+				LastUpgradeCheck = 1100;
 				ORGANIZATIONNAME = "Mattt Thompson";
 				TargetAttributes = {
 					614AD31E1FC0AD99002BFE1C = {
@@ -545,6 +545,7 @@
 			developmentRegion = English;
 			hasScannedForEncodings = 0;
 			knownRegions = (
+				English,
 				en,
 			);
 			mainGroup = F8A1E1A019917A79009735E2;
@@ -1141,6 +1142,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
@@ -1204,6 +1206,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
diff --git a/Surge.xcodeproj/xcshareddata/xcschemes/Surge-iOS.xcscheme b/Surge.xcodeproj/xcshareddata/xcschemes/Surge-iOS.xcscheme
index 312d272e..d4d5ecdc 100644
--- a/Surge.xcodeproj/xcshareddata/xcschemes/Surge-iOS.xcscheme
+++ b/Surge.xcodeproj/xcshareddata/xcschemes/Surge-iOS.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0930"
+   LastUpgradeVersion = "1100"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
@@ -26,8 +26,17 @@
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
-      codeCoverageEnabled = "YES"
-      shouldUseLaunchSchemeArgsEnv = "YES">
+      shouldUseLaunchSchemeArgsEnv = "YES"
+      codeCoverageEnabled = "YES">
+      <MacroExpansion>
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "F8A1E1A919917A79009735E2"
+            BuildableName = "Surge.framework"
+            BlueprintName = "Surge-iOS"
+            ReferencedContainer = "container:Surge.xcodeproj">
+         </BuildableReference>
+      </MacroExpansion>
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -40,17 +49,6 @@
             </BuildableReference>
          </TestableReference>
       </Testables>
-      <MacroExpansion>
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "F8A1E1A919917A79009735E2"
-            BuildableName = "Surge.framework"
-            BlueprintName = "Surge-iOS"
-            ReferencedContainer = "container:Surge.xcodeproj">
-         </BuildableReference>
-      </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -71,8 +69,6 @@
             ReferencedContainer = "container:Surge.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"
diff --git a/Surge.xcodeproj/xcshareddata/xcschemes/Surge-macOS.xcscheme b/Surge.xcodeproj/xcshareddata/xcschemes/Surge-macOS.xcscheme
index d04074bf..9e3c9d85 100644
--- a/Surge.xcodeproj/xcshareddata/xcschemes/Surge-macOS.xcscheme
+++ b/Surge.xcodeproj/xcshareddata/xcschemes/Surge-macOS.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0930"
+   LastUpgradeVersion = "1100"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
@@ -27,6 +27,15 @@
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       shouldUseLaunchSchemeArgsEnv = "YES">
+      <MacroExpansion>
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "614AD31E1FC0AD99002BFE1C"
+            BuildableName = "Surge.framework"
+            BlueprintName = "Surge-macOS"
+            ReferencedContainer = "container:Surge.xcodeproj">
+         </BuildableReference>
+      </MacroExpansion>
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -39,17 +48,6 @@
             </BuildableReference>
          </TestableReference>
       </Testables>
-      <MacroExpansion>
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "614AD31E1FC0AD99002BFE1C"
-            BuildableName = "Surge.framework"
-            BlueprintName = "Surge-macOS"
-            ReferencedContainer = "container:Surge.xcodeproj">
-         </BuildableReference>
-      </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -70,8 +68,6 @@
             ReferencedContainer = "container:Surge.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"
diff --git a/Surge.xcodeproj/xcshareddata/xcschemes/Surge-tvOS.xcscheme b/Surge.xcodeproj/xcshareddata/xcschemes/Surge-tvOS.xcscheme
index 423ea30e..41aae979 100644
--- a/Surge.xcodeproj/xcshareddata/xcschemes/Surge-tvOS.xcscheme
+++ b/Surge.xcodeproj/xcshareddata/xcschemes/Surge-tvOS.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0930"
+   LastUpgradeVersion = "1100"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
@@ -27,6 +27,15 @@
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       shouldUseLaunchSchemeArgsEnv = "YES">
+      <MacroExpansion>
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "614AD3501FC0B001002BFE1C"
+            BuildableName = "Surge.framework"
+            BlueprintName = "Surge-tvOS"
+            ReferencedContainer = "container:Surge.xcodeproj">
+         </BuildableReference>
+      </MacroExpansion>
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -39,17 +48,6 @@
             </BuildableReference>
          </TestableReference>
       </Testables>
-      <MacroExpansion>
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "614AD3501FC0B001002BFE1C"
-            BuildableName = "Surge.framework"
-            BlueprintName = "Surge-tvOS"
-            ReferencedContainer = "container:Surge.xcodeproj">
-         </BuildableReference>
-      </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -70,8 +68,6 @@
             ReferencedContainer = "container:Surge.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"
diff --git a/Surge.xcodeproj/xcshareddata/xcschemes/Surge-watchOS.xcscheme b/Surge.xcodeproj/xcshareddata/xcschemes/Surge-watchOS.xcscheme
index ebac4400..01300064 100644
--- a/Surge.xcodeproj/xcshareddata/xcschemes/Surge-watchOS.xcscheme
+++ b/Surge.xcodeproj/xcshareddata/xcschemes/Surge-watchOS.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0930"
+   LastUpgradeVersion = "1100"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"
@@ -29,8 +29,6 @@
       shouldUseLaunchSchemeArgsEnv = "YES">
       <Testables>
       </Testables>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -51,8 +49,6 @@
             ReferencedContainer = "container:Surge.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"