Update build scripts #2302
Merged
Update build scripts #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lezek123
reviewed
Mar 30, 2021
| @@ -40,6 +41,9 @@ jobs: | |||
| - name: checks | |||
| run: | | |||
| yarn install --frozen-lockfile --network-timeout 120000 | |||
| yarn workspace @joystream/types build | |||
| yarn workspace @joystream/cd-schemas generate:all | |||
There was a problem hiding this comment.
We don't need to build cd-schemas here
.github/workflows/network-tests.yml
Outdated
| yarn workspace @joystream/types build | ||
| yarn workspace @joystream/cd-schemas generate:all | ||
| yarn workspace @joystream/cd-schemas build | ||
| yarn workspace @joystream/cli build |
There was a problem hiding this comment.
Is there a reason for building the CLI here?
.github/workflows/network-tests.yml
Outdated
| yarn workspace @joystream/types build | ||
| yarn workspace @joystream/cd-schemas generate:all | ||
| yarn workspace @joystream/cd-schemas build | ||
| yarn workspace @joystream/cli build |
There was a problem hiding this comment.
Is there a reason for building the CLI here?
| yarn workspace @joystream/cd-schemas generate:all | ||
| yarn workspace @joystream/cd-schemas build | ||
| yarn workspace query-node-root build | ||
| yarn workspace @joystream/cli build |
There was a problem hiding this comment.
Is there a reason for building the CLI here?
There was a problem hiding this comment.
I don't think query-node tests currently use the cli so will remove
Lezek123
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor polishing of README files and correcting ref to rust nightly version.
Pulled from sumer branch cleaner build scripts and updated READMEs.