Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Requires, reduce load time #26

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Drop Requires, reduce load time #26

merged 3 commits into from
Jul 6, 2022

Conversation

oschulz
Copy link
Collaborator

@oschulz oschulz commented Jul 6, 2022

Removes StatsBase support.
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #26 (19c681b) into main (4e340ac) will decrease coverage by 1.06%.
The diff coverage is 100.00%.

❗ Current head 19c681b differs from pull request most recent head 17bc6d9. Consider uploading reports for the commit 17bc6d9 to get more accurate results

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   94.91%   93.84%   -1.07%     
==========================================
  Files           7        5       -2     
  Lines         452      439      -13     
==========================================
- Hits          429      412      -17     
- Misses         23       27       +4     
Impacted Files Coverage Δ
src/array_of_similar_arrays.jl 94.15% <ø> (-0.04%) ⬇️
src/vector_of_arrays.jl 92.34% <ø> (-1.97%) ⬇️
src/arrays_of_static_arrays.jl 100.00% <100.00%> (ø)
src/ArraysOfArrays.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e340ac...17bc6d9. Read the comment docs.

@oschulz oschulz merged commit 17bc6d9 into main Jul 6, 2022
@oschulz oschulz deleted the no-requires branch July 6, 2022 10:52
@oschulz
Copy link
Collaborator Author

oschulz commented Jul 6, 2022

Before:

julia> @time_imports import InverseFunctions, ChainRulesCore, StatsBase, ArraysOfArrays
      1.1 ms  InverseFunctions
     57.3 ms  ChainRulesCore
     99.1 ms  StatsBase
    467.1 ms  ArraysOfArrays

After

julia> @time_imports import InverseFunctions, ChainRulesCore, StatsBase, ArraysOfArrays
      1.0 ms  InverseFunctions
     56.2 ms  ChainRulesCore
    103.2 ms  StatsBase
     60.2 ms  ArraysOfArrays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants