-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply ChainRulesCore.jl's projection operators #153
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import ChainRulesCore: ProjectTo, NoTangent | ||
|
||
""" | ||
ProjectTo(::Fill) -> ProjectTo{Fill} | ||
ProjectTo(::Ones) -> ProjectTo{NoTangent} | ||
|
||
Most FillArrays arrays store one number, and so their gradients under automatic | ||
differentiation represent the variation of this one number. | ||
|
||
The exception is those like `Ones` and `Zeros` whose type fixes their value, | ||
which have no graidient. | ||
""" | ||
ProjectTo(x::Fill{<:Number}) = ProjectTo{Fill}(; element = ProjectTo(getindex_value(x)), axes = axes(x)) | ||
|
||
ProjectTo(x::AbstractFill{Bool}) = ProjectTo{NoTangent}() # Bool is always regarded as categorical | ||
|
||
ProjectTo(x::Zeros) = ProjectTo{NoTangent}() | ||
ProjectTo(x::Ones) = ProjectTo{NoTangent}() | ||
|
||
function (project::ProjectTo{Fill})(dx::AbstractArray) | ||
for d in 1:max(ndims(dx), length(project.axes)) | ||
size(dx, d) == length(get(project.axes, d, 1)) || throw(_projection_mismatch(axes_x, size(dx))) | ||
end | ||
Fill(mean(dx), project.axes) # Note that mean(dx::Fill) is optimised | ||
end | ||
|
||
function _projection_mismatch(axes_x::Tuple, size_dx::Tuple) | ||
size_x = map(length, axes_x) | ||
DimensionMismatch("variable with size(x) == $size_x cannot have a gradient with size(dx) == $size_dx") | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need another rule for the constructor to multiply the mean dx by the length of the vector? Think of
x -> sum(Fill(x, 3))
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the equivalent of https://github.com/FluxML/Zygote.jl/blob/e6a86745d66b5974eaafa8a8f28bcd4b100374df/src/lib/array.jl#L17
If the constructor is close to where the Fill is used, then perhaps it's a little wasteful to first project like this, and then un-create. But not so serious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes