Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support converting Fills to StepRangeLen #290

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

dlfivefifty
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #290 (9e98677) into master (a718e2f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files           5        5           
  Lines         869      871    +2     
=======================================
+ Hits          868      870    +2     
  Misses          1        1           
Files Changed Coverage Δ
src/FillArrays.jl 99.74% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty
Copy link
Member Author

@jishnub do you know what I should do about invalidations?

@jishnub
Copy link
Member

jishnub commented Aug 22, 2023

This specific invalidation due to convert appears to be absent on v1.10, so perhaps we may ignore the error. In any case, I doubt that it's this package's fault, as the unique method in Base that leads to this has issues in its implementation.

@dlfivefifty dlfivefifty merged commit 48f6157 into master Aug 22, 2023
24 of 25 checks passed
@dlfivefifty dlfivefifty deleted the dl/rangeconvert branch August 22, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants