Merge pull request #326 from rdeits/fix-fsa-convert

remove a broken convert() method and test that it was unnecessary
JuliaArrays · Oct 24, 2017 · 715fefe · 715fefe
2 parents 11f371d + 992a4a2
commit 715fefe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/FixedSizeArrays.jl b/src/FixedSizeArrays.jl
@@ -157,7 +157,6 @@ macro fixed_vector(name, parent)
         end
         @inline Base.Tuple(v::$(name)) = v.data
         @inline Base.convert(::Type{$(name){S, T}}, x::NTuple{S, T}) where {S, T} = $(name){S, T}(x)
-        @inline Base.convert(::Type{$(name)}, x::StaticVector) = SV(x)
         @inline function Base.convert(::Type{$(name){S, T}}, x::Tuple) where {S, T}
             $(name){S, T}(convert(NTuple{S, T}, x))
         end

diff --git a/test/fixed_size_arrays.jl b/test/fixed_size_arrays.jl
@@ -171,6 +171,9 @@ for N = (1, 10)
             # from other FSA without parameters
             v2 = VT2(v1)
 
+            # No-op conversion to same type without parameters
+            @test convert(VT, v1) === v1
+
             @test typeof(v2) == VT2{N, ET}
             @test length(v2) == N
             @test eltype(v2) == ET