Merge pull request #56 from JuliaLang/roughly_vec

don't use pointwise isapprox for rough array comparisons
JuliaAttic · Aug 25, 2015 · 1355f41 · 1355f41
2 parents 257e30e + f3a07ae
commit 1355f41
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/src/helpers.jl b/src/helpers.jl
@@ -35,17 +35,11 @@ roughly(x::Number; kvtols...) = (y::Number) -> isapprox(y, x; kvtols...)
 
 roughly(A::AbstractArray, atol) = (B::AbstractArray) -> begin
     size(A) != size(B) && return false
-    for i in 1:length(A)
-        !isapprox(A[i], B[i], atol=atol) && return false
-    end
-    return true
+    return isapprox(A, B, atol=atol)
 end
 roughly(A::AbstractArray; kvtols...) = (B::AbstractArray) -> begin
     size(A) != size(B) && return false
-    for i in 1:length(A)
-        !isapprox(A[i], B[i]; kvtols...) && return false
-    end
-    return true
+    return isapprox(A, B; kvtols...)
 end
 
 # anyof: match any of the arguments